[MediaWiki-commits] [Gerrit] renamed var, unset it during initialization - change (mediawiki...ZeroPortal)

2014-10-03 Thread Yurik (Code Review) 
Yurik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/164603

Change subject: renamed var, unset it during initialization
..

renamed var, unset it during initialization

Change-Id: Ifc011ad49b462d2db3aa4e3ec822c7b7cfd74cdf
---
M ZeroPortal.php
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroPortal 
refs/changes/03/164603/1

diff --git a/ZeroPortal.php b/ZeroPortal.php
index b9249ad..85150f6 100644
--- a/ZeroPortal.php
+++ b/ZeroPortal.php
@@ -31,20 +31,21 @@
'url'  =  'https://www.mediawiki.org/wiki/Extension:ZeroPortal',
 );
 
-$cwd = __DIR__ . DIRECTORY_SEPARATOR;
-$wgMessagesDirs['ZeroPortal'] = $cwd . 'i18n';
-$wgExtensionMessagesFiles['ZeroPortal'] = $cwd . 'ZeroPortal.i18n.php';
+$zpDir = __DIR__ . DIRECTORY_SEPARATOR;
+$wgMessagesDirs['ZeroPortal'] = $zpDir . 'i18n';
+$wgExtensionMessagesFiles['ZeroPortal'] = $zpDir . 'ZeroPortal.i18n.php';
 
 // autoload extension classes
-$cwd .= 'includes' . DIRECTORY_SEPARATOR;
+$zpDir .= 'includes' . DIRECTORY_SEPARATOR;
 foreach ( array(
  'ApiZeroPortal',
  'ConfigPageHooks',
- 'ZeroConfigView',
  'PortalSpecialPage',
+ 'ZeroConfigView',
   ) as $key = $class ) {
-   $wgAutoloadClasses['ZeroPortal\\' . ( is_string( $key ) ? $key : $class 
)] = $cwd . $class . '.php';
+   $wgAutoloadClasses['ZeroPortal\\' . ( is_string( $key ) ? $key : $class 
)] = $zpDir . $class . '.php';
 }
+unset( $zpDir );
 
 $wgResourceModules['zeroportal.config'] = array(
'dependencies' = 'zerobanner.config.styles', // defined in ZeroBanner 
ext, used for sample banners

-- 
To view, visit https://gerrit.wikimedia.org/r/164603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc011ad49b462d2db3aa4e3ec822c7b7cfd74cdf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroPortal
Gerrit-Branch: master
Gerrit-Owner: Yurik yu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] renamed var, unset it during initialization - change (mediawiki...ZeroPortal)

2014-10-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: renamed var, unset it during initialization
..


renamed var, unset it during initialization

Change-Id: Ifc011ad49b462d2db3aa4e3ec822c7b7cfd74cdf
---
M ZeroPortal.php
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ZeroPortal.php b/ZeroPortal.php
index b9249ad..85150f6 100644
--- a/ZeroPortal.php
+++ b/ZeroPortal.php
@@ -31,20 +31,21 @@
'url'  =  'https://www.mediawiki.org/wiki/Extension:ZeroPortal',
 );
 
-$cwd = __DIR__ . DIRECTORY_SEPARATOR;
-$wgMessagesDirs['ZeroPortal'] = $cwd . 'i18n';
-$wgExtensionMessagesFiles['ZeroPortal'] = $cwd . 'ZeroPortal.i18n.php';
+$zpDir = __DIR__ . DIRECTORY_SEPARATOR;
+$wgMessagesDirs['ZeroPortal'] = $zpDir . 'i18n';
+$wgExtensionMessagesFiles['ZeroPortal'] = $zpDir . 'ZeroPortal.i18n.php';
 
 // autoload extension classes
-$cwd .= 'includes' . DIRECTORY_SEPARATOR;
+$zpDir .= 'includes' . DIRECTORY_SEPARATOR;
 foreach ( array(
  'ApiZeroPortal',
  'ConfigPageHooks',
- 'ZeroConfigView',
  'PortalSpecialPage',
+ 'ZeroConfigView',
   ) as $key = $class ) {
-   $wgAutoloadClasses['ZeroPortal\\' . ( is_string( $key ) ? $key : $class 
)] = $cwd . $class . '.php';
+   $wgAutoloadClasses['ZeroPortal\\' . ( is_string( $key ) ? $key : $class 
)] = $zpDir . $class . '.php';
 }
+unset( $zpDir );
 
 $wgResourceModules['zeroportal.config'] = array(
'dependencies' = 'zerobanner.config.styles', // defined in ZeroBanner 
ext, used for sample banners

-- 
To view, visit https://gerrit.wikimedia.org/r/164603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc011ad49b462d2db3aa4e3ec822c7b7cfd74cdf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroPortal
Gerrit-Branch: master
Gerrit-Owner: Yurik yu...@wikimedia.org
Gerrit-Reviewer: Yurik yu...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits