[MediaWiki-commits] [Gerrit] rubocop: ignore node_modules and fix a single offense - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: rubocop: ignore node_modules and fix a single offense .. rubocop: ignore node_modules and fix a single offense Make rubocop pass: - fix a trivial double quotes error - ignore 'node_modules' useful when one ran 'npm install' Change-Id: Id1ab83df0bec4fc7b223f33016c8f18316509b7a --- M .rubocop.yml M tests/browser/features/step_definitions/create_account_steps.rb 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 61ffc1a..5b6c3f2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,6 +1,7 @@ AllCops: Exclude: - 'extensions/**/*' +- 'node_modules/**/*' - 'skins/**/*' - 'tests/frontend/node_modules/**/*' - 'vendor/**/*' diff --git a/tests/browser/features/step_definitions/create_account_steps.rb b/tests/browser/features/step_definitions/create_account_steps.rb index 3d312f7..98e0f2c 100644 --- a/tests/browser/features/step_definitions/create_account_steps.rb +++ b/tests/browser/features/step_definitions/create_account_steps.rb @@ -22,5 +22,5 @@ end Then(/^an error message is displayed$/) do - expect(on(CreateAccountPage).error_message_element.class_name).to eq "errorbox" + expect(on(CreateAccountPage).error_message_element.class_name).to eq 'errorbox' end -- To view, visit https://gerrit.wikimedia.org/r/224046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ab83df0bec4fc7b223f33016c8f18316509b7a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Zfilipin Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rubocop: ignore node_modules and fix a single offense - change (mediawiki/core)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/224046 Change subject: rubocop: ignore node_modules and fix a single offense .. rubocop: ignore node_modules and fix a single offense Make rubocop pass: - fix a trivial double quotes error - ignore 'node_modules' useful when one ran 'npm install' Change-Id: Id1ab83df0bec4fc7b223f33016c8f18316509b7a --- M .rubocop.yml M tests/browser/features/step_definitions/create_account_steps.rb 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/46/224046/1 diff --git a/.rubocop.yml b/.rubocop.yml index 61ffc1a..5b6c3f2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,6 +1,7 @@ AllCops: Exclude: - 'extensions/**/*' +- 'node_modules/**/*' - 'skins/**/*' - 'tests/frontend/node_modules/**/*' - 'vendor/**/*' diff --git a/tests/browser/features/step_definitions/create_account_steps.rb b/tests/browser/features/step_definitions/create_account_steps.rb index 3d312f7..98e0f2c 100644 --- a/tests/browser/features/step_definitions/create_account_steps.rb +++ b/tests/browser/features/step_definitions/create_account_steps.rb @@ -22,5 +22,5 @@ end Then(/^an error message is displayed$/) do - expect(on(CreateAccountPage).error_message_element.class_name).to eq "errorbox" + expect(on(CreateAccountPage).error_message_element.class_name).to eq 'errorbox' end -- To view, visit https://gerrit.wikimedia.org/r/224046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1ab83df0bec4fc7b223f33016c8f18316509b7a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
