[MediaWiki-commits] [Gerrit] set cookie and refresh to make sure PDF links are expanded - change (qa/browsertests)
Cmcmahon has submitted this change and it was merged. Change subject: set cookie and refresh to make sure PDF links are expanded .. set cookie and refresh to make sure PDF links are expanded Change-Id: I8742ee82d76d7beb6339cc095684753cae81bf42 --- M features/step_definitions/pdf_steps.rb M features/support/pages/random_page.rb 2 files changed, 6 insertions(+), 7 deletions(-) Approvals: Cmcmahon: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/features/step_definitions/pdf_steps.rb b/features/step_definitions/pdf_steps.rb index 321f26c..0d78d42 100644 --- a/features/step_definitions/pdf_steps.rb +++ b/features/step_definitions/pdf_steps.rb @@ -1,18 +1,18 @@ Then(/^Download as PDF should be present$/) do + @browser.driver.manage.add_cookie(:name = 'vector-nav-p-coll-print_export', :value = 'true') + @browser.driver.navigate.refresh on(RandomPage).download_as_pdf_element.should exist end When(/^I click on Download as PDF$/) do - on(RandomPage) do |page| -page.print_or_export_element.when_present.click -page.download_as_pdf_element.when_present.click - end + @browser.driver.manage.add_cookie(:name = 'vector-nav-p-coll-print_export', :value = 'true') + @browser.driver.navigate.refresh + on(RandomPage).download_as_pdf end Then(/^Download the file link should be present$/) do on(RandomPage) do |page| -page.download_the_file_element.when_present(15) -page.download_the_file_element.should exist +page.download_the_file_element.when_present(15).should exist end end diff --git a/features/support/pages/random_page.rb b/features/support/pages/random_page.rb index 0799971..375a2f3 100644 --- a/features/support/pages/random_page.rb +++ b/features/support/pages/random_page.rb @@ -7,7 +7,6 @@ li(:main_page, id: 'n-mainpage-description') a(:download_as_pdf, text: 'Download as PDF') a(:download_the_file, text: 'Download the file') - a(:print_or_export, text: 'Print/export') a(:uls_trigger, class: 'uls-trigger') div(:search, id: 'search') text_field(:search_input, id: 'searchInput') -- To view, visit https://gerrit.wikimedia.org/r/62633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8742ee82d76d7beb6339cc095684753cae81bf42 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] set cookie and refresh to make sure PDF links are expanded - change (qa/browsertests)
Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/62633 Change subject: set cookie and refresh to make sure PDF links are expanded .. set cookie and refresh to make sure PDF links are expanded Change-Id: I8742ee82d76d7beb6339cc095684753cae81bf42 --- M features/step_definitions/pdf_steps.rb M features/support/pages/random_page.rb 2 files changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/33/62633/1 diff --git a/features/step_definitions/pdf_steps.rb b/features/step_definitions/pdf_steps.rb index 321f26c..0d78d42 100644 --- a/features/step_definitions/pdf_steps.rb +++ b/features/step_definitions/pdf_steps.rb @@ -1,18 +1,18 @@ Then(/^Download as PDF should be present$/) do + @browser.driver.manage.add_cookie(:name = 'vector-nav-p-coll-print_export', :value = 'true') + @browser.driver.navigate.refresh on(RandomPage).download_as_pdf_element.should exist end When(/^I click on Download as PDF$/) do - on(RandomPage) do |page| -page.print_or_export_element.when_present.click -page.download_as_pdf_element.when_present.click - end + @browser.driver.manage.add_cookie(:name = 'vector-nav-p-coll-print_export', :value = 'true') + @browser.driver.navigate.refresh + on(RandomPage).download_as_pdf end Then(/^Download the file link should be present$/) do on(RandomPage) do |page| -page.download_the_file_element.when_present(15) -page.download_the_file_element.should exist +page.download_the_file_element.when_present(15).should exist end end diff --git a/features/support/pages/random_page.rb b/features/support/pages/random_page.rb index 0799971..375a2f3 100644 --- a/features/support/pages/random_page.rb +++ b/features/support/pages/random_page.rb @@ -7,7 +7,6 @@ li(:main_page, id: 'n-mainpage-description') a(:download_as_pdf, text: 'Download as PDF') a(:download_the_file, text: 'Download the file') - a(:print_or_export, text: 'Print/export') a(:uls_trigger, class: 'uls-trigger') div(:search, id: 'search') text_field(:search_input, id: 'searchInput') -- To view, visit https://gerrit.wikimedia.org/r/62633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8742ee82d76d7beb6339cc095684753cae81bf42 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
