[MediaWiki-commits] [Gerrit] vagrant: Set umask 0002 for wikidev users - change (operations/puppet)

2015-12-06 Thread BryanDavis (Code Review) 
BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257263

Change subject: vagrant: Set umask 0002 for wikidev users
..

vagrant: Set umask 0002 for wikidev users

Make shared ownership and management of files in /srv/mediawiki-vagrant
easier by setting the default umask for wikidev users to 0002.

Bug: T120472
Change-Id: I1fec88f5dca2312213b40995ebc7aebf67e22d63
---
A modules/vagrant/files/umask-wikidev-profile-d.sh
M modules/vagrant/manifests/mediawiki.pp
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/63/257263/1

diff --git a/modules/vagrant/files/umask-wikidev-profile-d.sh 
b/modules/vagrant/files/umask-wikidev-profile-d.sh
new file mode 100644
index 000..3d0baab
--- /dev/null
+++ b/modules/vagrant/files/umask-wikidev-profile-d.sh
@@ -0,0 +1,5 @@
+# Set umask to 0002 for wikidev users to make shared management of
+# mediawiki-vagrant files easier
+if groups | grep -w -q wikidev; then
+  umask 0002
+fi
diff --git a/modules/vagrant/manifests/mediawiki.pp 
b/modules/vagrant/manifests/mediawiki.pp
index fbe9260..9294c86 100644
--- a/modules/vagrant/manifests/mediawiki.pp
+++ b/modules/vagrant/manifests/mediawiki.pp
@@ -71,4 +71,14 @@
 mode=> '0555',
 content => template('vagrant/labs-vagrant.erb'),
 }
+
+# Set umask for wikidev users so that newly-created files are g+w.
+# This makes shared ownership of $install_directory easier
+file { '/etc/profile.d/umask-wikidev.sh':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0444',
+source => 'puppet:///modules/vagrant/umask-wikidev-profile-d.sh',
+}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/257263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fec88f5dca2312213b40995ebc7aebf67e22d63
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] vagrant: Set umask 0002 for wikidev users - change (operations/puppet)

2015-12-06 Thread Yuvipanda (Code Review) 
Yuvipanda has submitted this change and it was merged.

Change subject: vagrant: Set umask 0002 for wikidev users
..


vagrant: Set umask 0002 for wikidev users

Make shared ownership and management of files in /srv/mediawiki-vagrant
easier by setting the default umask for wikidev users to 0002.

Bug: T120472
Change-Id: I1fec88f5dca2312213b40995ebc7aebf67e22d63
---
A modules/vagrant/files/umask-wikidev-profile-d.sh
M modules/vagrant/manifests/mediawiki.pp
2 files changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Yuvipanda: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/vagrant/files/umask-wikidev-profile-d.sh 
b/modules/vagrant/files/umask-wikidev-profile-d.sh
new file mode 100644
index 000..3d0baab
--- /dev/null
+++ b/modules/vagrant/files/umask-wikidev-profile-d.sh
@@ -0,0 +1,5 @@
+# Set umask to 0002 for wikidev users to make shared management of
+# mediawiki-vagrant files easier
+if groups | grep -w -q wikidev; then
+  umask 0002
+fi
diff --git a/modules/vagrant/manifests/mediawiki.pp 
b/modules/vagrant/manifests/mediawiki.pp
index fbe9260..9294c86 100644
--- a/modules/vagrant/manifests/mediawiki.pp
+++ b/modules/vagrant/manifests/mediawiki.pp
@@ -71,4 +71,14 @@
 mode=> '0555',
 content => template('vagrant/labs-vagrant.erb'),
 }
+
+# Set umask for wikidev users so that newly-created files are g+w.
+# This makes shared ownership of $install_directory easier
+file { '/etc/profile.d/umask-wikidev.sh':
+ensure => present,
+owner  => 'root',
+group  => 'root',
+mode   => '0444',
+source => 'puppet:///modules/vagrant/umask-wikidev-profile-d.sh',
+}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/257263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fec88f5dca2312213b40995ebc7aebf67e22d63
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits