[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Change label service suggestion to single line

2016-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Change label service suggestion to single line
..


Change label service suggestion to single line

The suggestion only inserts a single triple, and it is uncommon to add
more, so I don’t think the service needs to take up three lines in the
query by default. The single-line version also doesn’t need to be
adjusted for indentation.

Change-Id: I6c3fd3be5dee6a169c9d347c67e3e7a71c3e12fb
---
M wikibase/queryService/ui/editor/hint/Sparql.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikibase/queryService/ui/editor/hint/Sparql.js 
b/wikibase/queryService/ui/editor/hint/Sparql.js
index 5000b84..9df3934 100755
--- a/wikibase/queryService/ui/editor/hint/Sparql.js
+++ b/wikibase/queryService/ui/editor/hint/Sparql.js
@@ -12,7 +12,7 @@
var SPARQL_KEYWORDS = [
'SELECT', 'SELECT * WHERE {\n\n}', 'OPTIONAL', 
'OPTIONAL {\n\n}', 'WHERE',
'WHERE {\n\n}', 'ORDER', 'ORDER BY', 'DISTINCT', 
'SERVICE',
-   'SERVICE wikibase:label {\n bd:serviceParam 
wikibase:language "en" .\n}', 'BASE',
+   'SERVICE wikibase:label { bd:serviceParam 
wikibase:language "en" . }', 'BASE',
'PREFIX', 'REDUCED', 'FROM', 'LIMIT', 'OFFSET', 
'HAVING', 'UNION', 'SAMPLE',
'(SAMPLE() AS )', 'COUNT', '(COUNT() AS )', 'DESC', 
'DESC()', 'ASC', 'ASC()',
'FILTER ()', 'FILTER NOT EXISTS', 'FILTER NOT EXISTS 
{\n\n}', 'UNION', 'UNION {\n\n}',

-- 
To view, visit https://gerrit.wikimedia.org/r/324804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c3fd3be5dee6a169c9d347c67e3e7a71c3e12fb
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Change label service suggestion to single line

2016-12-01 Thread Lucas Werkmeister (Code Review) 
Lucas Werkmeister has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324804

Change subject: Change label service suggestion to single line
..

Change label service suggestion to single line

The suggestion only inserts a single triple, and it is uncommon to add
more, so I don’t think the service needs to take up three lines in the
query by default. The single-line version also doesn’t need to be
adjusted for indentation.

Change-Id: I6c3fd3be5dee6a169c9d347c67e3e7a71c3e12fb
---
M wikibase/queryService/ui/editor/hint/Sparql.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/04/324804/1

diff --git a/wikibase/queryService/ui/editor/hint/Sparql.js 
b/wikibase/queryService/ui/editor/hint/Sparql.js
index 5000b84..9df3934 100755
--- a/wikibase/queryService/ui/editor/hint/Sparql.js
+++ b/wikibase/queryService/ui/editor/hint/Sparql.js
@@ -12,7 +12,7 @@
var SPARQL_KEYWORDS = [
'SELECT', 'SELECT * WHERE {\n\n}', 'OPTIONAL', 
'OPTIONAL {\n\n}', 'WHERE',
'WHERE {\n\n}', 'ORDER', 'ORDER BY', 'DISTINCT', 
'SERVICE',
-   'SERVICE wikibase:label {\n bd:serviceParam 
wikibase:language "en" .\n}', 'BASE',
+   'SERVICE wikibase:label { bd:serviceParam 
wikibase:language "en" . }', 'BASE',
'PREFIX', 'REDUCED', 'FROM', 'LIMIT', 'OFFSET', 
'HAVING', 'UNION', 'SAMPLE',
'(SAMPLE() AS )', 'COUNT', '(COUNT() AS )', 'DESC', 
'DESC()', 'ASC', 'ASC()',
'FILTER ()', 'FILTER NOT EXISTS', 'FILTER NOT EXISTS 
{\n\n}', 'UNION', 'UNION {\n\n}',

-- 
To view, visit https://gerrit.wikimedia.org/r/324804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c3fd3be5dee6a169c9d347c67e3e7a71c3e12fb
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits