[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: More details for PendingQueueConsumer log

2016-09-15 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: More details for PendingQueueConsumer log
..


More details for PendingQueueConsumer log

$data doesn't show up in the Jenkins output

Change-Id: I4cae66bb390ab219879de1ba15c9e5ca4fbb76d8
---
M Core/QueueConsumers/PendingQueueConsumer.php
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Awight: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Core/QueueConsumers/PendingQueueConsumer.php 
b/Core/QueueConsumers/PendingQueueConsumer.php
index 7868487..733d9b7 100644
--- a/Core/QueueConsumers/PendingQueueConsumer.php
+++ b/Core/QueueConsumers/PendingQueueConsumer.php
@@ -23,12 +23,14 @@
}
 
public function processMessage( $message ) {
+   $logIdentifier = "message with gateway {$message['gateway']}" .
+   " and order ID {$message['order_id']}";
if ( $this->paymentsInitialDatabase->isTransactionFinalized( 
$message ) ) {
// Throw the message out if it's already completed or 
failed, and
// exists in the fredge database.
-   Logger::info( "Skipping finalized message", $message );
+   Logger::info( "Skipping finalized $logIdentifier" );
} else {
-   Logger::info( "Storing message in database", $message );
+   Logger::info( "Storing $logIdentifier in database" );
$this->pendingDatabase->storeMessage( $message );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/311071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cae66bb390ab219879de1ba15c9e5ca4fbb76d8
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: More details for PendingQueueConsumer log

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311071

Change subject: More details for PendingQueueConsumer log
..

More details for PendingQueueConsumer log

$data doesn't show up in the Jenkins output

Change-Id: I4cae66bb390ab219879de1ba15c9e5ca4fbb76d8
---
M Core/QueueConsumers/PendingQueueConsumer.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/71/311071/1

diff --git a/Core/QueueConsumers/PendingQueueConsumer.php 
b/Core/QueueConsumers/PendingQueueConsumer.php
index 7868487..733d9b7 100644
--- a/Core/QueueConsumers/PendingQueueConsumer.php
+++ b/Core/QueueConsumers/PendingQueueConsumer.php
@@ -23,12 +23,14 @@
}
 
public function processMessage( $message ) {
+   $logIdentifier = "message with gateway {$message['gateway']}" .
+   " and order ID {$message['order_id']}";
if ( $this->paymentsInitialDatabase->isTransactionFinalized( 
$message ) ) {
// Throw the message out if it's already completed or 
failed, and
// exists in the fredge database.
-   Logger::info( "Skipping finalized message", $message );
+   Logger::info( "Skipping finalized $logIdentifier" );
} else {
-   Logger::info( "Storing message in database", $message );
+   Logger::info( "Storing $logIdentifier in database" );
$this->pendingDatabase->storeMessage( $message );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/311071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cae66bb390ab219879de1ba15c9e5ca4fbb76d8
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits