[MediaWiki-commits] [Gerrit] wikimedia...civicrm[master]: Add null port to fix install requirements
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/363717 ) Change subject: Add null port to fix install requirements .. Add null port to fix install requirements Change-Id: I2ad9c788a06b0f3fff7fe15ae1450d53db621129 --- M install/index.php 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: jenkins-bot: Verified Ejegg: Looks good to me, approved diff --git a/install/index.php b/install/index.php index 79010ff..ccdbed1 100644 --- a/install/index.php +++ b/install/index.php @@ -569,7 +569,7 @@ $host = implode(':', $hostParts); } else { - $port = ''; + $port = null; } $conn = @mysqli_connect($host, $username, $password, $database, $port); return $conn; @@ -1268,7 +1268,6 @@ ) { $this->testing($testDetails); $conn = $this->connect($server, $username, $password); - $okay = NULL; if (@mysqli_select_db($conn, $database)) { $okay = "Database '$database' exists"; -- To view, visit https://gerrit.wikimedia.org/r/363717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ad9c788a06b0f3fff7fe15ae1450d53db621129 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/crm/civicrm Gerrit-Branch: master Gerrit-Owner: MeppsGerrit-Reviewer: Ejegg Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wikimedia...civicrm[master]: Add null port to fix install requirements
Mepps has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363717 ) Change subject: Add null port to fix install requirements .. Add null port to fix install requirements Change-Id: I2ad9c788a06b0f3fff7fe15ae1450d53db621129 --- M install/index.php 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm refs/changes/17/363717/1 diff --git a/install/index.php b/install/index.php index 79010ff..ccdbed1 100644 --- a/install/index.php +++ b/install/index.php @@ -569,7 +569,7 @@ $host = implode(':', $hostParts); } else { - $port = ''; + $port = null; } $conn = @mysqli_connect($host, $username, $password, $database, $port); return $conn; @@ -1268,7 +1268,6 @@ ) { $this->testing($testDetails); $conn = $this->connect($server, $username, $password); - $okay = NULL; if (@mysqli_select_db($conn, $database)) { $okay = "Database '$database' exists"; -- To view, visit https://gerrit.wikimedia.org/r/363717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ad9c788a06b0f3fff7fe15ae1450d53db621129 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/crm/civicrm Gerrit-Branch: master Gerrit-Owner: Mepps___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits