jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398780 )
Change subject: Extend risk score limiting to cover components of the score
......................................................................
Extend risk score limiting to cover components of the score
Bug: T183102
Change-Id: I3c1b1a0d24bad9a27930d8246f9fdc448b7f1219
---
M sites/all/modules/queue2civicrm/fredge/AntifraudQueueConsumer.php
M sites/all/modules/queue2civicrm/tests/data/payments-antifraud-high.json
M sites/all/modules/queue2civicrm/tests/phpunit/AntifraudQueueTest.php
3 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Cdentinger: Looks good to me, approved
jenkins-bot: Verified
diff --git a/sites/all/modules/queue2civicrm/fredge/AntifraudQueueConsumer.php
b/sites/all/modules/queue2civicrm/fredge/AntifraudQueueConsumer.php
index 0e5dfb0..9613f27 100644
--- a/sites/all/modules/queue2civicrm/fredge/AntifraudQueueConsumer.php
+++ b/sites/all/modules/queue2civicrm/fredge/AntifraudQueueConsumer.php
@@ -94,6 +94,9 @@
}
if ( $id ) {
foreach ( $msg['score_breakdown'] as $test => $score ) {
+ if ($score > 100000000) {
+ $score = 100000000;
+ }
$breakdown = array(
'payments_fraud_id' => $id,
'filter_name' => $test,
diff --git
a/sites/all/modules/queue2civicrm/tests/data/payments-antifraud-high.json
b/sites/all/modules/queue2civicrm/tests/data/payments-antifraud-high.json
index 91ce046..9ac3059 100644
--- a/sites/all/modules/queue2civicrm/tests/data/payments-antifraud-high.json
+++ b/sites/all/modules/queue2civicrm/tests/data/payments-antifraud-high.json
@@ -9,7 +9,8 @@
"getScoreUtmCampaignMap": "0",
"getScoreEmailDomainMap": "0",
"minfraud_filter": "0.10",
- "IPVelocityFilter": "0"
+ "IPVelocityFilter": "0",
+ "SessionVelocity" : "4.6602755623854E+38"
},
"php-message-class":
"SmashPig\\CrmLink\\Messages\\DonationInterfaceAntifraud",
"user_ip": "1.2.3.4",
diff --git
a/sites/all/modules/queue2civicrm/tests/phpunit/AntifraudQueueTest.php
b/sites/all/modules/queue2civicrm/tests/phpunit/AntifraudQueueTest.php
index feffc91..f577cc1 100644
--- a/sites/all/modules/queue2civicrm/tests/phpunit/AntifraudQueueTest.php
+++ b/sites/all/modules/queue2civicrm/tests/phpunit/AntifraudQueueTest.php
@@ -107,7 +107,7 @@
$dbEntries = $this->getDbEntries(
$common['contribution_tracking_id'], $common['order_id']
);
- $this->assertEquals( 8, count( $dbEntries ) );
+ $this->assertEquals( count($breakdown), count( $dbEntries ) );
$fields = array(
'gateway', 'validation_action', 'payment_method',
'risk_score', 'server'
@@ -121,8 +121,9 @@
);
foreach ( $dbEntries as $score ) {
$name = $score['filter_name'];
+ $expectedScore = $breakdown[$name] <= 100000000 ?
$breakdown[$name] : 100000000;
$this->assertEquals(
- $breakdown[$name], $score['fb_risk_score'],
"Mismatched $name score"
+ $expectedScore, $score['fb_risk_score'], "Mismatched $name score"
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/398780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c1b1a0d24bad9a27930d8246f9fdc448b7f1219
Gerrit-PatchSet: 4
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <ej...@ejegg.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
