[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove handling for bad data (language = '_' as we are clean...

2016-09-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Remove handling for bad data (language = '_' as we are cleaning 
that up
..


Remove handling for bad data (language = '_' as we are cleaning that up

Bug: T96410

Change-Id: I796d2e859da7d25dd8316dd795012cbd2397d066
---
M sites/all/modules/thank_you/thank_you.module
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ejegg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sites/all/modules/thank_you/thank_you.module 
b/sites/all/modules/thank_you/thank_you.module
index 69b0ccc..714ffc5 100644
--- a/sites/all/modules/thank_you/thank_you.module
+++ b/sites/all/modules/thank_you/thank_you.module
@@ -324,7 +324,7 @@
 }
 
 $locale = $contact['preferred_language'];
-if ( !$locale or substr( $locale, 0, 1 ) === '_' ) {
+if ( !$locale ) {
 watchdog( 'thank_you', "Donor language unknown.  Defaulting to 
English...", NULL, WATCHDOG_INFO );
 $locale = 'en';
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/310724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I796d2e859da7d25dd8316dd795012cbd2397d066
Gerrit-PatchSet: 6
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove handling for bad data (language = '_' as we are clean...

2016-09-14 Thread Eileen (Code Review)
Eileen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310724

Change subject: Remove handling for bad data (language = '_' as we are cleaning 
that up
..

Remove handling for bad data (language = '_' as we are cleaning that up

Bug: T96410

Change-Id: I796d2e859da7d25dd8316dd795012cbd2397d066
---
M sites/all/modules/thank_you/thank_you.module
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/24/310724/1

diff --git a/sites/all/modules/thank_you/thank_you.module 
b/sites/all/modules/thank_you/thank_you.module
index 69b0ccc..714ffc5 100644
--- a/sites/all/modules/thank_you/thank_you.module
+++ b/sites/all/modules/thank_you/thank_you.module
@@ -324,7 +324,7 @@
 }
 
 $locale = $contact['preferred_language'];
-if ( !$locale or substr( $locale, 0, 1 ) === '_' ) {
+if ( !$locale ) {
 watchdog( 'thank_you', "Donor language unknown.  Defaulting to 
English...", NULL, WATCHDOG_INFO );
 $locale = 'en';
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/310724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I796d2e859da7d25dd8316dd795012cbd2397d066
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits