[MediaWiki-commits] [Gerrit] wikimedia...rainbow[develop]: SRP visit times label fixes

2017-08-31 Thread Chelsyx (Code Review)
Chelsyx has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/375091 )

Change subject: SRP visit times label fixes
..


SRP visit times label fixes

Also added data checks & fixed a bug introduced with a new version
of tidyr (at least I think that's how the issue started)

Change-Id: Ia3f4e6b030858b382c0a7c336d6759d022ebf14e
---
M modules/page_visit_times.R
M server.R
M tab_documentation/survival.md
M ui.R
M utils.R
5 files changed, 56 insertions(+), 38 deletions(-)

Approvals:
  Chelsyx: Verified; Looks good to me, approved



diff --git a/modules/page_visit_times.R b/modules/page_visit_times.R
index 1321dd6..df1fbe9 100644
--- a/modules/page_visit_times.R
+++ b/modules/page_visit_times.R
@@ -22,7 +22,7 @@
 tidyr::spread(label, time) %>%
 polloi::reorder_columns() %>%
 polloi::smoother(smooth_level = 
polloi::smooth_switch(input$smoothing_global, input$smoothing_srp_ld_plot), 
rename = FALSE) %>%
-polloi::make_dygraph(xlab = "", ylab = "Time (s)", title = "Time at N% 
users leave the search results page") %>%
+polloi::make_dygraph(xlab = "", ylab = "Time (s)", title = "Time at which 
N% users leave the search results page") %>%
 dyAxis("x", ticker = "Dygraph.dateTicker", axisLabelFormatter = 
polloi::custom_axis_formatter,
axisLabelWidth = 100, pixelsPerLabel = 80) %>%
 dyRoller(rollPeriod = input$rolling_srp_ld_plot) %>%
diff --git a/server.R b/server.R
index 752f5ba..b91bcf9 100644
--- a/server.R
+++ b/server.R
@@ -80,18 +80,28 @@
   polloi::check_past_week(mobile_load_data, "Mobile Web load times"),
   polloi::check_yesterday(android_dygraph_set, "Android events"),
   polloi::check_past_week(android_load_data, "Android load times"),
+  polloi::check_yesterday(position_prop, "clicked result positions"),
+  polloi::check_past_week(position_prop, "clicked result positions"),
+  polloi::check_yesterday(source_prop, "source of search on Android"),
+  polloi::check_past_week(source_prop, "source of search on Android"),
   polloi::check_yesterday(ios_dygraph_set, "iOS events"),
   polloi::check_past_week(ios_load_data, "iOS load times"),
-  polloi::check_yesterday(dplyr::bind_rows(split_dataset), "API usage 
data"),
-  polloi::check_past_week(dplyr::bind_rows(split_dataset), "API usage 
data"),
+  polloi::check_yesterday(dplyr::bind_rows(split_dataset, .id = "api"), 
"API usage data"),
+  polloi::check_past_week(dplyr::bind_rows(split_dataset, .id = "api"), 
"API usage data"),
   polloi::check_yesterday(failure_data_with_automata, "zero results data"),
   polloi::check_past_week(failure_data_with_automata, "zero results data"),
   polloi::check_yesterday(suggestion_with_automata, "suggestions data"),
   polloi::check_past_week(suggestion_with_automata, "suggestions data"),
   polloi::check_yesterday(augmented_clickthroughs, "engagement % data"),
   polloi::check_past_week(augmented_clickthroughs, "engagement % data"),
-  polloi::check_yesterday(user_page_visit_dataset, "survival times"),
-  polloi::check_past_week(user_page_visit_dataset, "survival times"))
+  polloi::check_yesterday(paulscore_fulltext, "full-text PaulScores"),
+  polloi::check_past_week(paulscore_fulltext, "full-text PaulScores"),
+  polloi::check_yesterday(sister_search_traffic, "sister search traffic"),
+  polloi::check_past_week(sister_search_traffic, "sister search traffic"),
+  polloi::check_yesterday(user_page_visit_dataset, "page survival times"),
+  polloi::check_past_week(user_page_visit_dataset, "page survival times"),
+  polloi::check_yesterday(serp_page_visit_dataset, "serp survival times"),
+  polloi::check_past_week(serp_page_visit_dataset, "serp survival times"))
 notifications <- notifications[!vapply(notifications, is.null, FALSE)]
 return(dropdownMenu(type = "notifications", .list = notifications))
   })
diff --git a/tab_documentation/survival.md b/tab_documentation/survival.md
index e066ad5..ae7ab59 100644
--- a/tab_documentation/survival.md
+++ b/tab_documentation/survival.md
@@ -1,15 +1,15 @@
-Automated survival analysis: page visit times
+How long searchers stay on the visited search results
 ===
 
 When someone is randomly selected for search satisfaction tracking (using our 
[TSS2 schema](https://meta.wikimedia.org/wiki/Schema:TestSearchSatisfaction2)), 
we use a check-in system and survival analysis to estimate how long users stay 
on visited pages. To summarize the results on a daily basis, we record a set of 
statistics based on a measure formally known as "[median lethal 
dose](https://en.wikipedia.org/wiki/Median_lethal_dose)".
 
-This graph shows the length of time that must pass before N% of the users 
leave the page they visited. When the number goes up, we can infer that users 
are staying on the pages longer. In general, it appears it takes 15s to los

[MediaWiki-commits] [Gerrit] wikimedia...rainbow[develop]: SRP visit times label fixes

2017-08-31 Thread Bearloga (Code Review)
Bearloga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/375091 )

Change subject: SRP visit times label fixes
..

SRP visit times label fixes

Also added data checks & fixed a bug introduced with a new version
of tidyr (at least I think that's how the issue started)

Change-Id: Ia3f4e6b030858b382c0a7c336d6759d022ebf14e
---
M modules/page_visit_times.R
M server.R
M tab_documentation/survival.md
M ui.R
M utils.R
5 files changed, 56 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/rainbow 
refs/changes/91/375091/1

diff --git a/modules/page_visit_times.R b/modules/page_visit_times.R
index 1321dd6..df1fbe9 100644
--- a/modules/page_visit_times.R
+++ b/modules/page_visit_times.R
@@ -22,7 +22,7 @@
 tidyr::spread(label, time) %>%
 polloi::reorder_columns() %>%
 polloi::smoother(smooth_level = 
polloi::smooth_switch(input$smoothing_global, input$smoothing_srp_ld_plot), 
rename = FALSE) %>%
-polloi::make_dygraph(xlab = "", ylab = "Time (s)", title = "Time at N% 
users leave the search results page") %>%
+polloi::make_dygraph(xlab = "", ylab = "Time (s)", title = "Time at which 
N% users leave the search results page") %>%
 dyAxis("x", ticker = "Dygraph.dateTicker", axisLabelFormatter = 
polloi::custom_axis_formatter,
axisLabelWidth = 100, pixelsPerLabel = 80) %>%
 dyRoller(rollPeriod = input$rolling_srp_ld_plot) %>%
diff --git a/server.R b/server.R
index 752f5ba..b91bcf9 100644
--- a/server.R
+++ b/server.R
@@ -80,18 +80,28 @@
   polloi::check_past_week(mobile_load_data, "Mobile Web load times"),
   polloi::check_yesterday(android_dygraph_set, "Android events"),
   polloi::check_past_week(android_load_data, "Android load times"),
+  polloi::check_yesterday(position_prop, "clicked result positions"),
+  polloi::check_past_week(position_prop, "clicked result positions"),
+  polloi::check_yesterday(source_prop, "source of search on Android"),
+  polloi::check_past_week(source_prop, "source of search on Android"),
   polloi::check_yesterday(ios_dygraph_set, "iOS events"),
   polloi::check_past_week(ios_load_data, "iOS load times"),
-  polloi::check_yesterday(dplyr::bind_rows(split_dataset), "API usage 
data"),
-  polloi::check_past_week(dplyr::bind_rows(split_dataset), "API usage 
data"),
+  polloi::check_yesterday(dplyr::bind_rows(split_dataset, .id = "api"), 
"API usage data"),
+  polloi::check_past_week(dplyr::bind_rows(split_dataset, .id = "api"), 
"API usage data"),
   polloi::check_yesterday(failure_data_with_automata, "zero results data"),
   polloi::check_past_week(failure_data_with_automata, "zero results data"),
   polloi::check_yesterday(suggestion_with_automata, "suggestions data"),
   polloi::check_past_week(suggestion_with_automata, "suggestions data"),
   polloi::check_yesterday(augmented_clickthroughs, "engagement % data"),
   polloi::check_past_week(augmented_clickthroughs, "engagement % data"),
-  polloi::check_yesterday(user_page_visit_dataset, "survival times"),
-  polloi::check_past_week(user_page_visit_dataset, "survival times"))
+  polloi::check_yesterday(paulscore_fulltext, "full-text PaulScores"),
+  polloi::check_past_week(paulscore_fulltext, "full-text PaulScores"),
+  polloi::check_yesterday(sister_search_traffic, "sister search traffic"),
+  polloi::check_past_week(sister_search_traffic, "sister search traffic"),
+  polloi::check_yesterday(user_page_visit_dataset, "page survival times"),
+  polloi::check_past_week(user_page_visit_dataset, "page survival times"),
+  polloi::check_yesterday(serp_page_visit_dataset, "serp survival times"),
+  polloi::check_past_week(serp_page_visit_dataset, "serp survival times"))
 notifications <- notifications[!vapply(notifications, is.null, FALSE)]
 return(dropdownMenu(type = "notifications", .list = notifications))
   })
diff --git a/tab_documentation/survival.md b/tab_documentation/survival.md
index e066ad5..ae7ab59 100644
--- a/tab_documentation/survival.md
+++ b/tab_documentation/survival.md
@@ -1,15 +1,15 @@
-Automated survival analysis: page visit times
+How long searchers stay on the visited search results
 ===
 
 When someone is randomly selected for search satisfaction tracking (using our 
[TSS2 schema](https://meta.wikimedia.org/wiki/Schema:TestSearchSatisfaction2)), 
we use a check-in system and survival analysis to estimate how long users stay 
on visited pages. To summarize the results on a daily basis, we record a set of 
statistics based on a measure formally known as "[median lethal 
dose](https://en.wikipedia.org/wiki/Median_lethal_dose)".
 
-This graph shows the length of time that must pass before N% of the users 
leave the page they visited. When the number goes up, we can infer that users 
are staying on the pages longer. In general,