[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update SmashPig for typo fix

2017-08-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/373132 )

Change subject: Update SmashPig for typo fix
..


Update SmashPig for typo fix

Change-Id: Ie843ed0a21fb8229650adf759eaeed984f1ffc4b
---
M composer/installed.json
M wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
M wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Ejegg: Looks good to me, approved



diff --git a/composer/installed.json b/composer/installed.json
index 80d3591..77a0f4b 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -1942,7 +1942,7 @@
 "source": {
 "type": "git",
 "url": 
"https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig.git;,
-"reference": "f7b8b3b1fcbe1bb8ece2de5968f653891661f1b9"
+"reference": "b1822378fb781a510058c9b620258e0fafedada4"
 },
 "require": {
 "amzn/login-and-pay-with-amazon-sdk-php": "dev-master",
@@ -1960,7 +1960,7 @@
 "jakub-onderka/php-parallel-lint": "^0.9",
 "phpunit/phpunit": "^4.8"
 },
-"time": "2017-08-22T16:37:45+00:00",
+"time": "2017-08-22T18:13:48+00:00",
 "type": "library",
 "installation-source": "source",
 "autoload": {
diff --git 
a/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php 
b/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
index 5d03343..0ec05d2 100644
--- a/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
+++ b/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
@@ -120,9 +120,9 @@
protected function parseRefund( DOMElement $recordNode, $type ) {
$record = $this->xmlToArray( $recordNode, $this->refundMap );
$record['type'] = $type;
-   // FIXME: Transaction ID is the same as the parent transaction 
ID.
+   // FIXME: Refund ID is the same as the parent transaction ID.
// That's not helpful...
-   $record['gateway_txn_id'] = $record['gateway_parent_id'];
+   $record['gateway_refund_id'] = $record['gateway_parent_id'];
if ( $record['installment'] < 0 ) {
// Refunds have negative EffortID. Weird.
// TODO: for refunds of recurring payments, determine 
whether the
diff --git 
a/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php 
b/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
index 428dff5..e63f1a3 100644
--- a/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
+++ b/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
@@ -85,7 +85,7 @@
'date' => 1500942220,
'gross' => 100,
'gateway_parent_id' => '123456789',
-   'gateway_txn_id' => '123456789',
+   'gateway_refund_id' => '123456789',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'refund',
@@ -107,7 +107,7 @@
'date' => 1495023569,
'gross' => 200,
'gateway_parent_id' => '5167046621',
-   'gateway_txn_id' => '5167046621',
+   'gateway_refund_id' => '5167046621',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'chargeback',

-- 
To view, visit https://gerrit.wikimedia.org/r/373132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie843ed0a21fb8229650adf759eaeed984f1ffc4b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/vendor
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update SmashPig for typo fix

2017-08-22 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373132 )

Change subject: Update SmashPig for typo fix
..

Update SmashPig for typo fix

Change-Id: Ie843ed0a21fb8229650adf759eaeed984f1ffc4b
---
M composer/installed.json
M wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
M wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
3 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/vendor 
refs/changes/32/373132/1

diff --git a/composer/installed.json b/composer/installed.json
index 80d3591..77a0f4b 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -1942,7 +1942,7 @@
 "source": {
 "type": "git",
 "url": 
"https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig.git;,
-"reference": "f7b8b3b1fcbe1bb8ece2de5968f653891661f1b9"
+"reference": "b1822378fb781a510058c9b620258e0fafedada4"
 },
 "require": {
 "amzn/login-and-pay-with-amazon-sdk-php": "dev-master",
@@ -1960,7 +1960,7 @@
 "jakub-onderka/php-parallel-lint": "^0.9",
 "phpunit/phpunit": "^4.8"
 },
-"time": "2017-08-22T16:37:45+00:00",
+"time": "2017-08-22T18:13:48+00:00",
 "type": "library",
 "installation-source": "source",
 "autoload": {
diff --git 
a/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php 
b/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
index 5d03343..0ec05d2 100644
--- a/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
+++ b/wikimedia/smash-pig/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
@@ -120,9 +120,9 @@
protected function parseRefund( DOMElement $recordNode, $type ) {
$record = $this->xmlToArray( $recordNode, $this->refundMap );
$record['type'] = $type;
-   // FIXME: Transaction ID is the same as the parent transaction 
ID.
+   // FIXME: Refund ID is the same as the parent transaction ID.
// That's not helpful...
-   $record['gateway_txn_id'] = $record['gateway_parent_id'];
+   $record['gateway_refund_id'] = $record['gateway_parent_id'];
if ( $record['installment'] < 0 ) {
// Refunds have negative EffortID. Weird.
// TODO: for refunds of recurring payments, determine 
whether the
diff --git 
a/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php 
b/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
index 428dff5..e63f1a3 100644
--- a/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
+++ b/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
@@ -85,7 +85,7 @@
'date' => 1500942220,
'gross' => 100,
'gateway_parent_id' => '123456789',
-   'gateway_txn_id' => '123456789',
+   'gateway_refund_id' => '123456789',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'refund',
@@ -107,7 +107,7 @@
'date' => 1495023569,
'gross' => 200,
'gateway_parent_id' => '5167046621',
-   'gateway_txn_id' => '5167046621',
+   'gateway_refund_id' => '5167046621',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'chargeback',

-- 
To view, visit https://gerrit.wikimedia.org/r/373132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie843ed0a21fb8229650adf759eaeed984f1ffc4b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/vendor
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits