[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Buttons always visible

2016-08-15 Thread Felipe Schenone (Code Review) 
Felipe Schenone has submitted this change and it was merged.

Change subject: Buttons always visible
..


Buttons always visible

The "Insert", "Update" and "Show all paramters" buttons where only
visible when scrolling to the bottom of the parameter list. Now they
are always visible.

Change-Id: Ic189b0f7b66412640f837c3d48d51a6b44acc245
---
M proveit.css
M proveit.js
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Zppix: Looks good to me, but someone else must approve
  Felipe Schenone: Verified; Looks good to me, approved



diff --git a/proveit.css b/proveit.css
index f07cf2d..c9ade11 100755
--- a/proveit.css
+++ b/proveit.css
@@ -172,6 +172,8 @@
 }
 
 #proveit-buttons {
+   border: 1px solid #ddd;
+   display: none;
padding: 10px;
text-align: right;
 }
diff --git a/proveit.js b/proveit.js
index a64fcc3..3b3a024 100755
--- a/proveit.js
+++ b/proveit.js
@@ -222,8 +222,8 @@
logo.prepend( leftBracket ).append( rightBracket );
header.append( logo, editTab, addTab );
buttons.append( showAllParamsButton, updateButton, insertButton 
);
-   content.append( referenceList, referenceFormContainer, buttons 
);
-   gui.append( header, content );
+   content.append( referenceList, referenceFormContainer );
+   gui.append( header, content, buttons );
$( document.body ).prepend( gui );
 
// Lastly, bind events

-- 
To view, visit https://gerrit.wikimedia.org/r/304243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic189b0f7b66412640f837c3d48d51a6b44acc245
Gerrit-PatchSet: 2
Gerrit-Project: wikipedia/gadgets/ProveIt
Gerrit-Branch: master
Gerrit-Owner: Felipe Schenone 
Gerrit-Reviewer: Felipe Schenone 
Gerrit-Reviewer: Zppix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Buttons always visible

2016-08-11 Thread Felipe Schenone (Code Review) 
Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/304243

Change subject: Buttons always visible
..

Buttons always visible

Change-Id: Ic189b0f7b66412640f837c3d48d51a6b44acc245
---
M proveit.css
M proveit.js
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikipedia/gadgets/ProveIt 
refs/changes/43/304243/1

diff --git a/proveit.css b/proveit.css
index f07cf2d..c9ade11 100755
--- a/proveit.css
+++ b/proveit.css
@@ -172,6 +172,8 @@
 }
 
 #proveit-buttons {
+   border: 1px solid #ddd;
+   display: none;
padding: 10px;
text-align: right;
 }
diff --git a/proveit.js b/proveit.js
index a64fcc3..3b3a024 100755
--- a/proveit.js
+++ b/proveit.js
@@ -222,8 +222,8 @@
logo.prepend( leftBracket ).append( rightBracket );
header.append( logo, editTab, addTab );
buttons.append( showAllParamsButton, updateButton, insertButton 
);
-   content.append( referenceList, referenceFormContainer, buttons 
);
-   gui.append( header, content );
+   content.append( referenceList, referenceFormContainer );
+   gui.append( header, content, buttons );
$( document.body ).prepend( gui );
 
// Lastly, bind events

-- 
To view, visit https://gerrit.wikimedia.org/r/304243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic189b0f7b66412640f837c3d48d51a6b44acc245
Gerrit-PatchSet: 1
Gerrit-Project: wikipedia/gadgets/ProveIt
Gerrit-Branch: master
Gerrit-Owner: Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits