[MediaWiki-commits] [Gerrit] zookeeper: Don't expose the JMX port in ferm rules - change (operations/puppet)

2015-11-09 Thread Muehlenhoff (Code Review) 
Muehlenhoff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/251951

Change subject: zookeeper: Don't expose the JMX port in ferm rules
..

zookeeper: Don't expose the JMX port in ferm rules

Change-Id: Ie029f9d9a495c291410d002cf8361009bd8eebb3
---
M manifests/role/zookeeper.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/51/251951/1

diff --git a/manifests/role/zookeeper.pp b/manifests/role/zookeeper.pp
index 60f85ca..cc818fe 100644
--- a/manifests/role/zookeeper.pp
+++ b/manifests/role/zookeeper.pp
@@ -53,8 +53,8 @@
 
 ferm::service { 'zookeeper':
 proto  => 'tcp',
-# Zookeeper client, protocol, and jmx listen ports.
-port   => "(2181 2182 2183 ${$::zookeeper::server::jmx_port})",
+# Zookeeper client, protocol ports
+port   => "(2181 2182 2183)",
 srange => '($INTERNAL)',
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/251951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie029f9d9a495c291410d002cf8361009bd8eebb3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] zookeeper: Don't expose the JMX port in ferm rules - change (operations/puppet)

2015-11-09 Thread Muehlenhoff (Code Review) 
Muehlenhoff has submitted this change and it was merged.

Change subject: zookeeper: Don't expose the JMX port in ferm rules
..


zookeeper: Don't expose the JMX port in ferm rules

Change-Id: Ie029f9d9a495c291410d002cf8361009bd8eebb3
---
M manifests/role/zookeeper.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ottomata: Looks good to me, but someone else must approve
  Muehlenhoff: Verified; Looks good to me, approved



diff --git a/manifests/role/zookeeper.pp b/manifests/role/zookeeper.pp
index 60f85ca..cc818fe 100644
--- a/manifests/role/zookeeper.pp
+++ b/manifests/role/zookeeper.pp
@@ -53,8 +53,8 @@
 
 ferm::service { 'zookeeper':
 proto  => 'tcp',
-# Zookeeper client, protocol, and jmx listen ports.
-port   => "(2181 2182 2183 ${$::zookeeper::server::jmx_port})",
+# Zookeeper client, protocol ports
+port   => "(2181 2182 2183)",
 srange => '($INTERNAL)',
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/251951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie029f9d9a495c291410d002cf8361009bd8eebb3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits