Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-05 Thread Arun Ravindran 

Hi Shane,



We can do this one of two ways:

1) I apply these as is (with the only caveat being to please make the
commit message more concise and to the point)

I saw your patch, and it looks better. The key merge key handling is 
more robust now, please apply this as is.



2) You resubmit the patch, taking into account the changes I made to
yours in my add on patch.  Principally, I want to be sure you capture
the renaming of all instances of [Mm]ultiParty* to [Mm]ultiparty* and
the change from bool based multipartyCalls() to int returning
multipartyCallCount(), as described in my commit message.




Regards
Arun


___
MeeGo-handset mailing list
MeeGo-handset@lists.meego.com
http://lists.meego.com/listinfo/meego-handset

Re: [Meego-handset] [Patch] Fixed: BMC# 8559 - Non-emergency call (Was: Dialer: Emergency Call Support Patches Try 1)

2011-04-05 Thread Shane Bryan 
On Tue, 5 Apr 2011 11:38:29 +0300
Arun Ravindran ext-arun.1.ravind...@nokia.com wrote:

 Hi Shane,
 
  This fixes the behavior where the user is able to make normal call
even if there is no SIM.
As you know the emergency call support is non existent in
   oFono, at least we filter the call attempt here.
  Arun,
 
  OK, I've re-worked your patch for BMC#8559, making changes per my
  previous comments.
 
  If you approve of my revisions, I'll apply this to master.
 
 
 I am fine with your modifications, please push this to master.
 
  One observation I have though is that this is really quite
  un-testable (at least AFAICS) on the master branch because the only
  way right now to put the modem into flight mode is to offline it,
  but this will cause the CallManager instance to become invalid
  since oFono will remove the VoiceCallManager interface in this mode.
 
 The VoiceCallManager interface is created pre_sim, and remains as
 long as the modem is powered on.

Hmm... that does not seem to be what I actually see happening... I'll
need to take a closer look then.

When I run the offline-modem script from the ofono test suite, all
further attempts to work with the modem are failing, including onlining
it.

 
  I don't have an invalid SIM or one with FDN/BDN enabled either.
 
  Do you have other suggestions on how to test this on the master
  branch?
 
 Testing the dialer when the modem is offline is the best way. We are 
 only interested in the user getting a note about what type of calls
 he can make,
 because making emergency call is not yet a functionality in oFono.
 

Understood, just hoping you had found a better or different way of
testing.

Shane...
___
MeeGo-handset mailing list
MeeGo-handset@lists.meego.com
http://lists.meego.com/listinfo/meego-handset

[Meego-handset] Dialer Project meeting minutes for Tuesday 4/5

2011-04-05 Thread Shane Bryan 
==
#meego-meeting: Dialer Project meeting
==

Meeting started by sabotage at 15:00:05 UTC.

Online minutes:
http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-05-15.00.html
Full IRC meeting log:
http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-05-15.00.log.html


Meeting summary
---
* Meeting info at http://wiki.meego.com/Project/Dialer/Meetings
  (sabotage, 15:00:46)
* sabotage is author maintainer of meego-handset-dialer  (sabotage,
  15:01:58)
* crevetor is Antoine Reversat, helping hand, wants to work on the QML
  version of the dialer  (sabotage, 15:02:06)
* introductions  (sabotage, 15:02:38)
  * More about who's who in the project is at
http://wiki.meego.com/Project/Dialer/Meetings#Preface  (sabotage,
15:04:17)
  * aruravi part of N900 hardware adaptation and DE Voice/SMS team
(sabotage, 15:04:26)
  * jukkaeklund, N900 DE product manager and very interested in the
topic :)  (sabotage, 15:05:17)
  * essi is the Team lead for VoiceSMS project on the N900 Developer
Edition  (sabotage, 15:06:43)
  * zolkis: I am architect for RTCom in Harmattan, including a dialer
too, so naturally interested on the MeeGo dialer  (sabotage,
15:07:33)
  * kallam has provided a bunck of Resource Policy Manager additions to
Dialer  (sabotage, 15:08:40)
  * kallam: Kalle Lampila member of N900 hardware adatation team
(sabotage, 15:08:56)

* Two Meetings (Dialer and VoiceSMS)  (sabotage, 15:09:17)
  * GCF == Global Certification Forum  (sabotage, 15:18:53)
  * LINK:
http://www.globalcertificationforum.org/WebSite/public/home_public.aspx
(sabotage, 15:18:56)
  * ACTION: sabotage to discuss project goals and meeting combination
with essi  (sabotage, 15:19:26)
  * AGREED:   (sabotage, 15:19:34)

* Wire frames  (sabotage, 15:21:12)
  * Dialer wireframes to be released any day now  (sabotage, 15:30:50)
  * ACTION: sabotage to find out more detail and make it available ASAP
(sabotage, 15:31:12)

* bugs and features  (sabotage, 15:32:20)
  * LINK:

https://bugs.meego.com/buglist.cgi?query_format=advancedfield0-0-0=flagtypes.nametype0-0-0=equalsvalue0-0-0=MeeGo_N900DE_Release_Blocker%2Bcomponent=Dialerproduct=Handset%20User%20Experienceclassification=MeeGo%20Platform
(sabotage, 15:34:05)
  * Dialer history is not changing right now until the tracker vs. EDS
issues have settled out  (sabotage, 15:42:46)

* Bug owner volunteers  (sabotage, 15:46:19)
  * LINK: Open dialer bugs

https://bugs.meego.com/buglist.cgi?cmdtype=runnamednamedcmd=Open%20Dialer%20Bugs
(sabotage, 15:48:09)
  * LINK: Open dialer bugs http://wiki.meego.com/Project/Dialer#Bugs
(sabotage, 15:49:38)
  * LINK: Open dialer bugs alternate link  (sabotage, 15:50:28)
  * LINK:

https://bugs.meego.com/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDcolumnlist=bug_severity%2Cpriority%2Cassigned_to%2Ccomponent%2Cbug_status%2Cresolution%2Cshort_desccomponent=Dialerclassification=MeeGo%20Platformknown_name=Open%20Dialer%20Bugsquery_based_on=Open%20Diale
(sabotage, 15:50:30)
  * LINK:(sabotage, 15:50:42)
  * LINK:

https://bugs.meego.com/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDcolumnlist=bug_severity%2Cpriority%2Cassigned_to%2Ccomponent%2Cbug_status%2Cresolution%2Cshort_desccomponent=Dialerclassification=MeeGo%20Platformknown_name=Open%20Dialer%20Bugsquery_based_on=Open%20Diale
(sabotage, 15:50:44)
  * ACTION: anyone who wants to own a bug, please set the assigned to to
yourself  (sabotage, 15:53:14)

* Headless Dialer  (sabotage, 15:53:54)
  * assuming highlander and aruravi agree that it's working, and I can
test it successfully, I want to move headless branch to master ASAP
(sabotage, 15:56:35)

* QML dialer  (sabotage, 15:57:09)
  * ACTION: alterego please provide URL to your QML dialer source
(sabotage, 16:00:16)
  * LINK: http://gitorious.org/qml-meego-dialer   (alterego, 16:00:31)
  * sabotage set up a Wiki page to start tracking this
http://wiki.meego.com/Project/Dialer/QMLMigration  (sabotage,
16:00:51)
  * LINK: http://wiki.meego.com/Project/Dialer/QMLMigration   (sabotage,
16:00:54)

Meeting ended at 16:01:12 UTC.




Action Items

* sabotage to discuss project goals and meeting combination with essi
* sabotage to find out more details [wireframe release] and make it 
  available ASAP
* anyone who wants to own a bug, please set the assigned to to yourself
* alterego please provide URL to your QML dialer source




Action Items, by person
---
* alterego
  * alterego please provide URL to your QML dialer source
* sabotage
  * sabotage to discuss project goals and

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com

2011-04-05 Thread Shane Bryan 
On Tue, 5 Apr 2011 10:16:44 +0300
Arun Ravindran ext-arun.1.ravind...@nokia.com wrote:

 Hi Shane,
 
 
  We can do this one of two ways:
 
  1) I apply these as is (with the only caveat being to please make
  the commit message more concise and to the point)
 
 I saw your patch, and it looks better. The key merge key handling is 
 more robust now, please apply this as is.

Done, pushed to master.

Shane...
___
MeeGo-handset mailing list
MeeGo-handset@lists.meego.com
http://lists.meego.com/listinfo/meego-handset