mercurial-devel | Failed pipeline for branch/default | 81623652
Pipeline #56305 has failed! Project: mercurial-devel ( https://foss.heptapod.net/mercurial/mercurial-devel ) Branch: branch/default ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commits/branch/default ) Commit: 81623652 ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commit/81623652376510c653f9529be3b6c86a391438fd ) Commit Message: bisect: avoid adding irrelevant revisions to bi... Commit Author: Arun Kulshreshtha ( https://foss.heptapod.net/akulshreshtha ) Pipeline #56305 ( https://foss.heptapod.net/mercurial/mercurial-devel/-/pipelines/56305 ) triggered by Raphaël Gomès ( https://foss.heptapod.net/raphael.gomes ) had 1 failed job. Job #627284 ( https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/627284/raw ) Stage: tests Name: test-chg -- You're receiving this email because of your account on foss.heptapod.net. ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
mercurial@49442: 3 new changesets
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/a0b57cabc245 changeset: 49440:a0b57cabc245 user:Arun Kulshreshtha date:Tue Aug 23 17:31:13 2022 -0400 summary: bisect: bypass changectx when translating revs to nodes https://www.mercurial-scm.org/repo/hg/rev/3ef153aa1eed changeset: 49441:3ef153aa1eed user:Arun Kulshreshtha date:Tue Aug 23 17:31:19 2022 -0400 summary: bisect: limit ancestors to revs topologically between good and bad revs https://www.mercurial-scm.org/repo/hg/rev/816236523765 changeset: 49442:816236523765 bookmark:@ tag: tip user:Arun Kulshreshtha date:Tue Aug 23 17:31:27 2022 -0400 summary: bisect: avoid adding irrelevant revisions to bisect state -- Repository URL: https://www.mercurial-scm.org/repo/hg ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: Rust error stratergy in the hg codebase
Update, I've posted the same thing over on Reddit¹ and have gotten advice consistent with my discussions with other people (thanks Yuya!). So unless someone objects to any of this, I'll have a somewhat difficult refactor ahead of my, but at least with a pretty clear plan. Raphaël [1] https://old.reddit.com/r/rust/comments/wuomjt/help_needed_for_error_stratergy_inside_mercurial/ On 8/22/22 11:06, Raphaël Gomès wrote: Hi all, I've been having an ergonomic issue with error handling lately. Error handling strategy used to be kind of a rough edge in Rust because of the different constraints of both the compiler and the standard library. Lately it seems that most projects are happy with using a mix of `thiserror`/`anyhow`/`eyere`/`snafu`, however when investigating using (a potential combination) of them, they don't appear to allow for all the constraints that we have. Rust errors in the hg codebase: - need to be matchable at the library layers (basically that everything inside `hg-core` exposes enums) - need to carry enough information for end-users to make sense of the issue and/or devs to be able to help end-users with it - need to match the Python implementation's user-facing behavior basically exactly (we can have some leeway for OS errors, I guess, but the point is to leave the formatting to us and not a library) - shouldn't do any formatting inside `hg-core`, that should be left to consumers of `hg-core` (though having a default formatting isn't a bad idea for debugging) - shouldn't assume that data is somehow UTF8 (ties in to the last point), as we have non-UTF8 data we need to format using `format_bytes` or equivalent (no popular crate seems to care since it's a pretty niche need) - need to compose somehow, since not all code can be perfectly hierarchical: the `dirstate` module needs to call functions that may return a `RevsetError` and the `revset` module needs to call functions that may return a `DirstateError`, creating cycles in error enums (this is the big one for me that started this refactor and questioning). So I'm calling to the Rust experts, or at least people that have some experience with working in larger Rust codebases about what the optimal strategy would be. Thanks, Raphaël ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Two-weeks absence and slower review cadance
Hi all, I wanted to warn all contributors that I will be basically out (but not unreachable for emergencies) for at least 2 weeks starting on September 3rd. My own review cadence has already slowed down because of the amount of urgent things I need to care of currently, though I'll still take time to 6.2.2 next week. I have patches of my own that have been sitting still for a good while, I'd appreciate if we didn't let them bitrot too much. If anyone with push access has questions on how to help out, please reach out: this is not limited to my patches of course. Thanks, Raphaël ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
mercurial@49439: new changeset
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b07465adbcc8 changeset: 49439:b07465adbcc8 bookmark:@ tag: tip user:Arseniy Alekseyev date:Wed Aug 24 16:38:13 2022 +0100 summary: rhg: make [rhg status -v] work when it needs no extra output -- Repository URL: https://www.mercurial-scm.org/repo/hg ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
mercurial@49438: 2 new changesets
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/a3ac3f1623dd changeset: 49437:a3ac3f1623dd parent: 49432:b4535c88a05b user:Pierre-Yves David date:Thu Jul 28 15:41:45 2022 +0200 summary: debug-delta-find: introduce a quiet mode https://www.mercurial-scm.org/repo/hg/rev/44d4fd09982f changeset: 49438:44d4fd09982f bookmark:@ tag: tip user:Pierre-Yves David date:Thu Jul 28 16:25:21 2022 +0200 summary: perf: introduce a benchmark for delta-find -- Repository URL: https://www.mercurial-scm.org/repo/hg ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
