Re: Moving away from Phabricator

[Georges Racinet]

Hi Greg,

On 2/27/22 20:45, Gregory Szorc wrote:
I agree we should move off Phabricator since it is unsupported. This 
is painful for me to say, as the stack-based reviews that this project 
practiced on Phabricator is the best code review workflow I've 
practiced and seen in my career.


As for what's next, I'd say Gerrit probably has the next best review 
tool for commit stacks. Review Board gained better support for 
commit-by-commit reviews in the last year or two (but I have yet to 
use it). Gerrit, unfortunately, is heavily wedded to Git. I'm not sure 
if we could shoehorn Mercurial to work [well] with Gerrit even if we 
tried. So that may rule it out.


I do like the idea of having a more streamlined experience for things 
like running CI along with your review submission. I also like not 
having to think about maintaining this infrastructure or consolidating 
so there are N-1 services to manage. So Heptapod/GitLab on paper is 
probably the best solution here.


What I don't think I like about Heptapod/GitLab is that the stacked 
review experience wasn't that great the last time I looked. Mercurial 
has (correctly IMO) established a strong opinion around the use of 
microcommits and actively encourages review units to be as small as 
possible to help drive down the defect rate. And last time I looked, 
GitLab really emphasized the merge diff and makes it a lot harder to 
review individual commits. Is this something that has improved with 
GitLab recently or has been improved with Heptapod? Can you show an 
example of a stack-based review on Heptapod?


Yes, there's been improvement on that front in GitLab. I'm not sure when 
your last experience was, so let me summarize the features as of today:


- from a Merge Request (MR), one can go to the "Commits" tab to review 
them individually. On a given commit, there are Prev/Next buttons when 
appropriate.


- Comments left on individual commits are displayed on the MR overview, 
like any comment, and have to be resolved. There are niceties like "Jump 
to next unresolved thread" and the like.


- Comments can be posted immediately or "added to the review" (kept as 
drafts) and sent together once the review is done (quite similar to 
Phabricator I believe)


- If a new version of the MR is pushed, thus making a commit obsolete, 
its comments are still visible, with an indication that it was made on a 
previous version. There isn't yet a tracking of the successor (I bet it 
would be problematic with Git).


- In the "Changes" tab, you can review the whole diff (as you say), and 
also compare subsequent versions of the MR. This is in my opinion 
something that is lacking in Phabricator. I like for instance to review 
patches individually, and do a last sweep of the whole diff after 
corrections have been made, right before I hit the merge button.


As far as I remember, Heptapod has no specific code about the review 
process. There is a significant chunk of specific code related to Merge 
Requests, but that is for merge detection: properly ending the MR as 
"merged" if a push did merge or publish the changes.


There is still room for improvement :

- comments on commits are tied to lines of code, so one has to comment 
the first line or the last one for stuff relevant to a whole commit 
(including the message). This is annoying, but not a blocker in my book. 
It's probable that an improvement on this will be merged upstream sooner 
or later (there is IIRC at least one attempt). Perhaps we'll end up 
helping with that.


- as mentioned above, tracking of successor to show a comment in the 
context of the successor in case that's useful, or simply to show the 
diff between obsolete changeset and successor is not implemented (we 
could have something specific to Mercurial, here)


There are some after-the-fact examples of the process in existing 
projects, such as https://foss.heptapod.net/heptapod/hgitaly or 
https://foss.heptapod.net/mercurial/hg-git. I would have to check to 
give you precise examples.




There is another concern around how much the Mercurial Project should 
rely on 3rd party infrastructure not hosted by major cloud providers. 
You definitely have peace of mind when there is a formal contract or 
SLA in place. I'm not saying we couldn't get that from 
foss.heptapod.net  - just that it is a 
discussion that needs to take place.


On the general principle, this makes sense. In practice, we (Octobus) 
are in permanent contact with our partner hosting company (Clever Cloud) 
and we do fix things together pretty quickly. The latest example was the 
hotfix that came with GitLab 14.6.5 a few days ago.


If I'm not mistaken, a major cloud provider would provide us with 
working systems or containers, and managed DB servers, but we'd still 
have to care about the application itself. That means proper monitoring, 
backups, applying upgrades in a timely manner, and people on alert. This 
is the work that Clever Cloud is 

mercurial@48802: 26 new changesets (6 on stable)

[Mercurial Commits]

26 new changesets (6 on stable) in mercurial:

https://www.mercurial-scm.org/repo/hg/rev/eb9c55453249
changeset:   48777:eb9c55453249
parent:  48773:6cfa30681a1d
user:Augie Fackler 
date:Tue Feb 15 13:32:11 2022 -0500
summary: narrowspec: add timing block for validating narrowspec

https://www.mercurial-scm.org/repo/hg/rev/c4149a110b5f
changeset:   48778:c4149a110b5f
user:Augie Fackler 
date:Tue Feb 15 13:32:30 2022 -0500
summary: sparse: add timing block for parsing sparse configs

https://www.mercurial-scm.org/repo/hg/rev/17eaeb06562c
changeset:   48779:17eaeb06562c
user:Pierre-Yves David 
date:Tue Feb 15 23:09:07 2022 +0100
summary: upgrade: prepare code (and output) for the idea of upgrading share

https://www.mercurial-scm.org/repo/hg/rev/6e77083683a7
changeset:   48780:6e77083683a7
user:Pierre-Yves David 
date:Tue Feb 15 23:45:30 2022 +0100
summary: upgrade: make dirstate-v2 format variant compatible with share

https://www.mercurial-scm.org/repo/hg/rev/8dd5853eaa04
changeset:   48781:8dd5853eaa04
user:Martin von Zweigbergk 
date:Tue Feb 15 20:18:57 2022 -0800
summary: filemerge: remove unused `repo` argument from `_maketempfiles()`

https://www.mercurial-scm.org/repo/hg/rev/c7dbfc363655
changeset:   48782:c7dbfc363655
user:Martin von Zweigbergk 
date:Fri Feb 11 21:39:55 2022 -0800
summary: filemerge: when using in-memory merge, always put backup files in 
temp dir

https://www.mercurial-scm.org/repo/hg/rev/218154867575
changeset:   48783:218154867575
user:Martin von Zweigbergk 
date:Fri Feb 11 22:39:53 2022 -0800
summary: filemerge: remove an unnecessary join with absolute path

https://www.mercurial-scm.org/repo/hg/rev/9d0d0a388c39
changeset:   48784:9d0d0a388c39
user:Martin von Zweigbergk 
date:Mon Feb 14 21:52:18 2022 -0800
summary: filemerge: remove `uselocalpath` argument from `_maketempfiles()`

https://www.mercurial-scm.org/repo/hg/rev/b53f2f5a18de
changeset:   48785:b53f2f5a18de
user:Martin von Zweigbergk 
date:Mon Feb 14 22:04:50 2022 -0800
summary: filemerge: move removal of `.orig` extension on temp file close to 
context

https://www.mercurial-scm.org/repo/hg/rev/f20feb496d3c
changeset:   48786:f20feb496d3c
user:Martin von Zweigbergk 
date:Mon Feb 14 22:11:50 2022 -0800
summary: filemerge: use leverage `util.readfile()` in `_maketempfiles()`

https://www.mercurial-scm.org/repo/hg/rev/69000dc0dced
changeset:   48787:69000dc0dced
user:Martin von Zweigbergk 
date:Mon Feb 14 22:16:29 2022 -0800
summary: filemerge: reduce some duplication in `_maketempfiles()`

https://www.mercurial-scm.org/repo/hg/rev/f90337706ce7
changeset:   48788:f90337706ce7
user:Martin von Zweigbergk 
date:Mon Feb 14 22:49:03 2022 -0800
summary: filemerge: make `_maketempfiles()` more reusable

https://www.mercurial-scm.org/repo/hg/rev/ef50a62eec40
changeset:   48789:ef50a62eec40
user:Anton Shestakov 
date:Mon Jan 31 18:13:00 2022 +0300
summary: obsolete: don't use os.stat in repo.obsstore.__nonzero__ if it's 
static HTTP

https://www.mercurial-scm.org/repo/hg/rev/5ba24e886cec
changeset:   48790:5ba24e886cec
user:Pierre-Yves David 
date:Thu Feb 17 06:32:03 2022 +0100
summary: tracked-key: make it possible to upgrade to and downgrade from the 
feature

https://www.mercurial-scm.org/repo/hg/rev/1af95465961a
changeset:   48791:1af95465961a
user:Pierre-Yves David 
date:Thu Feb 17 06:35:42 2022 +0100
summary: tracked-key: update the requirement value

https://www.mercurial-scm.org/repo/hg/rev/8bbb1abb9d19
changeset:   48792:8bbb1abb9d19
user:Pierre-Yves David 
date:Thu Feb 17 06:41:54 2022 +0100
summary: tracked-file: rename the format option to use `use-`

https://www.mercurial-scm.org/repo/hg/rev/6e559391f96e
changeset:   48793:6e559391f96e
user:Pierre-Yves David 
date:Thu Feb 17 07:34:49 2022 +0100
summary: tracked-key: remove the dual write and rename to tracked-hint

https://www.mercurial-scm.org/repo/hg/rev/834c938227c6
changeset:   48794:834c938227c6
parent:  48793:6e559391f96e
parent:  48774:dcec16e799dd
user:Raphaël Gomès 
date:Fri Feb 18 11:37:08 2022 +0100
summary: branching: merge stable into default

https://www.mercurial-scm.org/repo/hg/rev/61c27ac5a1c5
changeset:   48795:61c27ac5a1c5
parent:  48794:834c938227c6
parent:  48776:b84ff512b645
user:Raphaël Gomès 
date:Fri Feb 18 12:58:44 2022 +0100
summary: branching: merge 6.0.3 stable into default

https://www.mercurial-scm.org/repo/hg/rev/c00d3ce4e94b
changeset:   48796:c00d3ce4e94b
branch:  stable
tag: 6.1rc0
parent:  48776:b84ff512b645
parent:  48795:61c27ac5a1c5
user:Raphaël Gomès 
date:Fri Feb 18 14:27:43 2022 +0100
summary: 

[Bug 6653] New: How to connect to eBay customer service?

[mercurial-bugs]

https://bz.mercurial-scm.org/show_bug.cgi?id=6653

Bug ID: 6653
   Summary: How to connect to eBay customer service?
   Product: Mercurial
   Version: default branch
  Hardware: PC
OS: Windows
Status: UNCONFIRMED
  Severity: feature
  Priority: wish
 Component: bookmarks
  Assignee: bugzi...@mercurial-scm.org
  Reporter: kinwatts...@gmail.com
CC: mercurial-devel@mercurial-scm.org
Python Version: ---

The technical errors with the online platform are the usual aspect. You might
have seen that people are using eBay these days to shop online. But what if any
of the issues arise unexpectedly with the eCommerce platform? In that
condition, they will require taking help of eBay customer service to go ahead.
It will help them to get rid of the issues instantly.
https://www.primotechy.com/ebay-customer-service-phone-number/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel