Re: [PATCH] color: show mode warning based on ui.formatted

2016-11-11 Thread Yuya Nishihara 
On Thu, 10 Nov 2016 20:36:25 -0800, Sean Farley wrote:
> Xidorn Quan  writes:
> > # HG changeset patch
> > # User Xidorn Quan 
> > # Date 1478829965 -39600
> > #  Fri Nov 11 13:06:05 2016 +1100
> > # Node ID 1ffdeb65f19e74ea211af4d9f7c9c4c1dfaa7069
> > # Parent  e1d6aa0e4c3aed73e0dc523b8a8fd5f9fe23510a
> > color: show mode warning based on ui.formatted

LGTM, too. Queued, thanks.

> Today I learned that ui.interactive is only for input and ui.formatted
> is for ouput:
> 
> "This [interactive] function refers to input only; for output, see
> `ui.formatted()'."
> 
> The patch looks good to me (maybe add some explanation to the commit
> message but that shouldn't require a resend).

Copy-edited the commit message to include "ui.interactive is only for input..."
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] color: show mode warning based on ui.formatted

2016-11-10 Thread Sean Farley 
Xidorn Quan  writes:

> # HG changeset patch
> # User Xidorn Quan 
> # Date 1478829965 -39600
> #  Fri Nov 11 13:06:05 2016 +1100
> # Node ID 1ffdeb65f19e74ea211af4d9f7c9c4c1dfaa7069
> # Parent  e1d6aa0e4c3aed73e0dc523b8a8fd5f9fe23510a
> color: show mode warning based on ui.formatted
>
> diff --git a/hgext/color.py b/hgext/color.py
> --- a/hgext/color.py
> +++ b/hgext/color.py
> @@ -270,18 +270,18 @@ def _modesetup(ui, coloropt):
>  realmode = 'ansi'
>  else:
>  realmode = 'win32'
>  else:
>  realmode = 'ansi'
>  
>  def modewarn():
>  # only warn if color.mode was explicitly set and we're in
> -# an interactive terminal
> -if mode == realmode and ui.interactive():
> +# a formatted terminal
> +if mode == realmode and ui.formatted():

Today I learned that ui.interactive is only for input and ui.formatted
is for ouput:

"This [interactive] function refers to input only; for output, see
`ui.formatted()'."

The patch looks good to me (maybe add some explanation to the commit
message but that shouldn't require a resend).
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel