Re: [PATCH] obsolete: don't translate internal error message

2018-10-13 Thread Augie Fackler 


> On Oct 12, 2018, at 17:08, Yuya Nishihara  wrote:
> 
> # HG changeset patch
> # User Yuya Nishihara 
> # Date 1539355871 -7200
> #  Fri Oct 12 16:51:11 2018 +0200
> # Node ID 21a0028bb28eeb4c3d2af807934fd22382594ce2
> # Parent  5b8bab9a7e07692e8d827c5315502301a11e4803
> obsolete: don't translate internal error message

queued, thanks

___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH] obsolete: don't translate internal error message

2018-10-12 Thread Yuya Nishihara 
# HG changeset patch
# User Yuya Nishihara 
# Date 1539355871 -7200
#  Fri Oct 12 16:51:11 2018 +0200
# Node ID 21a0028bb28eeb4c3d2af807934fd22382594ce2
# Parent  5b8bab9a7e07692e8d827c5315502301a11e4803
obsolete: don't translate internal error message

AFAIK, it's caught only by "hg debugobsolete", so it's pretty much a
programming error.

diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
--- a/mercurial/obsolete.py
+++ b/mercurial/obsolete.py
@@ -600,7 +600,7 @@ class obsstore(object):
 raise ValueError(succ)
 if prec in succs:
 raise ValueError(
-pycompat.sysstr(_('in-marker cycle with %s') % node.hex(prec)))
+r'in-marker cycle with %s' % pycompat.sysstr(node.hex(prec)))
 
 metadata = tuple(sorted(metadata.iteritems()))
 for k, v in metadata:
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel