Re: [PATCH] util: document we want Python type mapping to be temporary
On Sat, 08 Oct 2016 19:16:54 +0200, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1475947010 -7200 > # Sat Oct 08 19:16:50 2016 +0200 > # Node ID d15d8ac73cfd2d1ddbd443262ccad9c68ee69406 > # Parent 266ad9c9faa524a8b3f473c924db409681cb205e > util: document we want Python type mapping to be temporary Queued this, too. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] util: document we want Python type mapping to be temporary
It should be PATCH 3 of the [PATCH 1 of 2] parsers: return NULL from PyInit_parsers on Python 3 Note: hgpatch.lihdd.net supports getting a branch across email threads, based on "Parent" information: http://hgpatch.lihdd.net/d15d8ac73cfd2d1ddbd443262ccad9c68ee69406/branch Excerpts from Pierre-Yves David's message of 2016-10-08 23:38:46 +0200: > > On 10/08/2016 07:16 PM, Gregory Szorc wrote: > > # HG changeset patch > > # User Gregory Szorc > > # Date 1475947010 -7200 > > # Sat Oct 08 19:16:50 2016 +0200 > > # Node ID d15d8ac73cfd2d1ddbd443262ccad9c68ee69406 > > # Parent 266ad9c9faa524a8b3f473c924db409681cb205e > > util: document we want Python type mapping to be temporary > > > > I think remapping Python C API types and functions is not a great > > approach. I'd prefer this whole #ifdef disappeared. Add a comment > > so we don't forget about it. > > I cannot find anywhere to apply this. This code does not seems to exists > in our current public repository. Am I missing something? > ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] util: document we want Python type mapping to be temporary
On 10/08/2016 07:16 PM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1475947010 -7200 # Sat Oct 08 19:16:50 2016 +0200 # Node ID d15d8ac73cfd2d1ddbd443262ccad9c68ee69406 # Parent 266ad9c9faa524a8b3f473c924db409681cb205e util: document we want Python type mapping to be temporary I think remapping Python C API types and functions is not a great approach. I'd prefer this whole #ifdef disappeared. Add a comment so we don't forget about it. I cannot find anywhere to apply this. This code does not seems to exists in our current public repository. Am I missing something? -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH] util: document we want Python type mapping to be temporary
These look good to me. (Including related patches: util: define PyInt_Type on Python 3 parsers: return NULL from PyInit_parsers on Python 3) I think we can always iterate on Python 3 later. Excerpts from Gregory Szorc's message of 2016-10-08 19:16:54 +0200: > # HG changeset patch > # User Gregory Szorc > # Date 1475947010 -7200 > # Sat Oct 08 19:16:50 2016 +0200 > # Node ID d15d8ac73cfd2d1ddbd443262ccad9c68ee69406 > # Parent 266ad9c9faa524a8b3f473c924db409681cb205e > util: document we want Python type mapping to be temporary > > I think remapping Python C API types and functions is not a great > approach. I'd prefer this whole #ifdef disappeared. Add a comment > so we don't forget about it. > > diff --git a/mercurial/util.h b/mercurial/util.h > --- a/mercurial/util.h > +++ b/mercurial/util.h > @@ -12,8 +12,11 @@ > > #if PY_MAJOR_VERSION >= 3 > > #define IS_PY3K > +/* The mapping of Python types is meant to be temporary to get Python > + * 3 to compile. We should remove this once Python 3 support is fully > + * supported and proper types are used in the extensions themselves. */ > #define PyInt_Type PyLong_Type > #define PyInt_FromLong PyLong_FromLong > #define PyInt_AsLong PyLong_AsLong > ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
[PATCH] util: document we want Python type mapping to be temporary
# HG changeset patch # User Gregory Szorc # Date 1475947010 -7200 # Sat Oct 08 19:16:50 2016 +0200 # Node ID d15d8ac73cfd2d1ddbd443262ccad9c68ee69406 # Parent 266ad9c9faa524a8b3f473c924db409681cb205e util: document we want Python type mapping to be temporary I think remapping Python C API types and functions is not a great approach. I'd prefer this whole #ifdef disappeared. Add a comment so we don't forget about it. diff --git a/mercurial/util.h b/mercurial/util.h --- a/mercurial/util.h +++ b/mercurial/util.h @@ -12,8 +12,11 @@ #if PY_MAJOR_VERSION >= 3 #define IS_PY3K +/* The mapping of Python types is meant to be temporary to get Python + * 3 to compile. We should remove this once Python 3 support is fully + * supported and proper types are used in the extensions themselves. */ #define PyInt_Type PyLong_Type #define PyInt_FromLong PyLong_FromLong #define PyInt_AsLong PyLong_AsLong ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
