Re: [PATCH 03 of 12 topics] flake8: fix E127 style

[Pierre-Yves David]

On 08/31/2016 02:56 PM, Augie Fackler wrote:

On Tue, Aug 30, 2016 at 08:58:09PM -0700, Sean Farley wrote:

# HG changeset patch
# User Sean Farley 
# Date 1472591416 25200
#  Tue Aug 30 14:10:16 2016 -0700
# Node ID a6f4b32f655ba895875640534b051c5ebe632695
# Parent  78dd9f1db1b1cf5a869e1240bb4ed523e930c907
# EXP-Topic flake8
flake8: fix E127 style


I might suggest describing what e127 is in the log message? This kind
of buries the lede in terms of actual content changes IMO.


+1, I'll take patch anyway when the rules is obvious but that would have 
helped.


Cheers,

--
Pierre-Yves David
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 03 of 12 topics] flake8: fix E127 style

[Augie Fackler]

On Tue, Aug 30, 2016 at 08:58:09PM -0700, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley 
> # Date 1472591416 25200
> #  Tue Aug 30 14:10:16 2016 -0700
> # Node ID a6f4b32f655ba895875640534b051c5ebe632695
> # Parent  78dd9f1db1b1cf5a869e1240bb4ed523e930c907
> # EXP-Topic flake8
> flake8: fix E127 style

I might suggest describing what e127 is in the log message? This kind
of buries the lede in terms of actual content changes IMO.

>
> diff --git a/hgext3rd/topic/topicmap.py b/hgext3rd/topic/topicmap.py
> --- a/hgext3rd/topic/topicmap.py
> +++ b/hgext3rd/topic/topicmap.py
> @@ -125,11 +125,11 @@ class topiccache(oldbranchcache):
>  if (self.tipnode == repo.changelog.node(self.tiprev)):
>  fh = scmutil.filteredhash(repo, self.tiprev)
>  if fh is None:
>  fh = nullid
>  if ((self.filteredhash == fh)
> - and (self.phaseshash == _phaseshash(repo, 
> self.tiprev))):
> +and (self.phaseshash == _phaseshash(repo, self.tiprev))):
>  return True
>  return False
>  except IndexError:
>  return False
>
> diff --git a/setup.cfg b/setup.cfg
> --- a/setup.cfg
> +++ b/setup.cfg
> @@ -1,2 +1,2 @@
>  [flake8]
> -ignore = E261, E266, E302, E129, E731, E124, E713, E301, E501, E111, E123, 
> E222, W503, W391, E127
> +ignore = E261, E266, E302, E129, E731, E124, E713, E301, E501, E111, E123, 
> E222, W503, W391
> ___
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 03 of 12 topics] flake8: fix E127 style

[Sean Farley]

# HG changeset patch
# User Sean Farley 
# Date 1472591416 25200
#  Tue Aug 30 14:10:16 2016 -0700
# Node ID a6f4b32f655ba895875640534b051c5ebe632695
# Parent  78dd9f1db1b1cf5a869e1240bb4ed523e930c907
# EXP-Topic flake8
flake8: fix E127 style

diff --git a/hgext3rd/topic/topicmap.py b/hgext3rd/topic/topicmap.py
--- a/hgext3rd/topic/topicmap.py
+++ b/hgext3rd/topic/topicmap.py
@@ -125,11 +125,11 @@ class topiccache(oldbranchcache):
 if (self.tipnode == repo.changelog.node(self.tiprev)):
 fh = scmutil.filteredhash(repo, self.tiprev)
 if fh is None:
 fh = nullid
 if ((self.filteredhash == fh)
- and (self.phaseshash == _phaseshash(repo, self.tiprev))):
+and (self.phaseshash == _phaseshash(repo, self.tiprev))):
 return True
 return False
 except IndexError:
 return False
 
diff --git a/setup.cfg b/setup.cfg
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,2 +1,2 @@
 [flake8]
-ignore = E261, E266, E302, E129, E731, E124, E713, E301, E501, E111, E123, 
E222, W503, W391, E127
+ignore = E261, E266, E302, E129, E731, E124, E713, E301, E501, E111, E123, 
E222, W503, W391
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel