Re: [PATCH 9 of 9 pager v2] tests: prove that ignore works

2017-02-17 Thread Martin von Zweigbergk via Mercurial-devel 
On Thu, Feb 16, 2017 at 3:47 PM, Martin von Zweigbergk
 wrote:
> On Thu, Feb 16, 2017 at 9:25 AM, Simon Farnsworth  wrote:
>> I'm no longer seeing issues with these patches, and it'd be nice to reduce
>> the pile of extensions you need to enable to get a modern workflow out of
>> Hg.
>
> Besides the nits on patch 3/9, this is looking great to me too. Thanks!

Since those were just about style and I think you'll be out for a day
or a few, I've pushed the current iteration to "committed", but please
address the comments on patch 3/9 when you're back (explaining why the
comments make no sense is of course a valid way; patches may not even
be necessary). Thanks!

>
>>
>>
>> On 16/02/2017 16:59, Augie Fackler wrote:
>>>
>>> # HG changeset patch
>>> # User Augie Fackler 
>>> # Date 1486441324 18000
>>> #  Mon Feb 06 23:22:04 2017 -0500
>>> # Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
>>> # Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
>>> tests: prove that ignore works
>>>
>>> diff --git a/tests/test-pager.t b/tests/test-pager.t
>>> --- a/tests/test-pager.t
>>> +++ b/tests/test-pager.t
>>> @@ -204,3 +204,21 @@ explicit flags work too:
>>> 8: a 8
>>> 9: a 9
>>>10: a 10
>>> +
>>> +Put annotate in the ignore list for pager:
>>> +  $ cat >> $HGRCPATH <>> +  > [pager]
>>> +  > ignore = annotate
>>> +  > EOF
>>> +  $ hg blame a
>>> +   0: a
>>> +   1: a 1
>>> +   2: a 2
>>> +   3: a 3
>>> +   4: a 4
>>> +   5: a 5
>>> +   6: a 6
>>> +   7: a 7
>>> +   8: a 8
>>> +   9: a 9
>>> +  10: a 10
>>> ___
>>> Mercurial-devel mailing list
>>> Mercurial-devel@mercurial-scm.org
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8=
>>>
>>
>> --
>> Simon Farnsworth
>>
>> ___
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 9 of 9 pager v2] tests: prove that ignore works

2017-02-16 Thread Martin von Zweigbergk via Mercurial-devel 
On Thu, Feb 16, 2017 at 9:25 AM, Simon Farnsworth  wrote:
> I'm no longer seeing issues with these patches, and it'd be nice to reduce
> the pile of extensions you need to enable to get a modern workflow out of
> Hg.

Besides the nits on patch 3/9, this is looking great to me too. Thanks!

>
>
> On 16/02/2017 16:59, Augie Fackler wrote:
>>
>> # HG changeset patch
>> # User Augie Fackler 
>> # Date 1486441324 18000
>> #  Mon Feb 06 23:22:04 2017 -0500
>> # Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
>> # Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
>> tests: prove that ignore works
>>
>> diff --git a/tests/test-pager.t b/tests/test-pager.t
>> --- a/tests/test-pager.t
>> +++ b/tests/test-pager.t
>> @@ -204,3 +204,21 @@ explicit flags work too:
>> 8: a 8
>> 9: a 9
>>10: a 10
>> +
>> +Put annotate in the ignore list for pager:
>> +  $ cat >> $HGRCPATH <> +  > [pager]
>> +  > ignore = annotate
>> +  > EOF
>> +  $ hg blame a
>> +   0: a
>> +   1: a 1
>> +   2: a 2
>> +   3: a 3
>> +   4: a 4
>> +   5: a 5
>> +   6: a 6
>> +   7: a 7
>> +   8: a 8
>> +   9: a 9
>> +  10: a 10
>> ___
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8=
>>
>
> --
> Simon Farnsworth
>
> ___
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 9 of 9 pager v2] tests: prove that ignore works

2017-02-16 Thread Simon Farnsworth 
I'm no longer seeing issues with these patches, and it'd be nice to 
reduce the pile of extensions you need to enable to get a modern 
workflow out of Hg.


On 16/02/2017 16:59, Augie Fackler wrote:

# HG changeset patch
# User Augie Fackler 
# Date 1486441324 18000
#  Mon Feb 06 23:22:04 2017 -0500
# Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
# Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
tests: prove that ignore works

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -204,3 +204,21 @@ explicit flags work too:
8: a 8
9: a 9
   10: a 10
+
+Put annotate in the ignore list for pager:
+  $ cat >> $HGRCPATH < [pager]
+  > ignore = annotate
+  > EOF
+  $ hg blame a
+   0: a
+   1: a 1
+   2: a 2
+   3: a 3
+   4: a 4
+   5: a 5
+   6: a 6
+   7: a 7
+   8: a 8
+   9: a 9
+  10: a 10
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8=



--
Simon Farnsworth
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 9 of 9 pager v2] tests: prove that ignore works

2017-02-16 Thread Augie Fackler 
# HG changeset patch
# User Augie Fackler 
# Date 1486441324 18000
#  Mon Feb 06 23:22:04 2017 -0500
# Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
# Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
tests: prove that ignore works

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -204,3 +204,21 @@ explicit flags work too:
8: a 8
9: a 9
   10: a 10
+
+Put annotate in the ignore list for pager:
+  $ cat >> $HGRCPATH < [pager]
+  > ignore = annotate
+  > EOF
+  $ hg blame a
+   0: a
+   1: a 1
+   2: a 2
+   3: a 3
+   4: a 4
+   5: a 5
+   6: a 6
+   7: a 7
+   8: a 8
+   9: a 9
+  10: a 10
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel