Re: [PATCH V2] test-patchbomb: disable sendmail tests on Windows

2017-04-11 Thread Yuya Nishihara
On Tue, 11 Apr 2017 09:46:18 +, Kostia Balytskyi wrote:
> This looks good to me. Yay for Windows work.
> 
> > -Original Message-
> > From: Mercurial-devel [mailto:mercurial-devel-boun...@mercurial-scm.org]
> > On Behalf Of Matt Harbison
> > Sent: Tuesday, 11 April, 2017 02:20
> > To: mercurial-devel@mercurial-scm.org
> > Subject: [PATCH V2] test-patchbomb: disable sendmail tests on Windows
> > 
> > # HG changeset patch
> > # User Matt Harbison <matt_harbi...@yahoo.com> # Date 1491873174
> > 14400
> > #  Mon Apr 10 21:12:54 2017 -0400
> > # Node ID bfa323bbeebb534f3540e9198648f1bd317b059a
> > # Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0
> > test-patchbomb: disable sendmail tests on Windows

Queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


RE: [PATCH V2] test-patchbomb: disable sendmail tests on Windows

2017-04-11 Thread Kostia Balytskyi
This looks good to me. Yay for Windows work.

> -Original Message-
> From: Mercurial-devel [mailto:mercurial-devel-boun...@mercurial-scm.org]
> On Behalf Of Matt Harbison
> Sent: Tuesday, 11 April, 2017 02:20
> To: mercurial-devel@mercurial-scm.org
> Subject: [PATCH V2] test-patchbomb: disable sendmail tests on Windows
> 
> # HG changeset patch
> # User Matt Harbison <matt_harbi...@yahoo.com> # Date 1491873174
> 14400
> #  Mon Apr 10 21:12:54 2017 -0400
> # Node ID bfa323bbeebb534f3540e9198648f1bd317b059a
> # Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0
> test-patchbomb: disable sendmail tests on Windows
> 
> These tests were failing, and there isn't a trivial way to execute a script on
> Windows [1].
> 
> [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-
> 2Dscm.org_pipermail_mercurial-2Ddevel_2017-
> 2DApril_096497.html=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=Pp-
> gQYFgs4tKlSFPF5kfCw=MoB7XlhA2TGKLQ2ITzZ14aL8bHY2vW_bl_phlFSKn
> HU=HGhzSkDpZvQt5Ip1fSXI5vCi3wnybW2CX3jisv7G4OI=
> 
> diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t
> --- a/tests/test-patchbomb.t
> +++ b/tests/test-patchbomb.t
> @@ -2846,6 +2846,7 @@
>@@ -0,0 +1,1 @@
>+d
> 
> +#if no-windows
> 
>  Set up a fake sendmail program
> 
> @@ -3026,3 +3027,4 @@
>(use 'hg push $TESTTMP/t3 -r ff2c9fa2018b -r 3b6f1ec9dde9')
>[255]
> 
> +#endif
> ___
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-
> 2Dscm.org_mailman_listinfo_mercurial-
> 2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=Pp-
> gQYFgs4tKlSFPF5kfCw=MoB7XlhA2TGKLQ2ITzZ14aL8bHY2vW_bl_phlFSKn
> HU=yxaXSItbhL9M5WeGZ740IOVf-kW0ixZ0F1OK9rJwRS0=
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


[PATCH V2] test-patchbomb: disable sendmail tests on Windows

2017-04-10 Thread Matt Harbison
# HG changeset patch
# User Matt Harbison 
# Date 1491873174 14400
#  Mon Apr 10 21:12:54 2017 -0400
# Node ID bfa323bbeebb534f3540e9198648f1bd317b059a
# Parent  08fbc97d1364b08b53d538efc33b3ed41cea51a0
test-patchbomb: disable sendmail tests on Windows

These tests were failing, and there isn't a trivial way to execute a script on
Windows [1].

[1] 
https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096497.html

diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t
--- a/tests/test-patchbomb.t
+++ b/tests/test-patchbomb.t
@@ -2846,6 +2846,7 @@
   @@ -0,0 +1,1 @@
   +d
   
+#if no-windows
 
 Set up a fake sendmail program
 
@@ -3026,3 +3027,4 @@
   (use 'hg push $TESTTMP/t3 -r ff2c9fa2018b -r 3b6f1ec9dde9')
   [255]
 
+#endif
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel