D1081: tests: add check in test-check-commit.t to verify releasenotes directives
pulkit requested changes to this revision. pulkit added a comment. I have tweaked releasenotes to not error out in this case, rather show a warning only. So this patch is no longer applicable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1081 To: durin42, #hg-reviewers, indygreg, yuja, pulkit Cc: pulkit, yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1081: tests: add check in test-check-commit.t to verify releasenotes directives
durin42 added a comment. In https://phab.mercurial-scm.org/D1081#18135, @yuja wrote: > It makes a file named "notes" in the repository because of cd $TESTDIR/... > Perhaps we should send the output to > /dev/null. D'oh. Fixed in the revised version. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1081 To: durin42, #hg-reviewers, indygreg, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1081: tests: add check in test-check-commit.t to verify releasenotes directives
durin42 updated this revision to Diff 2762.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1081?vs=2747=2762
REVISION DETAIL
https://phab.mercurial-scm.org/D1081
AFFECTED FILES
tests/test-check-commit.t
CHANGE DETAILS
diff --git a/tests/test-check-commit.t b/tests/test-check-commit.t
--- a/tests/test-check-commit.t
+++ b/tests/test-check-commit.t
@@ -17,6 +17,11 @@
>cat ${TESTTMP}/check-commit.out
>echo
> fi
+ > testrepohg --config extensions.releasenotes= releasenotes -r $node \
+ > "${TESTTMP}/notes"
+ > if [ $? -ne 0 ] ; then
+ >echo "Revision $node has broken releasenotes declaration"
+ > fi
> done
To: durin42, #hg-reviewers, indygreg, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1081: tests: add check in test-check-commit.t to verify releasenotes directives
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. It makes a file named "notes" in the repository because of cd $TESTDIR/... Perhaps we should send the output to > /dev/null. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1081 To: durin42, #hg-reviewers, indygreg, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D1081: tests: add check in test-check-commit.t to verify releasenotes directives
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I had some trouble getting this right in a recent change of mine, and
also found that some of our commits since 4.3 don't work right, so
let's bounce commits that get it wrong.
TEST PLAN
made a commit with broken releasenotes directives, verified I
got some failure output from test-check-commit.t. It's not the
prettiest, but it'll do for now.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1081
AFFECTED FILES
tests/test-check-commit.t
CHANGE DETAILS
diff --git a/tests/test-check-commit.t b/tests/test-check-commit.t
--- a/tests/test-check-commit.t
+++ b/tests/test-check-commit.t
@@ -17,6 +17,10 @@
>cat ${TESTTMP}/check-commit.out
>echo
> fi
+ > testrepohg --config extensions.releasenotes= releasenotes -r $node notes
+ > if [ $? -ne 0 ] ; then
+ >echo "Revision $node has broken releasenotes declaration"
+ > fi
> done
To: durin42, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
