D1104: peer: ensure command names are always ascii bytestrs

2017-10-16 Thread durin42 (Augie Fackler) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG115efdd97088: peer: ensure command names are always ascii 
bytestrs (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1104?vs=2796=2806

REVISION DETAIL
  https://phab.mercurial-scm.org/D1104

AFFECTED FILES
  mercurial/peer.py

CHANGE DETAILS

diff --git a/mercurial/peer.py b/mercurial/peer.py
--- a/mercurial/peer.py
+++ b/mercurial/peer.py
@@ -10,6 +10,7 @@
 
 from . import (
 error,
+pycompat,
 util,
 )
 
@@ -92,7 +93,8 @@
 if not encresref:
 return encargsorres # a local result in this case
 self = args[0]
-encresref.set(self._submitone(f.__name__, encargsorres))
+cmd = pycompat.bytesurl(f.__name__)  # ensure cmd is ascii bytestr
+encresref.set(self._submitone(cmd, encargsorres))
 return next(batchable)
 setattr(plain, 'batchable', f)
 return plain



To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1104: peer: ensure command names are always ascii bytestrs

2017-10-16 Thread ryanmce (Ryan McElroy) 
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.


  queued

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1104

To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1104: peer: ensure command names are always ascii bytestrs

2017-10-15 Thread durin42 (Augie Fackler) 
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1104

AFFECTED FILES
  mercurial/peer.py

CHANGE DETAILS

diff --git a/mercurial/peer.py b/mercurial/peer.py
--- a/mercurial/peer.py
+++ b/mercurial/peer.py
@@ -10,6 +10,7 @@
 
 from . import (
 error,
+pycompat,
 util,
 )
 
@@ -92,7 +93,8 @@
 if not encresref:
 return encargsorres # a local result in this case
 self = args[0]
-encresref.set(self._submitone(f.__name__, encargsorres))
+cmd = pycompat.bytesurl(f.__name__)  # ensure cmd is ascii bytestr
+encresref.set(self._submitone(cmd, encargsorres))
 return next(batchable)
 setattr(plain, 'batchable', f)
 return plain



To: durin42, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel