D2048: utils: copy util.py as utils/dateutil.py
durin42 added a comment. In https://phab.mercurial-scm.org/D2048#37691, @lothiraldan wrote: > I've resent the series as https://phab.mercurial-scm.org/D2282 as a single changeset. I've included a note for extension authors with a link to the old series to more easily bisect the changeset breaking their extension. > > Do you think it would be hard to update `blame` to work in the current case? I think it's probably a significant amount of work to record sub-file-level copy information. It'd be of value, but I'm deeply skeptical it's worth the amount of time it'd take. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2048: utils: copy util.py as utils/dateutil.py
lothiraldan added a comment. I've resent the series as https://phab.mercurial-scm.org/D2282 as a single changeset. I've included a note for extension authors with a link to the old series to more easily bisect the changeset breaking their extension. Do you think it would be hard to update `blame` to work in the current case? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2048: utils: copy util.py as utils/dateutil.py
durin42 added a comment. In https://phab.mercurial-scm.org/D2048#34978, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D2048#34743, @durin42 wrote: > > > Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on everything done in https://phab.mercurial-scm.org/D2049::D0256... > > > Moving function one by one proved very useful in the past when refactoring like this triggered subtle bugs in core or extension. Having each move on its changeset make it easier to bisect the part that breaks other and save a great amount of time when that happens. Life's tough. I care more about the blame history on this code. (Other reviewers are welcome to overrule me, but I don't find this argument even slightly convincing.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2048: utils: copy util.py as utils/dateutil.py
lothiraldan added a comment. In https://phab.mercurial-scm.org/D2048#34743, @durin42 wrote: > Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on everything done in https://phab.mercurial-scm.org/D2049::D0256... Moving function one by one proved very useful in the past when refactoring like this triggered subtle bugs in core or extension. Having each move on its changeset make it easier to bisect the part that breaks other and save a great amount of time when that happens. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2048: utils: copy util.py as utils/dateutil.py
durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on everything done in https://phab.mercurial-scm.org/D2049::D0256... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2048 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
