D2607: hghave: fix up clang-libfuzzer regex to be bytes

2018-03-03 Thread durin42 (Augie Fackler) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdc11f257ad1d: hghave: fix up clang-libfuzzer regex to be 
bytes (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2607?vs=6482=6493

REVISION DETAIL
  https://phab.mercurial-scm.org/D2607

AFFECTED FILES
  tests/hghave.py

CHANGE DETAILS

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -703,7 +703,7 @@
 
 @check("clang-libfuzzer", "clang new enough to include libfuzzer")
 def has_clang_libfuzzer():
-mat = matchoutput('clang --version', 'clang version (\d)')
+mat = matchoutput('clang --version', b'clang version (\d)')
 if mat:
 # libfuzzer is new in clang 6
 return int(mat.group(1)) > 5



To: durin42, #hg-reviewers, indygreg
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D2607: hghave: fix up clang-libfuzzer regex to be bytes

2018-03-03 Thread pulkit (Pulkit Goyal) 
pulkit added inline comments.

INLINE COMMENTS

> hghave.py:265
>  return True
>  return matchoutput('hg --version --quiet 2>&1', 'Mercurial Distributed 
> SCM')
>  

Since you are here, can you get this one and next call to matchoutput fixed too?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2607

To: durin42, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D2607: hghave: fix up clang-libfuzzer regex to be bytes

2018-03-03 Thread durin42 (Augie Fackler) 
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Fixes this check on Python 3.
  
  1. skip-blame just a b prefix

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2607

AFFECTED FILES
  tests/hghave.py

CHANGE DETAILS

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -703,7 +703,7 @@
 
 @check("clang-libfuzzer", "clang new enough to include libfuzzer")
 def has_clang_libfuzzer():
-mat = matchoutput('clang --version', 'clang version (\d)')
+mat = matchoutput('clang --version', b'clang version (\d)')
 if mat:
 # libfuzzer is new in clang 6
 return int(mat.group(1)) > 5



To: durin42, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel