D3387: wireprotov2: remove support for sending bytes response
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5cdde6158426: wireprotov2: remove support for sending bytes response (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3387?vs=8299&id=8330 REVISION DETAIL https://phab.mercurial-scm.org/D3387 AFFECTED FILES mercurial/wireprotov2server.py CHANGE DETAILS diff --git a/mercurial/wireprotov2server.py b/mercurial/wireprotov2server.py --- a/mercurial/wireprotov2server.py +++ b/mercurial/wireprotov2server.py @@ -301,11 +301,7 @@ res.status = b'200 OK' res.headers[b'Content-Type'] = FRAMINGTYPE -if isinstance(rsp, wireprototypes.bytesresponse): -action, meta = reactor.oncommandresponseready(outstream, - command['requestid'], - rsp.data) -elif isinstance(rsp, wireprototypes.cborresponse): +if isinstance(rsp, wireprototypes.cborresponse): encoded = cbor.dumps(rsp.value, canonical=True) action, meta = reactor.oncommandresponseready(outstream, command['requestid'], To: indygreg, #hg-reviewers, durin42 Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3387: wireprotov2: remove support for sending bytes response
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We recently declared that all responses must be CBOR. So remove support for sending a type that isn't CBOR data. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3387 AFFECTED FILES mercurial/wireprotov2server.py CHANGE DETAILS diff --git a/mercurial/wireprotov2server.py b/mercurial/wireprotov2server.py --- a/mercurial/wireprotov2server.py +++ b/mercurial/wireprotov2server.py @@ -301,11 +301,7 @@ res.status = b'200 OK' res.headers[b'Content-Type'] = FRAMINGTYPE -if isinstance(rsp, wireprototypes.bytesresponse): -action, meta = reactor.oncommandresponseready(outstream, - command['requestid'], - rsp.data) -elif isinstance(rsp, wireprototypes.cborresponse): +if isinstance(rsp, wireprototypes.cborresponse): encoded = cbor.dumps(rsp.value, canonical=True) action, meta = reactor.oncommandresponseready(outstream, command['requestid'], To: indygreg, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
