D4097: narrow: remove a repo file-cache invalidation
This revision was automatically updated to reflect the committed changes. Closed by commit rHGae2962bb56a3: narrow: remove a repo file-cache invalidation (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4097?vs=9872=9932 REVISION DETAIL https://phab.mercurial-scm.org/D4097 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git a/mercurial/narrowspec.py b/mercurial/narrowspec.py --- a/mercurial/narrowspec.py +++ b/mercurial/narrowspec.py @@ -113,9 +113,6 @@ # Treat "narrowspec does not exist" the same as "narrowspec file exists # and is empty". if e.errno == errno.ENOENT: -# Without this the next call to load will use the cached -# non-existence of the file, which can cause some odd issues. -repo.invalidate(clearfilecache=True) return set(), set() raise # maybe we should care about the profiles returned too To: martinvonz, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D4097: narrow: remove a repo file-cache invalidation
martinvonz updated this revision to Diff 9872. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4097?vs=9859=9872 REVISION DETAIL https://phab.mercurial-scm.org/D4097 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git a/mercurial/narrowspec.py b/mercurial/narrowspec.py --- a/mercurial/narrowspec.py +++ b/mercurial/narrowspec.py @@ -113,9 +113,6 @@ # Treat "narrowspec does not exist" the same as "narrowspec file exists # and is empty". if e.errno == errno.ENOENT: -# Without this the next call to load will use the cached -# non-existence of the file, which can cause some odd issues. -repo.invalidate(clearfilecache=True) return set(), set() raise # maybe we should care about the profiles returned too To: martinvonz, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D4097: narrow: remove a repo file-cache invalidation
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's unclear why this was needed. All tests pass without it. I asked Kyle Lippincott (who added the check) and he also doesn't remember what it was for. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4097 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git a/mercurial/narrowspec.py b/mercurial/narrowspec.py --- a/mercurial/narrowspec.py +++ b/mercurial/narrowspec.py @@ -135,9 +135,6 @@ # Treat "narrowspec does not exist" the same as "narrowspec file exists # and is empty". if e.errno == errno.ENOENT: -# Without this the next call to load will use the cached -# non-existence of the file, which can cause some odd issues. -repo.invalidate(clearfilecache=True) return set(), set() raise return _parsestoredpatterns(spec) To: martinvonz, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
