D4144: changegroup: assign to proper attribute
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9134c4e46084: changegroup: assign to proper attribute (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4144?vs=10019=10030#toc REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4144?vs=10019=10030 REVISION DETAIL https://phab.mercurial-scm.org/D4144 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py --- a/mercurial/changegroup.py +++ b/mercurial/changegroup.py @@ -605,7 +605,7 @@ # Ellipses serving mode. self._clrevtolocalrev.clear() if self._nextclrevtolocalrev: -self.clrevtolocalrev = self._nextclrevtolocalrev +self._clrevtolocalrev = self._nextclrevtolocalrev self._nextclrevtolocalrev.clear() self._changelogdone = True To: indygreg, #hg-reviewers, martinvonz Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D4144: changegroup: assign to proper attribute
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG0548f696795b6f30c32f11620ddc274a112260d3 accidentally assigned to self.clrevtolocalrev instead of self._clrevtolocalrev. Surprisingly, no tests failed as a result of this mistake. Curious. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4144 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py --- a/mercurial/changegroup.py +++ b/mercurial/changegroup.py @@ -671,7 +671,7 @@ # Ellipses serving mode. self._clrevtolocalrev.clear() if self._nextclrevtolocalrev: -self.clrevtolocalrev = self._nextclrevtolocalrev +self._clrevtolocalrev = self._nextclrevtolocalrev self._nextclrevtolocalrev.clear() return closechunk() To: indygreg, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
