D5039: py3: add more py3 specific output to test
durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. In https://phab.mercurial-scm.org/D5039#75559, @yuja wrote: > > - a/tests/test-custom-filters.t +++ b/tests/test-custom-filters.t @@ -52,6 +52,7 @@ $ echo "Very very carefully." >> stuff.txt $ hg stat M stuff.txt + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) > > It's probably better to add `__pycache__` to .hgignore as we do for > `prefix.py[c]`. +1 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5039 To: pulkit, #hg-reviewers, durin42 Cc: durin42, yuja, mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5039: py3: add more py3 specific output to test
yuja added a comment. > - a/tests/test-custom-filters.t +++ b/tests/test-custom-filters.t @@ -52,6 +52,7 @@ $ echo "Very very carefully." >> stuff.txt $ hg stat M stuff.txt + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) It's probably better to add `__pycache__` to .hgignore as we do for `prefix.py[c]`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5039 To: pulkit, #hg-reviewers Cc: yuja, mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D5039: py3: add more py3 specific output to test
> --- a/tests/test-custom-filters.t > +++ b/tests/test-custom-filters.t > @@ -52,6 +52,7 @@ >$ echo "Very very carefully." >> stuff.txt >$ hg stat >M stuff.txt > + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) It's probably better to add `__pycache__` to .hgignore as we do for `prefix.py[c]`. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5039: py3: add more py3 specific output to test
pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Something changed with Python 3 just like million on things. Maybe they should named Python 3 as anaconda or cobra instead of just increasing the version number. This makes test-custom-filters.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5039 AFFECTED FILES contrib/python3-whitelist tests/test-custom-filters.t CHANGE DETAILS diff --git a/tests/test-custom-filters.t b/tests/test-custom-filters.t --- a/tests/test-custom-filters.t +++ b/tests/test-custom-filters.t @@ -52,6 +52,7 @@ $ echo "Very very carefully." >> stuff.txt $ hg stat M stuff.txt + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) $ echo "Unauthorized material subject to destruction." > morestuff.txt @@ -64,3 +65,4 @@ $ hg stat M stuff.txt A morestuff.txt + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist --- a/contrib/python3-whitelist +++ b/contrib/python3-whitelist @@ -105,6 +105,7 @@ test-copy-move-merge.t test-copy.t test-copytrace-heuristics.t +test-custom-filters.t test-debugbuilddag.t test-debugbundle.t test-debugcommands.t To: pulkit, #hg-reviewers Cc: mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
