D5174: py3: make sure we pass sysstr in sqlite3.connect()

[pulkit (Pulkit Goyal)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3b782669561d: py3: make sure we pass sysstr in 
sqlite3.connect() (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5174?vs=12293=12314

REVISION DETAIL
  https://phab.mercurial-scm.org/D5174

AFFECTED FILES
  hgext/sqlitestore.py

CHANGE DETAILS

diff --git a/hgext/sqlitestore.py b/hgext/sqlitestore.py
--- a/hgext/sqlitestore.py
+++ b/hgext/sqlitestore.py
@@ -63,6 +63,7 @@
 from mercurial import (
 ancestor,
 dagop,
+encoding,
 error,
 extensions,
 localrepo,
@@ -1020,7 +1021,7 @@
 def makedb(path):
 """Construct a database handle for a database at path."""
 
-db = sqlite3.connect(path)
+db = sqlite3.connect(encoding.strfromlocal(path))
 db.text_factory = bytes
 
 res = db.execute(r'PRAGMA user_version').fetchone()[0]



To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5174: py3: make sure we pass sysstr in sqlite3.connect()

[pulkit (Pulkit Goyal)]

pulkit updated this revision to Diff 12293.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5174?vs=12286=12293

REVISION DETAIL
  https://phab.mercurial-scm.org/D5174

AFFECTED FILES
  hgext/sqlitestore.py

CHANGE DETAILS

diff --git a/hgext/sqlitestore.py b/hgext/sqlitestore.py
--- a/hgext/sqlitestore.py
+++ b/hgext/sqlitestore.py
@@ -63,6 +63,7 @@
 from mercurial import (
 ancestor,
 dagop,
+encoding,
 error,
 extensions,
 localrepo,
@@ -973,7 +974,7 @@
 def makedb(path):
 """Construct a database handle for a database at path."""
 
-db = sqlite3.connect(path)
+db = sqlite3.connect(encoding.strfromlocal(path))
 db.text_factory = bytes
 
 res = db.execute(r'PRAGMA user_version').fetchone()[0]



To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5174: py3: make sure we pass sysstr in sqlite3.connect()

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   def makedb(path):
  >   """Construct a database handle for a database at path."""
  > 
  > 
  > - db = sqlite3.connect(path) +db = 
sqlite3.connect(pycompat.sysstr(path))
  
  Perhaps, `encoding.strfromlocal()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5174

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: D5174: py3: make sure we pass sysstr in sqlite3.connect()

[Yuya Nishihara]

>  def makedb(path):
>  """Construct a database handle for a database at path."""
>  
> -db = sqlite3.connect(path)
> +db = sqlite3.connect(pycompat.sysstr(path))

Perhaps, `encoding.strfromlocal()`.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5174: py3: make sure we pass sysstr in sqlite3.connect()

[pulkit (Pulkit Goyal)]

pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5174

AFFECTED FILES
  hgext/sqlitestore.py

CHANGE DETAILS

diff --git a/hgext/sqlitestore.py b/hgext/sqlitestore.py
--- a/hgext/sqlitestore.py
+++ b/hgext/sqlitestore.py
@@ -973,7 +973,7 @@
 def makedb(path):
 """Construct a database handle for a database at path."""
 
-db = sqlite3.connect(path)
+db = sqlite3.connect(pycompat.sysstr(path))
 db.text_factory = bytes
 
 res = db.execute(r'PRAGMA user_version').fetchone()[0]



To: pulkit, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel