D5590: watchman: ignore some of watchman errors
lothiraldan abandoned this revision. lothiraldan added a comment. Resent as https://phab.mercurial-scm.org/D5955 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan updated this revision to Diff 14074.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5590?vs=14071=14074
REVISION DETAIL
https://phab.mercurial-scm.org/D5590
AFFECTED FILES
hgext/fsmonitor/__init__.py
CHANGE DETAILS
diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -180,7 +180,8 @@
if isinstance(ex, watchmanclient.Unavailable):
# experimental config: fsmonitor.verbose
if ex.warn and ui.configbool('fsmonitor', 'verbose'):
-ui.warn(str(ex) + '\n')
+if 'illegal_fstypes' not in str(ex):
+ui.warn(str(ex) + '\n')
if ex.invalidate:
state.invalidate()
# experimental config: fsmonitor.verbose
To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan updated this revision to Diff 14071.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5590?vs=13415=14071
REVISION DETAIL
https://phab.mercurial-scm.org/D5590
AFFECTED FILES
hgext/fsmonitor/__init__.py
CHANGE DETAILS
diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -183,7 +183,8 @@
if isinstance(ex, watchmanclient.Unavailable):
# experimental config: fsmonitor.verbose
if ex.warn and ui.configbool('fsmonitor', 'verbose'):
-ui.warn(str(ex) + '\n')
+if 'illegal_fstypes' not in str(ex):
+ui.warn(str(ex) + '\n')
if ex.invalidate:
state.invalidate()
# experimental config: fsmonitor.verbose
To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan updated this revision to Diff 13415.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5590?vs=13226=13415
REVISION DETAIL
https://phab.mercurial-scm.org/D5590
AFFECTED FILES
hgext/fsmonitor/__init__.py
CHANGE DETAILS
diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -183,7 +183,8 @@
if isinstance(ex, watchmanclient.Unavailable):
# experimental config: hgwatchman.verbose
if ex.warn and ui.configbool('hgwatchman', 'verbose'):
-ui.warn(str(ex) + '\n')
+if 'illegal_fstypes' not in str(ex):
+ui.warn(str(ex) + '\n')
if ex.invalidate:
state.invalidate()
# experimental config: hgwatchman.verbose
To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5590#82940, @indygreg wrote: > I don't suppose there's a way to easily test this? I'm guessing not... > > The change seems reasonable though. Unfortunately, I don't see an easy way to test it Thank you for your thorough review of the series, I will wait after the RC to send a new version as it's a non-urgent series REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I don't suppose there's a way to easily test this? I'm guessing not... The change seems reasonable though. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan added a comment. This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a `RFC` flag REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 To: lothiraldan, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5590: watchman: ignore some of watchman errors
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Don't display 'illegal_fstypes' errors. In environments with network
filesystems, the error messages are quickly pilling up and polluting outputs.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5590
AFFECTED FILES
hgext/fsmonitor/__init__.py
CHANGE DETAILS
diff --git a/hgext/fsmonitor/__init__.py b/hgext/fsmonitor/__init__.py
--- a/hgext/fsmonitor/__init__.py
+++ b/hgext/fsmonitor/__init__.py
@@ -180,7 +180,8 @@
if isinstance(ex, watchmanclient.Unavailable):
# experimental config: hgwatchman.verbose
if ex.warn and ui.configbool('hgwatchman', 'verbose'):
-ui.warn(str(ex) + '\n')
+if 'illegal_fstypes' not in str(ex):
+ui.warn(str(ex) + '\n')
if ex.invalidate:
state.invalidate()
# experimental config: hgwatchman.verbose
To: lothiraldan, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
