D8456: rust: remove duplicate import
indygreg added a comment. Well, I attempted to rewrite `@`. But somehow the empty changeset got published before that push completed. So it is forever part of history now :/ REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8456 To: Alphare, #hg-reviewers, marmoute, indygreg Cc: indygreg, mercurial-patches, marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D8456: rust: remove duplicate import
indygreg added a comment. It looks like `hg phabread | hg import -` produced an empty changeset, which I accidentally pushed. I have since rewritten `@` on `hg-committed` to remove the empty changeset. This differential revision should be reopened (which I cannot do since I don't own it). REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8456 To: Alphare, #hg-reviewers, marmoute, indygreg Cc: indygreg, mercurial-patches, marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D8456: rust: remove duplicate import
Closed by commit rHGbe3e85cf8f4d: rust: remove duplicate import (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Revision". CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8456?vs=21152=21533#toc REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8456?vs=21152=21533 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8456 AFFECTED FILES CHANGE DETAILS To: Alphare, #hg-reviewers, marmoute, indygreg Cc: indygreg, mercurial-patches, marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D8456: rust: remove duplicate import
Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This patch currently fails to apply. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8456 To: Alphare, #hg-reviewers, marmoute, indygreg Cc: indygreg, mercurial-patches, marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D8456: rust: remove duplicate import
marmoute added a comment. marmoute accepted this revision. sure REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8456 To: Alphare, #hg-reviewers, marmoute Cc: marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D8456: rust: remove duplicate import
Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8456 AFFECTED FILES rust/hg-core/build.rs CHANGE DETAILS diff --git a/rust/hg-core/build.rs b/rust/hg-core/build.rs --- a/rust/hg-core/build.rs +++ b/rust/hg-core/build.rs @@ -5,9 +5,6 @@ // This software may be used and distributed according to the terms of the // GNU General Public License version 2 or any later version. -#[cfg(feature = "with-re2")] -use cc; - /// Uses either the system Re2 install as a dynamic library or the provided /// build as a static library #[cfg(feature = "with-re2")] To: Alphare, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel