Re: D4508: lazyancestors: reuse __iter__ implementation in __contains__
Queued, thanks. On Mon, 10 Sep 2018 06:50:06 +, martinvonz (Martin von Zweigbergk) wrote: > Why do we care about reference cycles again? Because some runtimes don't > have GC? In order to assist CPython to deallocate used objects as early as possible and deterministically, I think. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D4508: lazyancestors: reuse __iter__ implementation in __contains__
> +self._containsseen = set() > +self._containsiter = iter(self) Perhaps __iter__() needs to be extracted to a free function to avoid reference cycle. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
