Re: [Mesa-dev] [PATCH] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

[Tapani Pälli]

On 8/14/19 7:43 AM, Lepton Wu wrote:

Any concern for this CL? I think it's pretty safe to merge this since
any way android egl wrapper
doesn't like HAL_PIXEL_FORMAT_BGRA_ and won't return it for native
window format
and then won't set it as native window format.

https://android.googlesource.com/platform/frameworks/native/+/refs/heads/master/opengl/libs/EGL/eglApi.cpp#608


No concerns, this is fine.

Reviewed-by: Tapani Pälli 



On Wed, Jul 31, 2019 at 3:50 PM Lepton Wu  wrote:


From: Emil Velikov 

As said in the EGL_KHR_platform_android extensions

 For each EGLConfig that belongs to the Android platform, the
 EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as
 WINDOW_FORMAT_RGBA_.

Although it should be applicable overall.

Even though we use HAL_PIXEL_FORMAT here, those are numerically
identical to the  WINDOW_FORMAT_ and AHARDWAREBUFFER_FORMAT_ ones.

Barring the said format of course. That one is only listed in HAL.

Keep in mind that even if we try to use the said format, you'll get
caught by droid_create_surface(). The function compares the format of
the underlying window, against the NATIVE_VISUAL_ID of the config.

Unfortunatelly it only prints a warning, rather than error out, likely
leading to visual corruption.

While SDL will even call ANativeWindow_setBuffersGeometry() with the
wrong format, and conviniently ignore the [expected] failure.

Signed-off-by: Emil Velikov 
Acked-by: Tomasz Figa 
(tfiga: Remove only respective EGL config, leave EGL image as is.)
Signed-off-by: Tomasz Figa 
Signed-off-by: Lepton Wu 
---
  src/egl/drivers/dri2/platform_android.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/egl/drivers/dri2/platform_android.c 
b/src/egl/drivers/dri2/platform_android.c
index d37f6b8e447..6c54fc4f1fe 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b/src/egl/drivers/dri2/platform_android.c
@@ -1193,7 +1193,6 @@ droid_add_configs_for_visuals(_EGLDriver *drv, 
_EGLDisplay *disp)
{ HAL_PIXEL_FORMAT_RGBA_, { 0x00ff, 0xff00, 0x00ff, 
0xff00 } },
{ HAL_PIXEL_FORMAT_RGBX_, { 0x00ff, 0xff00, 0x00ff, 
0x } },
{ HAL_PIXEL_FORMAT_RGB_565,   { 0xf800, 0x07e0, 0x001f, 
0x } },
-  { HAL_PIXEL_FORMAT_BGRA_, { 0x00ff, 0xff00, 0x00ff, 
0xff00 } },
 };

 unsigned int format_count[ARRAY_SIZE(visuals)] = { 0 };
--
2.22.0.770.g0f2c4a37fd-goog


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111403] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111403

Jan Vesely  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 Blocks||99553

--- Comment #1 from Jan Vesely  ---
Thanks, it's interesting to see r600-clover running on loongson.

Image support is a long-standing issue (see #87738).
evergreen class GPUs have also other issues which have a higher priority.

*** This bug has been marked as a duplicate of bug 87738 ***


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=99553
[Bug 99553] Tracker bug for runnning OpenCL applications on Clover
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99553
Bug 99553 depends on bug 111403, which changed state.

Bug 111403 Summary: OpenCL device doesn't  support "Image support"
https://bugs.freedesktop.org/show_bug.cgi?id=111403

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99553

Jan Vesely  changed:

   What|Removed |Added

 Depends on||111403


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=111403
[Bug 111403] OpenCL device doesn't  support "Image support"
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Jan Vesely  changed:

   What|Removed |Added

 CC||shi1986...@126.com

--- Comment #8 from Jan Vesely  ---
*** Bug 111403 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

[Tapani Pälli]

On 8/13/19 9:55 PM, Mauro Rossi wrote:

Hi,

On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli > wrote:



On 8/13/19 3:32 PM, Mauro Rossi wrote:
 > Hi,
 >
 > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli
mailto:tapani.pa...@intel.com>
 > >>
wrote:
 >
 >     Hi;
 >
 >     On 8/13/19 2:43 PM, Mauro Rossi wrote:
 >      > Hi Tapani,
 >      >
 >      > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
 >     mailto:issor.or...@gmail.com>
>
 >      >        >
 >      >     On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
 >     mailto:issor.or...@gmail.com>
>
 >      >     
 >           >      >
 >      >      > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang
 >      >     mailto:cwhu...@android-x86.org> >
 >           wrote:
 >      >      > >
 >      >      > > Mauro Rossi mailto:issor.or...@gmail.com>
 >     >
 >      >     
 >           >      > > >
 >      >      > > > This patch partially reverts 20294dc ("mesa:
Enable asm
 >      >     unconditionally, ...")
 >      >      > > >
 >      >      > > > Android makefile build logic needs to disable
assembler
 >      >     optimization
 >      >      > > > in 32bit builds to avoid text relocations for
 >     libglapi.so shared
 >      >      > > >
 >      >      > > > Fixes the following build error with Android
x86 32bit
 >     target:
 >      >      > > >
 >      >      > > > [  0% 4/477] target SharedLib: libglapi
 >      >
 > 
  (out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so)

 >      >      > > > FAILED:
 >      >
 > 
  out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so

 >      >      > > > ...
 >      >      > > >
 >      >
 > 
  prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld:

 >      >     warning: shared library text segment is not shareable
 >      >      > > >
 >      >
 > 
  prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld:

 >      >     error: treating warnings as errors
 >      >      > > > clang-6.0: error: linker command failed with
exit code
 >     1 (use
 >      >     -v to see invocation)
 >      >      > > >
 >      >      > > > Fixes: 20294dc ("mesa: Enable asm
unconditionally, now
 >     that
 >      >     gen_matypes is gone.")
 >      >      > > > Signed-off-by: Mauro Rossi
mailto:issor.or...@gmail.com>
 >     >
 >      >            >      > > > ---
 >      >      > > > Android.common.mk 

 >     
 >      >       | 3 +++
 >      >      > > >  Android.mk                          | 7 +++
 >      >      > > >  src/mesa/Android.libmesa_dricore.mk

 >     
 >      >      | 2 ++
 >      >      > > >  src/mesa/Android.libmesa_st_mesa.mk

 >     
 >      >      | 2 ++
 >      >      > > >  4 files changed, 14 insertions(+)
 >      >      > > >
 >      >      > > > diff --git a/Android.common.mk

 >      
 >      >     b/Android.common.mk 

 >     
 >      >      > > > index 8a1c734353..209654bb75 100644
 >      >      > > > --- a/Android.common.mk

Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

[Jason Ekstrand]

I take it this happens when subslices_delta == 0 and we take the early
return?

On Wed, Aug 14, 2019 at 5:45 PM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:

> I failed to initialize it on the other cases in GEN11 and it was causing
> a segfault when going through anv_DestroyDevice, if compiled with
> valgrind.
>
> Fixes: 7bc022b4bbc ("anv/gen11: Emit SLICE_HASH_TABLE when pipes are
> unbalanced.)
> ---
>  src/intel/vulkan/genX_state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
> index de8b753dd34..3bf4890b4a4 100644
> --- a/src/intel/vulkan/genX_state.c
> +++ b/src/intel/vulkan/genX_state.c
> @@ -92,6 +92,8 @@ static void
>  genX(emit_slice_hashing_state)(struct anv_device *device,
> struct anv_batch *batch)
>  {
> +   device->slice_hash = (struct anv_state) { 0 };
> +
>  #if GEN_GEN == 11
> const unsigned *ppipe_subslices = device->info.ppipe_subslices;
> int subslices_delta = ppipe_subslices[0] - ppipe_subslices[1];
> @@ -156,8 +158,6 @@ genX(emit_slice_hashing_state)(struct anv_device
> *device,
> anv_batch_emit(batch, GENX(3DSTATE_3D_MODE), mode) {
>mode.SliceHashingTableEnable = true;
> }
> -#else
> -   device->slice_hash = (struct anv_state) { 0 };
>  #endif
>  }
>
> --
> 2.21.0
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111403] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111403

Bug ID: 111403
   Summary: OpenCL device doesn't  support "Image support"
   Product: Mesa
   Version: 18.0
  Hardware: Other
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Other
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: shi1986...@126.com
QA Contact: mesa-dev@lists.freedesktop.org

when running  clinfo command on my platform, I noticed OpenCL Device(ADM 
Radeon HD8470) doesn't support "Image Support".
   As a beginner, I don't know why such a problem occurred. It's whether a
fault which about AMD HD8470 Device or Video Driver on my platform, or I was
ever neglect some compiling options when build mesa(packages such as
mesa-libOpenCL/mesa-libOpenCL-devel  come from  mesa source rpm package ). 

   Information about my platfom as follows：

***
#1. clinfo enumerates the OpenCL platform and Device

[root@localhost ~]# clinfo
Number of platforms   1
  Platform Name   Clover
  Platform Vendor Mesa
  Platform VersionOpenCL 1.1 Mesa 18.0.5
  Platform ProfileFULL_PROFILE
  Platform Extensions cl_khr_icd
  Platform Extensions function suffix MESA

  Platform Name   Clover
Number of devices 1
  Device Name AMD CAICOS (DRM 2.49.0 /
3.10.84-21.fc21.loongson.18.mips64el, LLVM 8.0.0)
  Device Vendor   AMD
  Device Vendor ID0x1002
  Device Version  OpenCL 1.1 Mesa 18.0.5
  Driver Version  18.0.5
  Device OpenCL C Version OpenCL C 1.1
  Device Type GPU
  Device Profile  FULL_PROFILE
  Max compute units   2
  Max clock frequency 775MHz
  Max work item dimensions3
  Max work item sizes 256x256x256
  Max work group size 256
  Preferred work group size multiple  64
  Preferred / native vector sizes
char16 / 16
short8 / 8
int  4 / 4
long 2 / 2
half 0 / 0(n/a)
float4 / 4
double   0 / 0(n/a)
  Half-precision Floating-point support   (n/a)
  Single-precision Floating-point support (core)
Denormals No
Infinity and NANs Yes
Round to nearest  Yes
Round to zero No
Round to infinity No
IEEE754-2008 fused multiply-add   No
Support is emulated in software   No
Correctly-rounded divide and sqrt operations  No
  Double-precision Floating-point support (n/a)
  Address bits32, Little-Endian
  Global memory size  1073741824 (1024MiB)
  Error Correction supportNo
  Max memory allocation   751619276 (716.8MiB)
  Unified memory for Host and Device  No
  Minimum alignment for any data type 128 bytes
  Alignment of base address   131072 bits (16384 bytes)
  Global Memory cache typeNone

  Image support   No

  Local memory type   Local
  Local memory size   32768 (32KiB)
  Max constant buffer size751619276 (716.8MiB)
  Max number of constant args 15
  Max size of kernel argument 1024
  Queue properties
Out-of-order executionNo
Profiling Yes
  Profiling timer resolution  0ns
  Execution capabilities
Run OpenCL kernelsYes
Run native kernelsNo
  Device AvailableYes
  

[Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

[Rafael Antognolli]

I failed to initialize it on the other cases in GEN11 and it was causing
a segfault when going through anv_DestroyDevice, if compiled with
valgrind.

Fixes: 7bc022b4bbc ("anv/gen11: Emit SLICE_HASH_TABLE when pipes are
unbalanced.)
---
 src/intel/vulkan/genX_state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
index de8b753dd34..3bf4890b4a4 100644
--- a/src/intel/vulkan/genX_state.c
+++ b/src/intel/vulkan/genX_state.c
@@ -92,6 +92,8 @@ static void
 genX(emit_slice_hashing_state)(struct anv_device *device,
struct anv_batch *batch)
 {
+   device->slice_hash = (struct anv_state) { 0 };
+
 #if GEN_GEN == 11
const unsigned *ppipe_subslices = device->info.ppipe_subslices;
int subslices_delta = ppipe_subslices[0] - ppipe_subslices[1];
@@ -156,8 +158,6 @@ genX(emit_slice_hashing_state)(struct anv_device *device,
anv_batch_emit(batch, GENX(3DSTATE_3D_MODE), mode) {
   mode.SliceHashingTableEnable = true;
}
-#else
-   device->slice_hash = (struct anv_state) { 0 };
 #endif
 }
 
-- 
2.21.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 110810] Vulkan spec break: VkCommandBufferInheritanceInfo.framebuffer is NOT optional

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=110810

--- Comment #5 from Sebastian Sydow  ---
I wanted to ask whether this issue already got fixed or is still being worked
on as there haven't been any updates for a while.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111401] Vulkan overlay layer - async compute not supported, making overlay disappear in Doom

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111401

Bug ID: 111401
   Summary: Vulkan overlay layer - async compute not supported,
making overlay disappear in Doom
   Product: Mesa
   Version: git
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Other
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: tempel.jul...@gmail.com
QA Contact: mesa-dev@lists.freedesktop.org

The Vulkan overlay layer doesn't work with async compute on GCN/RDNA and
probably neither Nvidia Turing GPUs, it simply disappears.
To reproduce, start Doom on any Radeon (driver shouldn't matter) in Steam Play
and set it to Vulkan with Ultra preset and 8xTSSAA: When in the actual game,
the Mesa overlay will simply disappear. When changing anti aliasing to FXAA,
async compute is turned off and the Mesa overlay gets visible again.

On windows, overlays like that of Steam (the overlay of the Linux version for
some reason shares the traits of Mesa overlay) or RTSS disable presenting
frames from a compute queue. This makes them work, but degrades performance
substantially.

The windows open source tool OCAT supports an overlay for Vulkan that is
compatible with async compute and doesn't degrade performance:
https://ocat.readthedocs.io/en/latest/index.html

Tested with mesa-git some weeks ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 110471] No Man Sky GPU hang

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=110471

--- Comment #6 from Haxk20  ---
This is issue of ACO and not mesa in general. But UI is still unusable. Like 5
fps UI.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev