[Mesa-dev] [Bug 111404] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111404

vans88  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from vans88  ---


*** This bug has been marked as a duplicate of bug 87738 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

--- Comment #9 from vans88  ---
*** Bug 111404 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

[Mauro Rossi]

Hi Tapani, Eric,

On Thu, Aug 15, 2019 at 1:00 PM Tapani Pälli  wrote:

>
> On 8/15/19 12:52 PM, Mauro Rossi wrote:
> > Hi Tapani,
> >
> > On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli  > > wrote:
> >
> >
> > On 8/13/19 9:55 PM, Mauro Rossi wrote:
> >  > Hi,
> >  >
> >  > On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli
> > mailto:tapani.pa...@intel.com>
> >  > >>
> > wrote:
> >  >
> >  >
> >  > On 8/13/19 3:32 PM, Mauro Rossi wrote:
> >  >  > Hi,
> >  >  >
> >  >  > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli
> >  > mailto:tapani.pa...@intel.com>
> > >
> >  >  >  >   >  >  > wrote:
> >  >  >
> >  >  > Hi;
> >  >  >
> >  >  > On 8/13/19 2:43 PM, Mauro Rossi wrote:
> >  >  >  > Hi Tapani,
> >  >  >  >
> >  >  >  > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
> >  >  > mailto:issor.or...@gmail.com>
> > >
> >  > 
> > >>
> >  >  >  >  > 
> >  > >
> > 
> >  >  >  wrote:
> >  >  >  >
> >  >  >  > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
> >  >  > mailto:issor.or...@gmail.com>
> > >
> >  > 
> > >>
> >  >  >  >  > 
> >  > >
> >  >  >  > 
> >  >  >  wrote:
> >  >  >  >  >
> >  >  >  >  > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei
> Huang
> >  >  >  >  > 
> >  >  > >  > 
> >  >  > >>
> >  >  >  > 
> >  >  > >  > 
> >  >  > 
> >  >  > wrote:
> >  >  >  >  > >
> >  >  >  >  > > Mauro Rossi  > 
> >  > >
> >  >  >  >   > >>
> >  >  >  >  > 
> >  > >
> >  >  >  > 
> >  >  >  於 2019年7月14日 週日 下午5:17寫道：
> >  >  >  >  > > >
> >  >  >  >  > > > This patch partially reverts 20294dc
> ("mesa:
> >  > Enable asm
> >  >  >  > unconditionally, ...")
> >  >  >  >  > > >
> >  >  >  >  > > > Android makefile build logic needs to
> > disable
> >  > assembler
> >  >  >  > optimization
> >  >  >  >  > > > in 32bit builds to avoid text
> > relocations for
> >  >  > libglapi.so shared
> >  >  >  >  > > >
> >  >  >  >  > > > Fixes the following build error with
> Android
> >  > x86 32bit
> >  >  > target:
> >  >  >  >  > > >
> >  >  >  >  > > > [  0% 4/477] target SharedLib: libglapi
> >  >  >  >
> >  >  >
> >  >
> >
>  
> 

Re: [Mesa-dev] [PATCH] mesa: fix texStore for FORMAT_Z32_FLOAT_S8X24_UINT

[Ilia Mirkin]

Subtle. The source format *can* be 64-bit, by the way, but if it's
GL_DEPTH_COMPONENT it may well be 32-bit.

But what if it's GL_STENCIL_INDEX -- could it not be 1-byte? IOW,
should this just be a char *, and use byte addressing and be done with
it?

On Thu, Aug 15, 2019 at 7:56 PM Marek Olšák  wrote:
>
> From: Jiadong Zhu 
>
> _mesa_texstore_z32f_x24s8 calculates source rowStride at a
> pace of 64-bit, this will make inaccuracy offset if the width
> of src image is an odd number. Modify src pointer to int_32* as
> source image format is gl_float which is 32-bit per pixel.
>
> Signed-off-by: Jiadong Zhu 
> Signed-off-by: Marek Olšák 
> ---
>  src/mesa/main/texstore.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  mode change 100644 => 100755 src/mesa/main/texstore.c
>
> diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
> old mode 100644
> new mode 100755
> index 2913d4bc067..207695041a7
> --- a/src/mesa/main/texstore.c
> +++ b/src/mesa/main/texstore.c
> @@ -531,35 +531,35 @@ _mesa_texstore_s8(TEXSTORE_PARAMS)
> return GL_TRUE;
>  }
>
>
>  static GLboolean
>  _mesa_texstore_z32f_x24s8(TEXSTORE_PARAMS)
>  {
> GLint img, row;
> const GLint srcRowStride
>= _mesa_image_row_stride(srcPacking, srcWidth, srcFormat, srcType)
> -  / sizeof(uint64_t);
> + / sizeof(int32_t);
>
> assert(dstFormat == MESA_FORMAT_Z32_FLOAT_S8X24_UINT);
> assert(srcFormat == GL_DEPTH_STENCIL ||
>srcFormat == GL_DEPTH_COMPONENT ||
>srcFormat == GL_STENCIL_INDEX);
> assert(srcFormat != GL_DEPTH_STENCIL ||
>srcType == GL_UNSIGNED_INT_24_8 ||
>srcType == GL_FLOAT_32_UNSIGNED_INT_24_8_REV);
>
> /* In case we only upload depth we need to preserve the stencil */
> for (img = 0; img < srcDepth; img++) {
>uint64_t *dstRow = (uint64_t *) dstSlices[img];
> -  const uint64_t *src
> - = (const uint64_t *) _mesa_image_address(dims, srcPacking, srcAddr,
> +  const int32_t *src
> + = (const int32_t *) _mesa_image_address(dims, srcPacking, srcAddr,
> srcWidth, srcHeight,
> srcFormat, srcType,
> img, 0, 0);
>for (row = 0; row < srcHeight; row++) {
>   /* The unpack functions with:
>*dstType = GL_FLOAT_32_UNSIGNED_INT_24_8_REV
>* only write their own dword, so the other dword (stencil
>* or depth) is preserved. */
>   if (srcFormat != GL_STENCIL_INDEX)
>  _mesa_unpack_depth_span(ctx, srcWidth,
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: fix texStore for FORMAT_Z32_FLOAT_S8X24_UINT

[Marek Olšák]

From: Jiadong Zhu 

_mesa_texstore_z32f_x24s8 calculates source rowStride at a
pace of 64-bit, this will make inaccuracy offset if the width
of src image is an odd number. Modify src pointer to int_32* as
source image format is gl_float which is 32-bit per pixel.

Signed-off-by: Jiadong Zhu 
Signed-off-by: Marek Olšák 
---
 src/mesa/main/texstore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 mode change 100644 => 100755 src/mesa/main/texstore.c

diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
old mode 100644
new mode 100755
index 2913d4bc067..207695041a7
--- a/src/mesa/main/texstore.c
+++ b/src/mesa/main/texstore.c
@@ -531,35 +531,35 @@ _mesa_texstore_s8(TEXSTORE_PARAMS)
return GL_TRUE;
 }
 
 
 static GLboolean
 _mesa_texstore_z32f_x24s8(TEXSTORE_PARAMS)
 {
GLint img, row;
const GLint srcRowStride
   = _mesa_image_row_stride(srcPacking, srcWidth, srcFormat, srcType)
-  / sizeof(uint64_t);
+ / sizeof(int32_t);
 
assert(dstFormat == MESA_FORMAT_Z32_FLOAT_S8X24_UINT);
assert(srcFormat == GL_DEPTH_STENCIL ||
   srcFormat == GL_DEPTH_COMPONENT ||
   srcFormat == GL_STENCIL_INDEX);
assert(srcFormat != GL_DEPTH_STENCIL ||
   srcType == GL_UNSIGNED_INT_24_8 ||
   srcType == GL_FLOAT_32_UNSIGNED_INT_24_8_REV);
 
/* In case we only upload depth we need to preserve the stencil */
for (img = 0; img < srcDepth; img++) {
   uint64_t *dstRow = (uint64_t *) dstSlices[img];
-  const uint64_t *src
- = (const uint64_t *) _mesa_image_address(dims, srcPacking, srcAddr,
+  const int32_t *src
+ = (const int32_t *) _mesa_image_address(dims, srcPacking, srcAddr,
srcWidth, srcHeight,
srcFormat, srcType,
img, 0, 0);
   for (row = 0; row < srcHeight; row++) {
  /* The unpack functions with:
   *dstType = GL_FLOAT_32_UNSIGNED_INT_24_8_REV
   * only write their own dword, so the other dword (stencil
   * or depth) is preserved. */
  if (srcFormat != GL_STENCIL_INDEX)
 _mesa_unpack_depth_span(ctx, srcWidth,
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

[Mauro Rossi]

Hi Lepton,

On Thu, Aug 15, 2019 at 9:58 PM Lepton Wu  wrote:

> That's interesting. The android frame work will hard coded to use
> RGBA_ and set it as window format here:
>
>
> https://android.googlesource.com/platform/frameworks/native/+/refs/heads/master/opengl/libs/EGL/eglApi.cpp#738
>
> Do you have a custom version of android which do different code here?
>

Affirmative, you may check [1] for reference

[1]
http://git.osdn.net/view?p=android-x86/frameworks-native.git;a=commit;h=792c8dc009bd3a0c44eb39e757a95e099c03b54c


>
> For other GPU, like intel, if we choose a EGL config with BGRA ,
> finally we got a wrong color on screen.
>

android-x86 implementation selects BGRA_ only when RGBA_ not
available,
in a similar way to a pre-existing Workaround 10194508 that was removed
from AOSP code

Removing HAL_PIXEL_FORMAT_BGRA_ support from egl/android
SurfaceFlinger will just crash with SIGABRT on nouveau


>
> On Thu, Aug 15, 2019 at 12:49 PM Mauro Rossi 
> wrote:
> >
> > Hi,
> >
> > sorry if I'm communicating in dedicated thread, but I don't know how to
> reply to existing one.
> >
> > The proposed patch is based on the wrong assumption that all drivers
> used with Android have RGBA_, which is not correct, for example nouveau
> does not support RGBA on primary planes, infact we have a fallback to
> simpler EGL query in android-x86 and we use BGRA_ (pixel format = 5)
> >
> > If patch does not solve a specific problem and it will cause a
> regression at least in nouveau, it is recommended to abandon the patch
> >
> > Thanks for your feedbacks
> >
> > Mauro
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104836

Matt Turner  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #7 from Matt Turner  ---
Okay, thank you. Feel free to reopen if necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104836

--- Comment #6 from John Paul Adrian Glaubitz  ---
(In reply to Matt Turner from comment #5)
> Automake is gone now. Does this still seem to be a problem with Meson?
> 
> I haven't seen anything like this on Gentoo, FWIW, but we might not allow
> the right driver builds on ia64 to cause the problem.

Seems to build fine on Debian for version 19.1.4, see full build log at:

> https://buildd.debian.org/status/fetch.php?pkg=mesa=ia64=19.1.4-1=1565251671=0

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104836

Matt Turner  changed:

   What|Removed |Added

   Assignee|emil.l.veli...@gmail.com|mesa-dev@lists.freedesktop.
   ||org
 CC||matts...@gmail.com
 Status|ASSIGNED|NEW

--- Comment #5 from Matt Turner  ---
Automake is gone now. Does this still seem to be a problem with Meson?

I haven't seen anything like this on Gentoo, FWIW, but we might not allow the
right driver builds on ia64 to cause the problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111408] [clover] build failure ‘clang::Language’ has not been declared

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111408

Bug ID: 111408
   Summary: [clover] build failure ‘clang::Language’ has not been
declared
   Product: Mesa
   Version: git
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Gallium/StateTracker/Clover
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: lonew...@xs4all.nl
QA Contact: mesa-dev@lists.freedesktop.org

Created attachment 145072
  --> https://bugs.freedesktop.org/attachment.cgi?id=145072=edit
log of build failure

llvm-project trunk rev fcd549a7d8 from august 04 2019

https://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/clover/llvm?id=6b8269d0bbded7a42cd2de2b50d077cf12157d15
seems a liklely cause.

Maybe the implementation in there is incomplete ?

Full build log attached.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

[Ilia Mirkin]

Without commenting on Android-specific issues, of which I'm blissfully
unaware, all NVIDIA G80+ (i.e. DX10+) GPUs support both RGBA8 and
BGRA8 for display and color rendering:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/nouveau/dispnv50/base507c.c#n206

However the nouveau gallium driver only sets the BGRA variant as
PIPE_BIND_DISPLAY_TARGET since supporting both RGBA and BGRA caused
issues, as I recall. And the legacy AddFB() call defaults to BGRA8, so
that has to remain working. I think this may affect which configs are
made available.

[Also note that only Kepler+ NVIDIA GPUs support RGB10 ordering, so we
prefer BGR10 everywhere to make life easier. But I think that's out of
scope for this discussion.]

Cheers,

  -ilia

On Thu, Aug 15, 2019 at 3:49 PM Mauro Rossi  wrote:
>
> Hi,
>
> sorry if I'm communicating in dedicated thread, but I don't know how to reply 
> to existing one.
>
> The proposed patch is based on the wrong assumption that all drivers used 
> with Android have RGBA_, which is not correct, for example nouveau does 
> not support RGBA on primary planes, infact we have a fallback to simpler EGL 
> query in android-x86 and we use BGRA_ (pixel format = 5)
>
> If patch does not solve a specific problem and it will cause a regression at 
> least in nouveau, it is recommended to abandon the patch
>
> Thanks for your feedbacks
>
> Mauro
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

[Lepton Wu]

That's interesting. The android frame work will hard coded to use
RGBA_ and set it as window format here:

https://android.googlesource.com/platform/frameworks/native/+/refs/heads/master/opengl/libs/EGL/eglApi.cpp#738

Do you have a custom version of android which do different code here?

For other GPU, like intel, if we choose a EGL config with BGRA ,
finally we got a wrong color on screen.

On Thu, Aug 15, 2019 at 12:49 PM Mauro Rossi  wrote:
>
> Hi,
>
> sorry if I'm communicating in dedicated thread, but I don't know how to reply 
> to existing one.
>
> The proposed patch is based on the wrong assumption that all drivers used 
> with Android have RGBA_, which is not correct, for example nouveau does 
> not support RGBA on primary planes, infact we have a fallback to simpler EGL 
> query in android-x86 and we use BGRA_ (pixel format = 5)
>
> If patch does not solve a specific problem and it will cause a regression at 
> least in nouveau, it is recommended to abandon the patch
>
> Thanks for your feedbacks
>
> Mauro
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Concern about proposed patch "egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support"

[Mauro Rossi]

Hi,

sorry if I'm communicating in dedicated thread, but I don't know how to
reply to existing one.

The proposed patch is based on the wrong assumption that all drivers used
with Android have RGBA_, which is not correct, for example nouveau does
not support RGBA on primary planes, infact we have a fallback to simpler
EGL query in android-x86 and we use BGRA_ (pixel format = 5)

If patch does not solve a specific problem and it will cause a regression
at least in nouveau, it is recommended to abandon the patch

Thanks for your feedbacks

Mauro
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=106677

Deepak  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #5 from Deepak  ---
Unable to duplicate, at least with new top of tree mesa and vmware drivers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111393] Warnings about Formats with "inconsistent channel types"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111393

zefkerri...@gmail.com changed:

   What|Removed |Added

 CC||zefkerri...@gmail.com

--- Comment #1 from zefkerri...@gmail.com ---
I have exactly the same problem.(In reply to Mauro Rossi from comment #0)
> Hi,
> I'm building mesa with radv and I'm getting these warnings
> printed out from gfx10_format_table.h generator (gfx10_format_table.py)
> 
> Gen Header: libmesa_radv_common_32 <= gfx10_format_table.h
> Format VK_FORMAT_D16_UNORM_S8_UINT has inconsistent channel types: set([1])
> set([False, True]) set([False, True])
> Format VK_FORMAT_D24_UNORM_S8_UINT has inconsistent channel types: set([1])
> set([False, True]) set([False, True])
> Format VK_FORMAT_D32_SFLOAT_S8_UINT has inconsistent channel types: set([1,
> 4]) set([False]) set([False, True])
> 
> Could you please check what is the problem?
> Mauro

I have exactly the same problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

[Jason Ekstrand]

On Thu, Aug 15, 2019 at 10:48 AM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:

> On Wed, Aug 14, 2019 at 10:05:34PM -0500, Jason Ekstrand wrote:
> > I take it this happens when subslices_delta == 0 and we take the early
> return?
>
> Yes, exactly, in that case device->slice_hash is not initialized. I can
> add this to the commit message to make it more clear.
>

That'd be nice.

Reviewed-by: Jason Ekstrand 


> > On Wed, Aug 14, 2019 at 5:45 PM Rafael Antognolli <
> rafael.antogno...@intel.com>
> > wrote:
> >
> > I failed to initialize it on the other cases in GEN11 and it was
> causing
> > a segfault when going through anv_DestroyDevice, if compiled with
> > valgrind.
> >
> > Fixes: 7bc022b4bbc ("anv/gen11: Emit SLICE_HASH_TABLE when pipes are
> > unbalanced.)
> > ---
> >  src/intel/vulkan/genX_state.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/intel/vulkan/genX_state.c
> b/src/intel/vulkan/genX_state.c
> > index de8b753dd34..3bf4890b4a4 100644
> > --- a/src/intel/vulkan/genX_state.c
> > +++ b/src/intel/vulkan/genX_state.c
> > @@ -92,6 +92,8 @@ static void
> >  genX(emit_slice_hashing_state)(struct anv_device *device,
> > struct anv_batch *batch)
> >  {
> > +   device->slice_hash = (struct anv_state) { 0 };
> > +
> >  #if GEN_GEN == 11
> > const unsigned *ppipe_subslices = device->info.ppipe_subslices;
> > int subslices_delta = ppipe_subslices[0] - ppipe_subslices[1];
> > @@ -156,8 +158,6 @@ genX(emit_slice_hashing_state)(struct anv_device
> > *device,
> > anv_batch_emit(batch, GENX(3DSTATE_3D_MODE), mode) {
> >mode.SliceHashingTableEnable = true;
> > }
> > -#else
> > -   device->slice_hash = (struct anv_state) { 0 };
> >  #endif
> >  }
> >
> > --
> > 2.21.0
> >
> >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

[Rafael Antognolli]

On Wed, Aug 14, 2019 at 10:05:34PM -0500, Jason Ekstrand wrote:
> I take it this happens when subslices_delta == 0 and we take the early return?

Yes, exactly, in that case device->slice_hash is not initialized. I can
add this to the commit message to make it more clear.

> On Wed, Aug 14, 2019 at 5:45 PM Rafael Antognolli 
> 
> wrote:
> 
> I failed to initialize it on the other cases in GEN11 and it was causing
> a segfault when going through anv_DestroyDevice, if compiled with
> valgrind.
> 
> Fixes: 7bc022b4bbc ("anv/gen11: Emit SLICE_HASH_TABLE when pipes are
> unbalanced.)
> ---
>  src/intel/vulkan/genX_state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
> index de8b753dd34..3bf4890b4a4 100644
> --- a/src/intel/vulkan/genX_state.c
> +++ b/src/intel/vulkan/genX_state.c
> @@ -92,6 +92,8 @@ static void
>  genX(emit_slice_hashing_state)(struct anv_device *device,
> struct anv_batch *batch)
>  {
> +   device->slice_hash = (struct anv_state) { 0 };
> +
>  #if GEN_GEN == 11
> const unsigned *ppipe_subslices = device->info.ppipe_subslices;
> int subslices_delta = ppipe_subslices[0] - ppipe_subslices[1];
> @@ -156,8 +158,6 @@ genX(emit_slice_hashing_state)(struct anv_device
> *device,
> anv_batch_emit(batch, GENX(3DSTATE_3D_MODE), mode) {
>mode.SliceHashingTableEnable = true;
> }
> -#else
> -   device->slice_hash = (struct anv_state) { 0 };
>  #endif
>  }
> 
> --
> 2.21.0
> 
> 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

[Tapani Pälli]

On 8/15/19 12:52 PM, Mauro Rossi wrote:

Hi Tapani,

On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli > wrote:



On 8/13/19 9:55 PM, Mauro Rossi wrote:
 > Hi,
 >
 > On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli
mailto:tapani.pa...@intel.com>
 > >>
wrote:
 >
 >
 >     On 8/13/19 3:32 PM, Mauro Rossi wrote:
 >      > Hi,
 >      >
 >      > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli
 >     mailto:tapani.pa...@intel.com>
>
 >      >       wrote:
 >      >
 >      >     Hi;
 >      >
 >      >     On 8/13/19 2:43 PM, Mauro Rossi wrote:
 >      >      > Hi Tapani,
 >      >      >
 >      >      > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
 >      >     mailto:issor.or...@gmail.com>
>
 >     
>>
 >      >      > 
 >     >

 >      wrote:
 >      >      >
 >      >      >     On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
 >      >     mailto:issor.or...@gmail.com>
>
 >     
>>
 >      >      >     
 >     >
 >      >     
 >      wrote:
 >      >      >      >
 >      >      >      > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang
 >      >      >     mailto:cwhu...@android-x86.org>
 >     > 
 >     >>
 >      >     
 >     > 
 >     
 >      >     wrote:
 >      >      >      > >
 >      >      >      > > Mauro Rossi mailto:issor.or...@gmail.com>
 >     >
 >      >      >>
 >      >      >     
 >     >
 >      >     
 >      於 2019年7月14日 週日 下午5:17寫道：
 >      >      >      > > >
 >      >      >      > > > This patch partially reverts 20294dc ("mesa:
 >     Enable asm
 >      >      >     unconditionally, ...")
 >      >      >      > > >
 >      >      >      > > > Android makefile build logic needs to
disable
 >     assembler
 >      >      >     optimization
 >      >      >      > > > in 32bit builds to avoid text
relocations for
 >      >     libglapi.so shared
 >      >      >      > > >
 >      >      >      > > > Fixes the following build error with Android
 >     x86 32bit
 >      >     target:
 >      >      >      > > >
 >      >      >      > > > [  0% 4/477] target SharedLib: libglapi
 >      >      >
 >      >
 > 
  (out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so)

 >      >      >      > > > FAILED:
 >      >      >
 >      >
 > 
  out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so

 >      >      >      > > > ...
 >      >      >      > > >
 >      >      >
 >      >
 > 
  prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld:

 >      >      >     warning: shared library text 

[Mesa-dev] [Bug 111406] [regression] - build failure on arm64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111406

Fabio Pedretti  changed:

   What|Removed |Added

 CC||i...@freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111406] [regression] - build failure on arm64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111406

Fabio Pedretti  changed:

   What|Removed |Added

 CC||andrii.o.kryvytskyi@globall
   ||ogic.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111406] [regression] - build failure on arm64

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111406

Bug ID: 111406
   Summary: [regression] - build failure on arm64
   Product: Mesa
   Version: git
  Hardware: ARM
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: pedretti.fa...@gmail.com
QA Contact: mesa-dev@lists.freedesktop.org

Full build log:
https://launchpadlibrarian.net/437404765/buildlog_ubuntu-disco-arm64.mesa_19.2~git1908150730.44a6c3~oibaf~d_BUILDING.txt.gz


Failure at > f2965f <= 44a6c3

/usr/bin/ld: /usr/lib/gcc/aarch64-linux-gnu/8/libstdc++.so: undefined reference
to `pthread_create'
/usr/bin/ld: /usr/lib/gcc/aarch64-linux-gnu/8/libstdc++.so: undefined reference
to `pthread_once'
/usr/bin/ld: /usr/lib/gcc/aarch64-linux-gnu/8/libstdc++.so: undefined reference
to `pthread_join'
collect2: error: ld returned 1 exit status

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

[Mauro Rossi]

Hi Tapani,

On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli  wrote:

>
> On 8/13/19 9:55 PM, Mauro Rossi wrote:
> > Hi,
> >
> > On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli  > > wrote:
> >
> >
> > On 8/13/19 3:32 PM, Mauro Rossi wrote:
> >  > Hi,
> >  >
> >  > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli
> > mailto:tapani.pa...@intel.com>
> >  > >>
> > wrote:
> >  >
> >  > Hi;
> >  >
> >  > On 8/13/19 2:43 PM, Mauro Rossi wrote:
> >  >  > Hi Tapani,
> >  >  >
> >  >  > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
> >  > mailto:issor.or...@gmail.com>
> > >
> >  >  >  >   >  >  >  >
> >  >  > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi
> >  > mailto:issor.or...@gmail.com>
> > >
> >  >  >  > 
> >  >  >  >  >  >  >
> >  >  >  > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang
> >  >  >  >   > >
> >  >  >   >  >  > wrote:
> >  >  >  > >
> >  >  >  > > Mauro Rossi  > 
> >  > >
> >  >  >  > 
> >  >  >  >  >  >  > > >
> >  >  >  > > > This patch partially reverts 20294dc ("mesa:
> > Enable asm
> >  >  > unconditionally, ...")
> >  >  >  > > >
> >  >  >  > > > Android makefile build logic needs to disable
> > assembler
> >  >  > optimization
> >  >  >  > > > in 32bit builds to avoid text relocations for
> >  > libglapi.so shared
> >  >  >  > > >
> >  >  >  > > > Fixes the following build error with Android
> > x86 32bit
> >  > target:
> >  >  >  > > >
> >  >  >  > > > [  0% 4/477] target SharedLib: libglapi
> >  >  >
> >  >
> >
>  
> (out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so)
> >  >  >  > > > FAILED:
> >  >  >
> >  >
> >
>  
> out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so
> >  >  >  > > > ...
> >  >  >  > > >
> >  >  >
> >  >
> >
>  
> prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld:
> >  >  > warning: shared library text segment is not shareable
> >  >  >  > > >
> >  >  >
> >  >
> >
>  
> prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld:
> >  >  > error: treating warnings as errors
> >  >  >  > > > clang-6.0: error: linker command failed with
> > exit code
> >  > 1 (use
> >  >  > -v to see invocation)
> >  >  >  > > >
> >  >  >  > > > Fixes: 20294dc ("mesa: Enable asm
> > unconditionally, now
> >  > that
> >  >  > gen_matypes is gone.")
> >  >  >  > > > Signed-off-by: Mauro Rossi
> > mailto:issor.or...@gmail.com>
> >  > >
> >  >  >  >   >  >  >  >  > > > ---
> >  >  >  > > > Android.common.mk 
> > 
> >  > 
> >  >  >   | 3 +++
> >  >  >  > > >  Android.mk  | 7 +++
> >  >  >  > > >  src/mesa/Android.libmesa_dricore.mk
> > 
> >  > 
> >  >  >  | 2 ++
> >  >  >  > > >  src/mesa/Android.libmesa_st_mesa.mk
> > 
> >  > 
> >  >  > 

[Mesa-dev] [Bug 111404] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111404

--- Comment #1 from vans88  ---
  When I filtered the mesa source code with keyword
"PIPE_COMPUTE_CAP_IMAGES_SUPPORTED", I found the following code information.


[root@localhost mesa-18.0.5]# grep "PIPE_COMPUTE_CAP_IMAGES_SUPPORTED" . -rn
./src/gallium/drivers/softpipe/sp_screen.c:551:   case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/drivers/freedreno/freedreno_screen.c:705: case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/drivers/r600/r600_pipe_common.c:1120: case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/drivers/nouveau/nv50/nv50_screen.c:444:   case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/drivers/nouveau/nvc0/nvc0_screen.c:518:   case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/drivers/radeonsi/si_get.c:864:case
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED:
./src/gallium/docs/source/screen.rst:560:*
``PIPE_COMPUTE_CAP_IMAGES_SUPPORTED``: Whether images are supported
./src/gallium/include/pipe/p_defines.h:920:  
PIPE_COMPUTE_CAP_IMAGES_SUPPORTED,
./src/gallium/state_trackers/clover/core/device.cpp:185:   
  PIPE_COMPUTE_CAP_IMAGES_SUPPORTED)[0];


I also found a similar bug submission as follows, but it is not clear whether
the relevant patch provided in the article has been officially verified by mesa
and is applicable to the version of mesa 18.0.5.

https://bugs.freedesktop.org/show_bug.cgi?id=87738

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111404] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111404

Bug ID: 111404
   Summary: OpenCL device doesn't  support "Image support"
   Product: Mesa
   Version: 18.0
  Hardware: Other
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: Other
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: shi1986...@126.com
QA Contact: mesa-dev@lists.freedesktop.org

When enumerating OpenCL platforms and devices with the clinfo command, I found
that OpenCL devices (AMD Radeon HD 8470) do not support OpenCL images. 
  I don't understand why this problem occurs. I don't even understand whether
this is a fault in the graphics card itself or the graphics card driver, or
ignore several options when compiling mesa.

*
[root@localhost /]# clinfo
Number of platforms   1
  Platform Name   Clover
  Platform Vendor Mesa
  Platform VersionOpenCL 1.1 Mesa 18.0.5
  Platform ProfileFULL_PROFILE
  Platform Extensions cl_khr_icd
  Platform Extensions function suffix MESA

  Platform Name   Clover
Number of devices 1
  Device Name AMD CAICOS (DRM 2.49.0 /
3.10.84-21.fc21.loongson.18.mips64el, LLVM 8.0.0)
  Device Vendor   AMD
  Device Vendor ID0x1002
  Device Version  OpenCL 1.1 Mesa 18.0.5
  Driver Version  18.0.5
  Device OpenCL C Version OpenCL C 1.1
  Device Type GPU
  Device Profile  FULL_PROFILE
  Max compute units   2
  Max clock frequency 775MHz
  Max work item dimensions3
  Max work item sizes 256x256x256
  Max work group size 256
  Preferred work group size multiple  64
  Preferred / native vector sizes
char16 / 16
short8 / 8
int  4 / 4
long 2 / 2
half 0 / 0(n/a)
float4 / 4
double   0 / 0(n/a)
  Half-precision Floating-point support   (n/a)
  Single-precision Floating-point support (core)
Denormals No
Infinity and NANs Yes
Round to nearest  Yes
Round to zero No
Round to infinity No
IEEE754-2008 fused multiply-add   No
Support is emulated in software   No
Correctly-rounded divide and sqrt operations  No
  Double-precision Floating-point support (n/a)
  Address bits32, Little-Endian
  Global memory size  1073741824 (1024MiB)
  Error Correction supportNo
  Max memory allocation   751619276 (716.8MiB)
  Unified memory for Host and Device  No
  Minimum alignment for any data type 128 bytes
  Alignment of base address   131072 bits (16384 bytes)
  Global Memory cache typeNone
#
  Image support   No

  Local memory type   Local
  Local memory size   32768 (32KiB)
  Max constant buffer size751619276 (716.8MiB)
  Max number of constant args 15
  Max size of kernel argument 1024
  Queue properties
Out-of-order executionNo
Profiling Yes
  Profiling timer resolution  0ns
  Execution capabilities
Run OpenCL kernelsYes
Run native kernelsNo
  Device AvailableYes
  Compiler Available  Yes
  Device Extensions   cl_khr_byte_addressable_store
cl_khr_global_int32_base_atomics 

Re: [Mesa-dev] [PATCH] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

[Tapani Pälli]

On 8/14/19 7:43 AM, Lepton Wu wrote:

Any concern for this CL? I think it's pretty safe to merge this since
any way android egl wrapper
doesn't like HAL_PIXEL_FORMAT_BGRA_ and won't return it for native
window format
and then won't set it as native window format.

https://android.googlesource.com/platform/frameworks/native/+/refs/heads/master/opengl/libs/EGL/eglApi.cpp#608


No concerns, this is fine.

Reviewed-by: Tapani Pälli 



On Wed, Jul 31, 2019 at 3:50 PM Lepton Wu  wrote:


From: Emil Velikov 

As said in the EGL_KHR_platform_android extensions

 For each EGLConfig that belongs to the Android platform, the
 EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as
 WINDOW_FORMAT_RGBA_.

Although it should be applicable overall.

Even though we use HAL_PIXEL_FORMAT here, those are numerically
identical to the  WINDOW_FORMAT_ and AHARDWAREBUFFER_FORMAT_ ones.

Barring the said format of course. That one is only listed in HAL.

Keep in mind that even if we try to use the said format, you'll get
caught by droid_create_surface(). The function compares the format of
the underlying window, against the NATIVE_VISUAL_ID of the config.

Unfortunatelly it only prints a warning, rather than error out, likely
leading to visual corruption.

While SDL will even call ANativeWindow_setBuffersGeometry() with the
wrong format, and conviniently ignore the [expected] failure.

Signed-off-by: Emil Velikov 
Acked-by: Tomasz Figa 
(tfiga: Remove only respective EGL config, leave EGL image as is.)
Signed-off-by: Tomasz Figa 
Signed-off-by: Lepton Wu 
---
  src/egl/drivers/dri2/platform_android.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/egl/drivers/dri2/platform_android.c 
b/src/egl/drivers/dri2/platform_android.c
index d37f6b8e447..6c54fc4f1fe 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b/src/egl/drivers/dri2/platform_android.c
@@ -1193,7 +1193,6 @@ droid_add_configs_for_visuals(_EGLDriver *drv, 
_EGLDisplay *disp)
{ HAL_PIXEL_FORMAT_RGBA_, { 0x00ff, 0xff00, 0x00ff, 
0xff00 } },
{ HAL_PIXEL_FORMAT_RGBX_, { 0x00ff, 0xff00, 0x00ff, 
0x } },
{ HAL_PIXEL_FORMAT_RGB_565,   { 0xf800, 0x07e0, 0x001f, 
0x } },
-  { HAL_PIXEL_FORMAT_BGRA_, { 0x00ff, 0xff00, 0x00ff, 
0xff00 } },
 };

 unsigned int format_count[ARRAY_SIZE(visuals)] = { 0 };
--
2.22.0.770.g0f2c4a37fd-goog


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 111403] OpenCL device doesn't support "Image support"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=111403

Jan Vesely  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 Blocks||99553

--- Comment #1 from Jan Vesely  ---
Thanks, it's interesting to see r600-clover running on loongson.

Image support is a long-standing issue (see #87738).
evergreen class GPUs have also other issues which have a higher priority.

*** This bug has been marked as a duplicate of bug 87738 ***


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=99553
[Bug 99553] Tracker bug for runnning OpenCL applications on Clover
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99553
Bug 99553 depends on bug 111403, which changed state.

Bug 111403 Summary: OpenCL device doesn't  support "Image support"
https://bugs.freedesktop.org/show_bug.cgi?id=111403

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99553

Jan Vesely  changed:

   What|Removed |Added

 Depends on||111403


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=111403
[Bug 111403] OpenCL device doesn't  support "Image support"
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Jan Vesely  changed:

   What|Removed |Added

 CC||shi1986...@126.com

--- Comment #8 from Jan Vesely  ---
*** Bug 111403 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev