Re: [Mesa-dev] [PATCH] teximage: ensure that Tex*SubImage* checks format
Reviewed-by: Marek Olšák
Marek
On Mon, Sep 2, 2019 at 7:40 PM Ilia Mirkin wrote:
> We were previously not doing at least some of the checks. This uses the
> same logic that is used in glTexImage*.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> This seems to leave the Intel CI happy -
>
>
> https://mesa-ci.01.org/imirkin/builds/32/group/63a9f0ea7bb98050796b649e85481845
>
> And fixes things for the teximage-errors updates I sent in for piglit.
>
> src/mesa/main/teximage.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index f90765f40fa..e55e435779f 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -2205,6 +2205,15 @@ texsubimage_error_check(struct gl_context *ctx,
> GLuint dimensions,
>return GL_TRUE;
> }
>
> + if (!texture_formats_agree(texImage->InternalFormat, format)) {
> + _mesa_error(ctx, GL_INVALID_OPERATION,
> + "%s(incompatible internalFormat = %s, format = %s)",
> + callerName,
> + _mesa_enum_to_string(texImage->InternalFormat),
> + _mesa_enum_to_string(format));
> + return GL_TRUE;
> + }
> +
> GLenum internalFormat = _mesa_is_gles(ctx) ?
>oes_float_internal_format(ctx, texImage->InternalFormat, type) :
>texImage->InternalFormat;
> --
> 2.21.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109615] >=19.0.0 fails u_format_test on x86/ppc/ppc64
https://bugs.freedesktop.org/show_bug.cgi?id=109615 erhar...@mailbox.org changed: What|Removed |Added Attachment #143366|0 |1 is obsolete|| --- Comment #12 from erhar...@mailbox.org --- Created attachment 145259 --> https://bugs.freedesktop.org/attachment.cgi?id=145259=edit Gentoo build.log.xz (19.1.5, ppc64) 25/51 mesa:compiler+nir / nir_varsFAIL 0.30 s (killed by signal 6 SIGABRT) 48/51 mesa:gallium / u_format_testFAIL 0.18 s (exit status 1) Ok: 49 Expected Fail: 0 Fail: 2 Unexpected Pass: 0 Skipped: 0 Timeout: 0 On ppc64 really lots of the util_format_* tests fail (see Gentoo build.log.xz, ppc64). -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/2] mesa:amd get device name from kernel
Signed-off-by: Sonny Jiang
---
src/amd/common/ac_gpu_info.c | 72
1 file changed, 64 insertions(+), 8 deletions(-)
diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c
index 5fb1e26376a..c8bc398319e 100644
--- a/src/amd/common/ac_gpu_info.c
+++ b/src/amd/common/ac_gpu_info.c
@@ -106,6 +106,7 @@ bool ac_query_gpu_info(int fd, void *dev_p,
int r, i, j;
amdgpu_device_handle dev = dev_p;
drmDevicePtr devinfo;
+ drmVersionPtr version;
/* Get PCI info. */
r = drmGetDevice2(fd, 0, );
@@ -304,18 +305,73 @@ bool ac_query_gpu_info(int fd, void *dev_p,
info->pci_id = amdinfo->asic_id; /* TODO: is this correct? */
info->vce_harvest_config = amdinfo->vce_harvest_config;
- switch (info->pci_id) {
+ static struct ac_chip_mapping {
+ const char *kernel_name;
+ enum radeon_family family;
+ const char *mesa_name;
+ } table[] = {
+ {"TAHITI", CHIP_TAHITI, "TAHITI"},
+ {"PITCAIRN", CHIP_PITCAIRN, "PITCAIRN"},
+ {"VERDE", CHIP_VERDE, "VERDE"},
+ {"OLAND", CHIP_OLAND, "OLAND"},
+ {"HAINAN", CHIP_HAINAN, "HAINAN"},
+ {"BONAIRE", CHIP_BONAIRE, "BONAIRE"},
+ {"KAVERI", CHIP_KAVERI, "KAVERI"},
+ {"KABINI", CHIP_KABINI, "KABINI"},
+ {"HAWAII", CHIP_HAWAII, "HAWAII"},
+ {"MULLINS", CHIP_KABINI, "KABINI"},
+ {"TOPAZ", CHIP_ICELAND, "ICELAND"},
+ {"TONGA", CHIP_TONGA, "TONGA"},
+ {"FIJI", CHIP_FIJI, "FIJI"},
+ {"CARRIZO", CHIP_CARRIZO, "CARRIZO"},
+ {"STONEY", CHIP_STONEY, "STONEY"},
+ {"POLARIS10", CHIP_POLARIS10, "POLARIS10"},
+ {"POLARIS11", CHIP_POLARIS11, "POLARIS11"},
+ {"POLARIS12", CHIP_POLARIS12, "POLARIS12"},
+ {"VEGAM", CHIP_VEGAM, "VEGAM"},
+ {"VEGA10", CHIP_VEGA10, "VEGA10"},
+ {"VEGA12", CHIP_VEGA12, "VEGA12"},
+ {"VEGA20", CHIP_VEGA20, "VEGA20"},
+ {"RAVEN", CHIP_RAVEN, "RAVEN"},
+ {"ARCTURUS", CHIP_ARCTURUS, "ARCTURUS"},
+ {"RENOIR", CHIP_RENOIR, "RENOIR"},
+ {"NAVI10", CHIP_NAVI10, "NAVI10"},
+ {"NAVI14", CHIP_NAVI14, "NAVI14"},
+ {"NAVI12", CHIP_NAVI12, "NAVI12"}
+ };
+
+ version = drmGetVersion(fd);
+ if (!version) {
+ fprintf(stderr, "amdgpu: drmGetVersion failed.\n");
+ return false;
+ }
+
+ if (version->desc_len && version->desc) {
+ for (unsigned i = 0; i < ARRAY_SIZE(table); i++) {
+ if (strcmp(version->desc, table[i].kernel_name) == 0) {
+ info->family = table[i].family;
+ info->name = table[i].mesa_name;
+ break;
+ }
+ }
+ }
+
+ drmFreeVersion(version);
+
+ if (!info->name) {
+ switch (info->pci_id) {
#define CHIPSET(pci_id, cfamily) \
- case pci_id: \
- info->family = CHIP_##cfamily; \
- info->name = #cfamily; \
- break;
+ case pci_id: \
+ info->family = CHIP_##cfamily; \
+ info->name = #cfamily; \
+ break;
#include "pci_ids/radeonsi_pci_ids.h"
#undef CHIPSET
- default:
- fprintf(stderr, "amdgpu: Invalid PCI ID.\n");
- return false;
+ default:
+ fprintf(stderr, "amdgpu: Invalid PCI ID.\n");
+ return false;
+ }
}
/* Raven2 uses the same PCI IDs as Raven1, but different revision IDs.
*/
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 2/2] loader: driver name radeonsi chosen from kernel name amdgpu
Signed-off-by: Sonny Jiang
---
src/loader/loader.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/loader/loader.c b/src/loader/loader.c
index d8d71c30200..45834aa2082 100644
--- a/src/loader/loader.c
+++ b/src/loader/loader.c
@@ -457,6 +457,14 @@ loader_get_driver_for_fd(int fd)
return driver;
#endif
+ driver = loader_get_kernel_driver_name(fd);
+ if (driver && strcmp(driver, "amdgpu") == 0) {
+ free(driver);
+ driver = strdup("radeonsi");
+ return driver;
+ } else
+ free(driver);
+
if (!loader_get_pci_id_for_fd(fd, _id, _id)) {
driver = loader_get_kernel_driver_name(fd);
if (driver)
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] 19.2 release train going off the rails
What is going on with the 19.2 RCs? I know that we said we would push the releases back a week to let some feature work land, but the last blocker of the feature tracker [0] landed on the 14th and RC1 wasn't until the 20th. Now another two weeks have passed without an RC. RC2 should have been tagged last week and RC3 this week. Can someone take over 19.2 and get this rolling again? Thanks, Matt [0] https://bugs.freedesktop.org/show_bug.cgi?id=111265 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111549] 19.2.0_rc1 fails lp_test_arit, u_format_test, PIPE_FORMAT_DXT5_RGBA (unorm8)
https://bugs.freedesktop.org/show_bug.cgi?id=111549 --- Comment #1 from erhar...@mailbox.org --- I decided to file this as new bug instead of adding my report to #110612, #109615 or #106644. It's a new mesa version, another machine and another arch (apart from #110612). Though feel free to mark it as a duplicate if it makes more sense. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.3.1 fails lp_test_format, lp_test_arit, lp_test_conv
https://bugs.freedesktop.org/show_bug.cgi?id=106644 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=111549 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111549] 19.2.0_rc1 fails lp_test_arit, u_format_test, PIPE_FORMAT_DXT5_RGBA (unorm8)
https://bugs.freedesktop.org/show_bug.cgi?id=111549
Bug ID: 111549
Summary: 19.2.0_rc1 fails lp_test_arit, u_format_test,
PIPE_FORMAT_DXT5_RGBA (unorm8)
Product: Mesa
Version: 19.2
Hardware: x86 (IA32)
OS: All
Status: NEW
Severity: not set
Priority: not set
Component: Mesa core
Assignee: mesa-dev@lists.freedesktop.org
Reporter: erhar...@mailbox.org
QA Contact: mesa-dev@lists.freedesktop.org
Created attachment 145252
--> https://bugs.freedesktop.org/attachment.cgi?id=145252=edit
Gentoo build.log.xz (19.2.0_rc1, x86)
# inxi -b
System:Host: hakla04 Kernel: 5.2.11-gentoo i686 bits: 32 Console: tty 1
Distro: Gentoo Base System release 2.6
Machine: Type: Desktop System: Shuttle product: SN41V20 v: N/A serial: N/A
Mobo: Shuttle model: FN41V20 serial: N/A BIOS: Phoenix v: 6.00 PG
date: 10/29/2004
CPU: Single Core: AMD Athlon XP 2600+ type: UP speed: 2080 MHz
Graphics: Device-1: Advanced Micro Devices [AMD/ATI] RV350 [Radeon
9550/9600/X1050 Series] driver: radeon v: kernel
Display: tty server: X.org 1.20.5 driver: ati,radeon unloaded:
modesetting tty: 132x24
Message: Advanced graphics data unavailable in console for root.
Network: Device-1: NVIDIA nForce2 Ethernet driver: forcedeth
Device-2: Qualcomm Atheros AR5212/5213/2414 Wireless Network Adapter
driver: ath5k
Drives:Local Storage: total: 279.48 GiB used: 6.73 GiB (2.4%)
Info: Processes: 112 Uptime: 5h 44m Memory: 1.96 GiB used: 192.0 MiB
(9.6%) Init: systemd Shell: bash inxi: 3.0.34
# lscpu
Architecture:i686
CPU op-mode(s): 32-bit
Byte Order: Little Endian
Address sizes: 34 bits physical, 32 bits virtual
CPU(s): 1
On-line CPU(s) list: 0
Thread(s) per core: 1
Core(s) per socket: 1
Socket(s): 1
Vendor ID: AuthenticAMD
CPU family: 6
Model: 8
Model name: AMD Athlon(tm) XP 2600+
Stepping:1
CPU MHz: 2079.583
BogoMIPS:4160.46
L1d cache: 64K
L1i cache: 64K
L2 cache:256K
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca
cmov pat pse36 mmx fxsr sse syscall mmxext 3dnowext 3dnow cpuid 3dnowprefetch
vmmcall
[...]
Testing PIPE_FORMAT_DXT5_RGBA (unorm8) ...
round.v1(-0.5): ref = -0, out = -1, precision = -inf bits, FAIL
round.v1(0.5): ref = 0, out = 1, precision = -inf bits, FAIL
round.v4(-0.5): ref = -0, out = -1, precision = -inf bits, FAIL
round.v4(0.5): ref = 0, out = 1, precision = -inf bits, FAIL
[...]
Testing util_format_dxt1_rgb_unpack_rgba_8unorm ...
FAILED: {0x99, 0xb0, 0x8e, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x99, 0xb0, 0x8e,
0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5d, 0x62, 0x89,
0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5d, 0x62, 0x89,
0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0x21, 0x14, 0x84,
0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x21, 0x14, 0x84, 0xff}, {0x21, 0x14, 0x84,
0xff}, {0x99, 0xb0, 0x8e, 0xff} obtained
{0x98, 0xaf, 0x8e, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x98, 0xaf, 0x8e,
0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5c, 0x62, 0x88,
0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5c, 0x62, 0x88,
0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0x21, 0x13, 0x84,
0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x21, 0x13, 0x84, 0xff}, {0x21, 0x13, 0x84,
0xff}, {0x98, 0xaf, 0x8e, 0xff} expected
Testing util_format_dxt1_rgba_unpack_rgba_8unorm ...
FAILED: {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x4e, 0xaa, 0x90,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x29, 0xff, 0xff,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x73, 0x55, 0x21,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90,
0xff}, {0x4e, 0xaa, 0x90, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00,
0x00}, {0x4e, 0xaa, 0x90, 0xff} obtained
{0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x4e, 0xa9, 0x8f,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x29, 0xff, 0xff,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x73, 0x54, 0x21,
0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f,
0xff}, {0x4e, 0xa9, 0x8f, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00,
0x00}, {0x4e, 0xa9, 0x8f, 0xff} expected
Testing util_format_dxt3_rgba_unpack_rgba_8unorm ...
FAILED: {0x6d, 0xc6, 0x96, 0x77}, {0x6d, 0xc6, 0x96, 0xee}, {0x6d, 0xc6, 0x96,
0xaa}, {0x8c, 0xff, 0xb5, 0x44}, {0x6d, 0xc6, 0x96, 0xff}, {0x6d, 0xc6, 0x96,
0x88}, {0x31, 0x55, 0x5a, 0x66}, {0x6d, 0xc6, 0x96, 0x99}, {0x31, 0x55, 0x5a,
0xbb}, {0x31, 0x55, 0x5a, 0x55}, {0x31, 0x55, 0x5a, 0x11}, {0x6d, 0xc6, 0x96,
0xcc}, {0x6d, 0xc6, 0x96, 0xcc}, {0x6d, 0xc6, 0x96, 0x11}, {0x31, 0x55, 0x5a,
[Mesa-dev] [Bug 110612] u_format_test fails on i686
https://bugs.freedesktop.org/show_bug.cgi?id=110612 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=111549 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109615] >=19.0.0 fails u_format_test on x86/ppc/ppc64
https://bugs.freedesktop.org/show_bug.cgi?id=109615 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=111549 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111125] [RADV] Graphic glitches regression in The Witcher 3 with DXVK on AMD Radeon HD7850
https://bugs.freedesktop.org/show_bug.cgi?id=25 --- Comment #6 from Samuel Pitoiset --- What LLVM/Mesa versions are you using (sha1) ? What game settings are you using? Can you eventually record a capture with renderdoc or upload a savegame? Last time (~2 week ago) I tried, I didn't notice anything wrong. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [ANNOUNCE] Mesa 19.1.6
Mesa 19.1.6 is now available. Andres Rodriguez (1): radv: additional query fixes Daniel Schürmann (1): nir/lcssa: handle deref instructions properly Danylo Piliaiev (1): nir/loop_unroll: Prepare loop for unrolling in wrapper_unroll Ian Romanick (2): nir/algrbraic: Don't optimize open-coded bitfield reverse when lowering is enabled intel/compiler: Request bitfield_reverse lowering on pre-Gen7 hardware Ilia Mirkin (1): gallium/vl: use compute preference for all multimedia, not just blit Jonas Ådahl (1): wayland/egl: Ensure correct buffer size when allocating Juan A. Suarez Romero (7): docs: add sha256 checksums for 19.1.5 cherry-ignore: add explicit 19.2 only nominations cherry-ignore: iris: Replace devinfo->gen with GEN_GEN cherry-ignore: iris: Update fast clear colors on Gen9 with direct immediate writes. cherry-ignore: iris: Avoid unnecessary resolves on transfer maps Update version to 19.1.6 docs: add release notes for 19.1.6 Kenneth Graunke (6): iris: Fix broken aux.possible/sampler_usages bitmask handling iris: Drop copy format hacks from copy region based transfer path. iris: Fix large timeout handling in rel2abs() util: Add a _mesa_i64roundevenf() helper. mesa: Fix _mesa_float_to_unorm() on 32-bit systems. intel/compiler: Fix src0/desc setter ordering Marek Olšák (1): radeonsi: fix scratch buffer WAVESIZE setting leading to corruption Paulo Zanoni (1): intel/fs: grab fail_msg from v32 instead of v16 when v32->run_cs fails Pierre-Eric Pelloux-Prayer (1): glsl: replace 'x + (-x)' with constant 0 Tapani Pälli (1): egl: reset blob cache set/get functions on terminate git tag: mesa-19.1.6 https://mesa.freedesktop.org/archive/mesa-19.1.6.tar.xz MD5: 7dbb40b8d10e89bee0a5bfc85350647b mesa-19.1.6.tar.xz SHA1: 6344c54ff6f66c85c1f0a44a96259263163f9969 mesa-19.1.6.tar.xz SHA256: 2a369b7b48545c6486e7e44913ad022daca097c8bd937bf30dcf3f17a94d3496 mesa-19.1.6.tar.xz SHA512: 399ce97a293769893ef9a4a6af1f77c7d835f5405bdbc03bbf9b73e052e4ff3b43dec5dafd6b9fedaaf2c59531aeccaa0f685a8bfdc5719a26c3815fc7f68024 mesa-19.1.6.tar.xz PGP: https://mesa.freedesktop.org/archive/mesa-19.1.6.tar.xz.sig signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109615] >=19.0.0 fails u_format_test on x86/ppc/ppc64
https://bugs.freedesktop.org/show_bug.cgi?id=109615 --- Comment #11 from erhar...@mailbox.org --- Created attachment 145251 --> https://bugs.freedesktop.org/attachment.cgi?id=145251=edit Gentoo build.log.xz (19.1.5, x86) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109615] >=19.0.0 fails u_format_test on x86/ppc/ppc64
https://bugs.freedesktop.org/show_bug.cgi?id=109615 erhar...@mailbox.org changed: What|Removed |Added Version|19.0|19.1 Hardware|PowerPC |All Summary|>=19.0.0 fails |>=19.0.0 fails |u_format_test on ppc64 |u_format_test on ||x86/ppc/ppc64 --- Comment #10 from erhar...@mailbox.org --- Looks like mesa:gallium / u_format_test test failure is not ppc/ppc64 specific. It fails on x86 too. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3] broadcom/vc4: Expand width of dst surface
Just pushed, thanks for the patch. On 3/9/19 4:58, Zhaowei Yuan wrote: Four bytes of src_surf will be compressed into a 32-bits data and stored into dst_surf, and dst_surf is read as z-order,so its width must be aligned to multiples of 8(4x2) before divided by 2. Signed-off-by: Zhaowei Yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111266 --- src/gallium/drivers/vc4/vc4_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_blit.c b/src/gallium/drivers/vc4/vc4_blit.c index d3cc515..d379bcc 100644 --- a/src/gallium/drivers/vc4/vc4_blit.c +++ b/src/gallium/drivers/vc4/vc4_blit.c @@ -360,7 +360,7 @@ vc4_yuv_blit(struct pipe_context *pctx, const struct pipe_blit_info *info) util_blitter_unset_running_flag(vc4->blitter); return false; } -dst_surf->width /= 2; +dst_surf->width = align(dst_surf->width, 8) / 2; if (dst->cpp == 1) dst_surf->height /= 2; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
