Re: Zink MR signoff tags
That's a good idea. Marek On Wed, Oct 5, 2022, 11:22 Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... > > > I kinda like the s-o-b tags but those > > don't require fiddly rebases, just -s in the right place.. > > > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > >Hi, > > >After some vigorous and robust discussion with Erik, we've > > > decided that > > >zink will no longer require any rb/ab/etb tags to be applied to > > > patches in > > >MRs. > > >Following in Turnip's footsteps, any MR that receives sufficient > > > reviewage > > >in gitlab comments can be merged directly with no further action > > >necessary. > > >Mike > > -- > Erik Faye-Lund > Principal Engineer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United > Kingdom > Registered in England & Wales, no. 5513718 > >
Re: Zink MR signoff tags
> > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... I agree, but I don't want to be the one on the hook for the politics if people disagree (as I think some do). > > I kinda like the s-o-b tags but those > > don't require fiddly rebases, just -s in the right place.. > > > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > > Hi, > > > After some vigorous and robust discussion with Erik, we've > > > decided that > > > zink will no longer require any rb/ab/etb tags to be applied to > > > patches in > > > MRs. > > > Following in Turnip's footsteps, any MR that receives sufficient > > > reviewage > > > in gitlab comments can be merged directly with no further action > > > necessary. > > > Mike
Re: Zink MR signoff tags
On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > + for not requiring rb/ab tags ... I think it's time to think about making this change all over Mesa as well. We're deeply in bed with GitLab by now, so I don't think there's a realistic chance that this isn't going to just be duplicate info any time soon... > I kinda like the s-o-b tags but those > don't require fiddly rebases, just -s in the right place.. > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > Hi, > > After some vigorous and robust discussion with Erik, we've > > decided that > > zink will no longer require any rb/ab/etb tags to be applied to > > patches in > > MRs. > > Following in Turnip's footsteps, any MR that receives sufficient > > reviewage > > in gitlab comments can be merged directly with no further action > > necessary. > > Mike -- Erik Faye-Lund Principal Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom Registered in England & Wales, no. 5513718
Re: Zink MR signoff tags
+ for not requiring rb/ab tags ... I kinda like the s-o-b tags but those don't require fiddly rebases, just -s in the right place.. On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: >Hi, >After some vigorous and robust discussion with Erik, we've decided that >zink will no longer require any rb/ab/etb tags to be applied to patches in >MRs. >Following in Turnip's footsteps, any MR that receives sufficient reviewage >in gitlab comments can be merged directly with no further action >necessary. >Mike
