Re: [Mesa-dev] [PATCH 08/14] r600g: initialize SQ_VTX_SEMANTIC_* in the start_cs command buffer

2012-10-12 Thread Andre Maasikas
On Sun, Oct 7, 2012 at 9:08 PM, Marek Olšák  wrote:

> +   r600_store_context_reg_seq(cb, R_028380_SQ_VTX_SEMANTIC_0, 34);
> +   r600_store_value(cb, 0); /* R_028380_SQ_VTX_SEMANTIC_0 */
..
> +   r600_store_value(cb, 0); /* R_0283FC_SQ_VTX_SEMANTIC_31 */

Btw there's also a SQ_VTX_SEMANTIC_CLEAR register which is supposed to
clear all of those via bitmask

Andre
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] r600g: implement two-sided lighting

2012-01-05 Thread Andre Maasikas
On Thu, Jan 5, 2012 at 4:58 PM, Marek Olšák  wrote:
> On Thu, Jan 5, 2012 at 9:13 AM, Vadim Girlin  wrote:
>> Rendering in two-sided mode is performed in separate passes for front and
>> back faces, corresponding colors are selected by semantic ids.
>
> Are you sure that r600 cannot do two-sided color selection in
> hardware? I find it really surprising.
>
Not fully automatically afaik, but i guess one can load facing bit
(FRONT_FACE_ENA?)
into PS and from there on decide which color to use. This would however require
shader rewrite/modification

Andre
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] st/mesa: fix overwriting gl_format with pipe_format since 9d380f48

2011-06-27 Thread Andre Maasikas
fixes assert later on in texcompress2/r600g
---
 src/mesa/state_tracker/st_cb_texture.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_texture.c 
b/src/mesa/state_tracker/st_cb_texture.c
index d52e273..6907cfc 100644
--- a/src/mesa/state_tracker/st_cb_texture.c
+++ b/src/mesa/state_tracker/st_cb_texture.c
@@ -842,7 +842,7 @@ decompress_with_blit(struct gl_context * ctx, GLenum 
target, GLint level,
else {
   /* format translation via floats */
   GLuint row;
-  enum pipe_format format = util_format_linear(dst_texture->format);
+  enum pipe_format pformat = util_format_linear(dst_texture->format);
   for (row = 0; row < height; row++) {
  const GLbitfield transferOps = 0x0; /* bypassed for glGetTexImage() */
  GLfloat rgba[4 * MAX_WIDTH];
@@ -854,7 +854,7 @@ decompress_with_blit(struct gl_context * ctx, GLenum 
target, GLint level,
 
  /* get float[4] rgba row from surface */
  pipe_get_tile_rgba_format(pipe, tex_xfer, 0, row, width, 1,
-   format, rgba);
+   pformat, rgba);
 
  _mesa_pack_rgba_span_float(ctx, width, (GLfloat (*)[4]) rgba, format,
 type, dest, &ctx->Pack, transferOps);
-- 
1.7.4.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] r600c: add evergreen ARL support

2011-01-20 Thread Andre Maasikas
On Tue, Jan 11, 2011 at 5:01 PM, Alberto Milone
 wrote:
> Hi all,
>
> The attached patch adds ARL support in r600c. I followed the code in
> the equivalent commit in r600g:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=98b3f27439ba3a48286ed0d6a4467e5482b41fec
>
> Thanks a lot to Alex Deucher for the help.
+pAsm->D.dst.opcode = EG_OP2_INST_FLT_TO_INT_FLOOR;
+setaddrmode_PVSDST(&(pAsm->D.dst), ADDR_ABSOLUTE);
+pAsm->D.dst.rtype = DST_REG_TEMPORARY;
+pAsm->D.dst.reg = 0;
+pAsm->D.dst.writex = 0;
+pAsm->D.dst.writey = 0;
+pAsm->D.dst.writez = 0;
+pAsm->D.dst.writew = 0;

Are you sure this works - i didn't test or disassemble the output but
i have a feeling that
you need to set correct dst register and write at least something to
it for this instruction.

Andre
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev