[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Marc Di Luzio  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Marc Di Luzio  ---
Marek pushed the fix in commit 7257c171e9eadc05903140cffa26a253f0d0178a
URL:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=7257c171e9eadc05903140cffa26a253f0d0178a

Verified on our end so resolving as fixed.

Cheers all.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Emil Velikov  changed:

   What|Removed |Added

 Blocks||101911


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=101911
[Bug 101911] [TRACKER] Mesa 17.2 release tracker
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #10 from Marc Di Luzio  ---
(In reply to James Legg from comment #6)
> traces from builds of recent Feral titles available on Steam will be
> difficult as we've tried to avoid Steam injecting its overlay in the options
> window when glXSwapBuffer is called, and this also prevents apitrace from
> capturing those calls (which are important for this bug).

Unknown to James at the time we do have a way of disabling this in live builds.

I'll note it here so that someone else who stumbles on a similar issue can know
how to grab a working trace of our options window.

In ~/.local/share/feral-interactive/{GAMENAME}/preferences there'll be a key
called "AvoidSwapInjectionDuringPGOW" that basically does what it says on the
tin - setting it to 0 will prevent our steam overlay avoidance occurring.

If that key doesn't exist then it's an older game without the swap hack.

I've seen the mesa-dev patch mail, thanks Marek!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #9 from James Legg  ---
(In reply to Marek Olšák from comment #7)

That works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Michel Dänzer  changed:

   What|Removed |Added

 CC|mic...@daenzer.net  |

--- Comment #8 from Michel Dänzer  ---
Removing myself from the CC list as I receive updates via the mailing list.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #7 from Marek Olšák  ---
Can you try this:

diff --git a/src/mesa/state_tracker/st_manager.c
b/src/mesa/state_tracker/st_manager.c
index 834bcc9..ede5439 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_manager.c
@@ -642,6 +642,12 @@ st_context_flush(struct st_context_iface *stctxi, unsigned
flags,

if (flags & ST_FLUSH_FRONT)
   st_manager_flush_frontbuffer(st);
+
+   /* Enter st_validate_state in the next draw call to revalidate
+* the framebuffer.
+*/
+   if (flags & ST_FLUSH_END_OF_FRAME)
+  st->gfx_shaders_may_be_dirty = true;
 }

 static boolean

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Christoph Berliner  changed:

   What|Removed |Added

 CC||caberli...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #6 from James Legg  ---
Unfortunately, I've been unable to reproduce the bug while replaying a trace
captured with apitrace (the bug occurs while capturing however). Capturing
traces from builds of recent Feral titles available on Steam will be difficult
as we've tried to avoid Steam injecting its overlay in the options window when
glXSwapBuffer is called, and this also prevents apitrace from capturing those
calls (which are important for this bug).

Forcing Mesa to call st_validate_state in prepare_draw in
state_tracker/st_draw.c, regardless of st->dirty, works around the bug. I'm
still investigating, and trying to make a minimal reproducer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Yurii Kolesnykov  changed:

   What|Removed |Added

 CC||yuriko...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #5 from Marc Di Luzio  ---
(In reply to Marek Olšák from comment #4)
> Michel, why do you need apitrace? You can have all games from Feral because
> you are an AMD employee and long-standing Mesa contributor.

Michel already has an all access key.

We're making a trace/minimum test case though, it'd be good to make sure this
will be caught by tests in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Dennis Schridde  changed:

   What|Removed |Added

 CC||devuran...@gmx.net

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #4 from Marek Olšák  ---
Michel, why do you need apitrace? You can have all games from Feral because you
are an AMD employee and long-standing Mesa contributor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Johan Gardhage  changed:

   What|Removed |Added

 CC||johan.gardh...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #3 from Michel Dänzer  ---
(In reply to James Legg from comment #1)
> glDrawElementsBaseVertex doesn't seem to validate the framebuffer in
> the same way as glClear, [...]

That sounds like the core of the problem.

Can you create an apitrace demonstrating the problem?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Michel Dänzer  changed:

   What|Removed |Added

 Attachment #132819|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #2 from Tim Writer  ---
 I'm hosting meetings this week. E-mail responses will be delayed. Regards,
Tim

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

--- Comment #1 from James Legg  ---
In loader_dri3_swap_buffers_msc, dri3_find_back increments the index used for
selecting the back buffer (draw->cur_back) to the second (index 1) out of two
buffer slots because the buffer in the first slot (index 0) is busy. When there
is no buffer in the now selected slot, loader_dri3_swap_buffers_msc fails
without swapping. This was introduced in
81fb1547772d42c527318837d4207ecdb6899e5d, previously it would have reused the
busy buffer and swapped something, even if it resulted in tearing.

When a clear occurs, dri3_get_buffer is used to create a buffer, which also
uses dri3_find_back, but this stays on the slot index for the not yet created
buffer. However, the options window is not using glClear. It does exactly one
draw, with glDrawElementsBaseVertex, that covers the whole window.
glDrawElementsBaseVertex doesn't seem to validate the framebuffer in the same
way as glClear, so it is stuck on the index with uncreated back buffer despite
repeatedly drawing and swapping.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Marc Di Luzio  changed:

   What|Removed |Added

 CC||mdiluzio@feralinteractive.c
   ||om, mic...@daenzer.net,
   ||thellst...@vmware.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101867

Bug ID: 101867
   Summary: Launch options window renders black in Feral Games in
current Mesa trunk
   Product: Mesa
   Version: git
  Hardware: Other
OS: Linux (All)
Status: NEW
  Severity: major
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: mdilu...@feralinteractive.com
QA Contact: mesa-dev@lists.freedesktop.org

Using Mesa git, currently all Feral games with a pre-game options window render
a permanent black frame and are un-playable without settings hacks to skip the
options.

Tested primarily on an RX 470, but seen on other radeon cards as well.

Issue is caused by commit 81fb1547772d42c527318837d4207ecdb6899e5d
URL:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=81fb1547772d42c527318837d4207ecdb6899e5d

Logging this now in case a fellow developer is already investigating a similar
issue and wants to chime in. We'll be attempting to find the root cause, but
additional help would be appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev