[Mesa-dev] [Bug 102466] gallium/auxiliary/util/u_cpu_detect.c: 2 * bad condition ?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102466

GitLab Migration User  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEW |RESOLVED

--- Comment #4 from GitLab Migration User  ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1017.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102466] gallium/auxiliary/util/u_cpu_detect.c: 2 * bad condition ?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102466

--- Comment #3 from Emil Velikov  ---
(In reply to dcb314 from comment #2)

> I think you missed the point. Any expression ANDed with 6 will be != 6.
> 
How about when xgetbv() returns say 6 or 7 (amongst others)?

Also keep in mind that the file depends on multiple defines. Based on a _very_
old play with Mesa + cppcheck, the latter was tripping quite often, producing
false positives.

The OS/compiler request does not sound that unreasonable ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102466] gallium/auxiliary/util/u_cpu_detect.c: 2 * bad condition ?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102466

--- Comment #2 from dcb...@hotmail.com ---
(In reply to Gert Wollny from comment #1)
> It would be helpful to add on which OS and with which compiler and for what
> architecture you were compiling mesa, because depending on the build
> environment xgetbv() may simply return 0 as a fallback (see lines 259-277 in
> the same file).

I think you missed the point. Any expression ANDed with 6 will be != 6.

OS, compiler and arch independent. For the record, Linux, gcc and x86_64,
although I used a static analyser called cppcheck to find this bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102466] gallium/auxiliary/util/u_cpu_detect.c: 2 * bad condition ?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102466

--- Comment #1 from Gert Wollny  ---
It would be helpful to add on which OS and with which compiler and for what
architecture you were compiling mesa, because depending on the build
environment xgetbv() may simply return 0 as a fallback (see lines 259-277 in
the same file).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 102466] gallium/auxiliary/util/u_cpu_detect.c: 2 * bad condition ?

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=102466

Bug ID: 102466
   Summary: gallium/auxiliary/util/u_cpu_detect.c: 2 * bad
condition ?
   Product: Mesa
   Version: 17.2
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Mesa core
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: dcb...@hotmail.com
QA Contact: mesa-dev@lists.freedesktop.org

1.

mesa-17.1.8/src/gallium/auxiliary/util/u_cpu_detect.c:370]: (style) Condition
'(xgetbv()&6)==6' is always false

Source code is

  ((xgetbv() & 6) == 6);// XMM & YMM

2.

mesa-17.1.8/src/gallium/auxiliary/util/u_cpu_detect.c:394]: (style) Condition
'(xgetbv()&6)==6' is always false

Duplicate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev