[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

Turo Lamminen  changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|REOPENED|RESOLVED

--- Comment #8 from Turo Lamminen  ---
Looks like this might have been my bug after all.

I was specifying subpass dependencies with separate VkSubpassDependency for
color and depthstencil attachments but the same srcSubPass and dstSubPass. The
idea was that the driver would be able to use finer-grained barriers if it
wanted. The other drivers treated these as union of dependencies, radv was only
taking the last one and missing some color writes. ORing everything together
makes this work.

In case my explanation was unclear here is the fix:
https://github.com/turol/smaaDemo/commit/34a79f076ebab7a661d8705c4adcb2d5b3258281

The Vulkan spec doesn't seem clear on whether this is allowed or not. I think
in theory it would be useful to specify for example that depth test/write can
proceed differently from color write.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

Turo Lamminen  changed:

   What|Removed |Added

 Attachment #138108|0   |1
is obsolete||

--- Comment #7 from Turo Lamminen  ---
Created attachment 138130
  --> https://bugs.freedesktop.org/attachment.cgi?id=138130=edit
vktrace trace from the fixed app

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

Turo Lamminen  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---

--- Comment #6 from Turo Lamminen  ---
Looks like there's already a validation layer issue about this:
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1656. I
added my report there.

The bad layouts were caused by a bug in the program where it failed to
correctly track the current layout. I fixed this but the artifacts still occur
so reopening.

If debugging in RenderDoc you can pass "--trace" command line parameter and
smaaDemo will set readable names for the various objects. Whether this helps or
not is of course up to preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

--- Comment #5 from Jason Ekstrand  ---
I recommend you file a bug against the validation layers as at least the first
of the two comments Bas made should be invalid.  The second is valid but does
not do what you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

Bas Nieuwenhuizen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #4 from Bas Nieuwenhuizen  ---
As discussed on #dri-devel, the example application contains several layout
issues such as

1) using UNDEFINED as the source layout for the vkCmdResolveImage.
2) using UNDEFINED as the initial layout for the second renderpass when you
want to preserve contents.

These caused issues with MSAA on a Vega. I am not completely certain that
fixing these will fix SI. Please fix these and then take a look in renderdoc on
where it is going wrong.

If you still suspect the driver after that we can take another look.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

--- Comment #3 from Turo Lamminen  ---
Created attachment 138108
  --> https://bugs.freedesktop.org/attachment.cgi?id=138108=edit
vktrace trace

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

--- Comment #2 from Turo Lamminen  ---
Created attachment 138107
  --> https://bugs.freedesktop.org/attachment.cgi?id=138107=edit
dmesg output

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

--- Comment #1 from Turo Lamminen  ---
Created attachment 138106
  --> https://bugs.freedesktop.org/attachment.cgi?id=138106=edit
vulkaninfo output

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105506] Vulkan MSAA is broken on SI

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105506

Bug ID: 105506
   Summary: Vulkan MSAA is broken on SI
   Product: Mesa
   Version: git
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/Vulkan/radeon
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: t...@alternativegames.net
QA Contact: mesa-dev@lists.freedesktop.org

Created attachment 138105
  --> https://bugs.freedesktop.org/attachment.cgi?id=138105=edit
Screenshot

MSAA is broken on Vulkan with SI card (Pitcairn) causing graphical artefacts.
All MSAA modes are affected. OpenGL works. The same code works on Windows with
AMD's driver and on Nvidia GPU with their proprietary drivers. No warnings from
Vulkan validation layers. Broken versions are 17.3.6 (Debian package),
18.0.0rc4 (likewise) and master fcf267ba087dd00c48ceaf9277424dac079f9319
(self-built, with LLVM 6.0). Kernel is 4.14.17 from Debian testing.

The test program is here:
https://github.com/turol/smaaDemo
Use command line parameters "-m msaa -q 8" to get directly to the broken
effect.

#103999 is possibly related but I'm using RGBA8srgb instead of RG32F.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev