[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99154

Kenneth Graunke  changed:

   What|Removed |Added

   Assignee|mesa-dev@lists.freedesktop. |kenn...@whitecape.org
   |org |
 Status|NEW |ASSIGNED

--- Comment #1 from Kenneth Graunke  ---
Patch on list:
https://lists.freedesktop.org/archives/mesa-dev/2016-December/138613.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99154

Bug ID: 99154
   Summary: Link time error when using multiple builtin functions
   Product: Mesa
   Version: git
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: glsl-compiler
  Assignee: mesa-dev@lists.freedesktop.org
  Reporter: niels_...@salscheider-online.de
QA Contact: intel-3d-b...@lists.freedesktop.org

Created attachment 128570
  --> https://bugs.freedesktop.org/attachment.cgi?id=128570=edit
Simple test case

When using multiple builtin functions, linking of a shader can fail if
temporary variables of the GLSL compiler collide.

builtin_builder::binop creates variables named "x" and "y" for the parameters
of builtin functions. Later, ir_call::generate_inline inlines the call to the
builtins. It clones the variables (without changing the name) and assigns the
function inputs to them.

This can cause a collision of variable names, e. g. when using multiple builtin
functions with parameters of different types. The attached test case can be
used to reproduce the problem.

I can work around the problem by adding a sequence number and possibly a prefix
to the variable names but I am not sure if that is the correct solution.

Thanks to imirkin and robclark for helping me to figure this out on IRC.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=99154

Niels Ole Salscheider  changed:

   What|Removed |Added

 CC||niels_ole@salscheider-onlin
   ||e.de

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev