Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/nine: Ignore window size if error
On 28/02/2019 12:54, Emil Velikov wrote:
On Wed, 27 Feb 2019 at 22:49, Axel Davy wrote:
Check GetWindowInfo and ignore the computed sizes
if there is an error.
Fixes the regression caused by:
commit 2318ca68bbeb4fa6e21a4d8c650cec3f64246596
"st/nine: Handle window resize when a presentation buffer is used"
when using old wine gallium nine patches
Related issues:
https://github.com/iXit/Mesa-3D/issues/331
https://github.com/iXit/Mesa-3D/issues/332
Fixes also crash at window destruction.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Axel Davy
---
Nittiest of nits: the following takes 1/3 the cognitive effort.
Nittiest of nits do matter. Thank you for the suggestion, I shall take
replace the commit message with your suggestion !
Check GetWindowInfo and ignore the computed sizes if there is an error.
Fixes a regression caused by earlier commit when using old wine gallium
nine patches.
Should also address a crash at window destruction.
Related issues:
https://github.com/iXit/Mesa-3D/issues/331
https://github.com/iXit/Mesa-3D/issues/332
Cc: mesa-sta...@lists.freedesktop.org
Fixes: 2318ca68bbe ("st/nine: Handle window resize when a presentation
buffer is used")
Signed-off-by: Axel Davy
HTH
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/nine: Ignore window size if error
On Wed, 27 Feb 2019 at 22:49, Axel Davy wrote:
>
> Check GetWindowInfo and ignore the computed sizes
> if there is an error.
>
> Fixes the regression caused by:
> commit 2318ca68bbeb4fa6e21a4d8c650cec3f64246596
> "st/nine: Handle window resize when a presentation buffer is used"
> when using old wine gallium nine patches
>
> Related issues:
> https://github.com/iXit/Mesa-3D/issues/331
> https://github.com/iXit/Mesa-3D/issues/332
>
> Fixes also crash at window destruction.
>
> Cc: mesa-sta...@lists.freedesktop.org
>
> Signed-off-by: Axel Davy
> ---
Nittiest of nits: the following takes 1/3 the cognitive effort.
Check GetWindowInfo and ignore the computed sizes if there is an error.
Fixes a regression caused by earlier commit when using old wine gallium
nine patches.
Should also address a crash at window destruction.
Related issues:
https://github.com/iXit/Mesa-3D/issues/331
https://github.com/iXit/Mesa-3D/issues/332
Cc: mesa-sta...@lists.freedesktop.org
Fixes: 2318ca68bbe ("st/nine: Handle window resize when a presentation
buffer is used")
Signed-off-by: Axel Davy
HTH
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
