Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] glsl: TCS outputs can not be transform feedback candidates on GLES

2019-03-15 Thread Emil Velikov
On Thu, 14 Mar 2019 at 10:41, Chema Casanova  wrote:
>
> On 13/3/19 23:17, Emil Velikov wrote:
> > Hi Jose,
> >
> > On Wed, 21 Nov 2018 at 18:45, Jose Maria Casanova Crespo
> >  wrote:
> >>
> >> Fixes: 
> >> KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
> >>
> > This and the follow-up patch "glsl: fix recording of variables for XFB
> > in TCS shaders" are explicitly marked as 19.0 only.
> > As such I've omitted them from 18.3, let me know if you prefer to include 
> > them.
>
> I've checked and both patches apply clearly on 18.3 and they fix the CTS
> failure there. So I think it is useful to include them.
>
> Thanks for checking,
>
Ack, picked them up.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] glsl: TCS outputs can not be transform feedback candidates on GLES

2019-03-14 Thread Chema Casanova
On 13/3/19 23:17, Emil Velikov wrote:
> Hi Jose,
> 
> On Wed, 21 Nov 2018 at 18:45, Jose Maria Casanova Crespo
>  wrote:
>>
>> Fixes: 
>> KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
>>
> This and the follow-up patch "glsl: fix recording of variables for XFB
> in TCS shaders" are explicitly marked as 19.0 only.
> As such I've omitted them from 18.3, let me know if you prefer to include 
> them.

I've checked and both patches apply clearly on 18.3 and they fix the CTS
failure there. So I think it is useful to include them.

Thanks for checking,

Chema
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] glsl: TCS outputs can not be transform feedback candidates on GLES

2019-03-13 Thread Emil Velikov
Hi Jose,

On Wed, 21 Nov 2018 at 18:45, Jose Maria Casanova Crespo
 wrote:
>
> Fixes: 
> KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
>
This and the follow-up patch "glsl: fix recording of variables for XFB
in TCS shaders" are explicitly marked as 19.0 only.
As such I've omitted them from 18.3, let me know if you prefer to include them.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev