Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Rob Herring 
On Thu, Jun 8, 2017 at 3:06 AM, Tapani Pälli  wrote:
>
>
> On 06/08/2017 11:03 AM, Alex Smith wrote:
>>
>> Oops, sorry about that!
>
>
> my bad, for me it actually compiles fine even with the ')' but there is
> maybe some differences between mine and Rob's way of building Mesa

I think it's because I'm on AOSP master which changed to through an
error when .h files are in LOCAL_SRC_FILES. You should see a warning
though in N I think.

Rob
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Tapani Pälli 



On 06/08/2017 11:03 AM, Alex Smith wrote:

Oops, sorry about that!


my bad, for me it actually compiles fine even with the ')' but there is 
maybe some differences between mine and Rob's way of building Mesa




Alex

On 8 June 2017 at 03:00, Rob Herring > wrote:


Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util") broke the Android build with the following error:

build/core/binary.mk:1427 : error:
external/mesa3d/src/vulkan/Android.mk: libmesa_vulkan_util: Unused
source files: util/vk_util.h).

Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util")
Cc: Tapani Pälli >
Cc: Alex Smith >
Signed-off-by: Rob Herring >
---
  src/vulkan/Android.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk
index 8eb42ece8786..e19a33dd4f9f 100644
--- a/src/vulkan/Android.mk
+++ b/src/vulkan/Android.mk
@@ -41,7 +41,7 @@ LOCAL_C_INCLUDES := \
  LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, \
 $(VULKAN_UTIL_GENERATED_FILES))

-LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES))
+LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES)

  vulkan_api_xml = $(MESA_TOP)/src/vulkan/registry/vk.xml

--
2.11.0



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-08 Thread Alex Smith 
Oops, sorry about that!

Alex

On 8 June 2017 at 03:00, Rob Herring  wrote:

> Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
> src/vulkan/util") broke the Android build with the following error:
>
> build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk:
> libmesa_vulkan_util: Unused source files: util/vk_util.h).
>
> Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
> src/vulkan/util")
> Cc: Tapani Pälli 
> Cc: Alex Smith 
> Signed-off-by: Rob Herring 
> ---
>  src/vulkan/Android.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk
> index 8eb42ece8786..e19a33dd4f9f 100644
> --- a/src/vulkan/Android.mk
> +++ b/src/vulkan/Android.mk
> @@ -41,7 +41,7 @@ LOCAL_C_INCLUDES := \
>  LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, \
> $(VULKAN_UTIL_GENERATED_FILES))
>
> -LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES))
> +LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES)
>
>  vulkan_api_xml = $(MESA_TOP)/src/vulkan/registry/vk.xml
>
> --
> 2.11.0
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-07 Thread Tapani Pälli 

argh, how did that get there ...

Reviewed-by: Tapani Pälli 

On 06/08/2017 05:00 AM, Rob Herring wrote:

Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util") broke the Android build with the following error:

build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk: 
libmesa_vulkan_util: Unused source files: util/vk_util.h).

Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util")
Cc: Tapani Pälli 
Cc: Alex Smith 
Signed-off-by: Rob Herring 
---
  src/vulkan/Android.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk
index 8eb42ece8786..e19a33dd4f9f 100644
--- a/src/vulkan/Android.mk
+++ b/src/vulkan/Android.mk
@@ -41,7 +41,7 @@ LOCAL_C_INCLUDES := \
  LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, \
$(VULKAN_UTIL_GENERATED_FILES))
  
-LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES))

+LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES)
  
  vulkan_api_xml = $(MESA_TOP)/src/vulkan/registry/vk.xml
  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

2017-06-07 Thread Rob Herring 
Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
src/vulkan/util") broke the Android build with the following error:

build/core/binary.mk:1427: error: external/mesa3d/src/vulkan/Android.mk: 
libmesa_vulkan_util: Unused source files: util/vk_util.h).

Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to src/vulkan/util")
Cc: Tapani Pälli 
Cc: Alex Smith 
Signed-off-by: Rob Herring 
---
 src/vulkan/Android.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk
index 8eb42ece8786..e19a33dd4f9f 100644
--- a/src/vulkan/Android.mk
+++ b/src/vulkan/Android.mk
@@ -41,7 +41,7 @@ LOCAL_C_INCLUDES := \
 LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, \
$(VULKAN_UTIL_GENERATED_FILES))
 
-LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES))
+LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES)
 
 vulkan_api_xml = $(MESA_TOP)/src/vulkan/registry/vk.xml
 
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev