Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On Thursday 23 April 2015 23:04:22 Jose Fonseca wrote: On 23/04/15 18:46, Pali Rohár wrote: On Monday 13 April 2015 22:35:03 Pali Rohár wrote: On Monday 13 April 2015 22:32:10 Brian Paul wrote: On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit. fre edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683 d935 40c64164ad337ce454d=AwIFaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXV eAw- YihVMNtXt-uEsr=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbom Vj8 m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmydss=lvCbo4YT BIN1 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_muge= which removes #include string.h from glapi_priv.h file. What configure or autogen.sh options did you use? I haven't seen this on any of my systems. -Brian If it helps here is full build log with error message: https://urldefense.proofpoint.com/v2/url?u=https-3A__launch padlibrarian.net_203127592_buildlog-5Fubuntu-2Dprecise-2Di3 86.mesa-5F10.6.0-2Dgit201504131208.36ceda4-7Eubuntu12.04.1- 5FBUILDING.txt.gzd=AwIDaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- YihVMNtXt-uEsr=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE m=APogfpCq-vsnsGAuf6IWkOzXLZ4dY83aVZTYvsJsdtIs=6SlGiWJZZs OV1qK8l0vLE5nJaRUhJn0DTwSw2hQdbXAe= Its compiled on Ubuntu 12.04 Precise box. Hello, this problem is still not fixed and compilation from git still failing... Please can you look at it and include missing string.h file? It is obvious problem in mesa and I also found which commit broke compilation... I pushed your fix. Sorry for the delay. It wasn't intentional. There's so much traffic in Mesa, it's easy for things to fall through cracks. Jose Thanks. Now compilation from git working fine... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On Monday 13 April 2015 22:35:03 Pali Rohár wrote: On Monday 13 April 2015 22:32:10 Brian Paul wrote: On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.fre edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683d935 40c64164ad337ce454d=AwIFaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- YihVMNtXt-uEsr=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8 m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmydss=lvCbo4YTBIN1 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_muge= which removes #include string.h from glapi_priv.h file. What configure or autogen.sh options did you use? I haven't seen this on any of my systems. -Brian If it helps here is full build log with error message: https://launchpadlibrarian.net/203127592/buildlog_ubuntu-precise-i386.mesa_10.6.0-git201504131208.36ceda4~ubuntu12.04.1_BUILDING.txt.gz Its compiled on Ubuntu 12.04 Precise box. Hello, this problem is still not fixed and compilation from git still failing... Please can you look at it and include missing string.h file? It is obvious problem in mesa and I also found which commit broke compilation... -- Pali Rohár pali.ro...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On 23/04/15 18:46, Pali Rohár wrote: On Monday 13 April 2015 22:35:03 Pali Rohár wrote: On Monday 13 April 2015 22:32:10 Brian Paul wrote: On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.fre edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683d935 40c64164ad337ce454d=AwIFaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- YihVMNtXt-uEsr=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8 m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmydss=lvCbo4YTBIN1 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_muge= which removes #include string.h from glapi_priv.h file. What configure or autogen.sh options did you use? I haven't seen this on any of my systems. -Brian If it helps here is full build log with error message: https://urldefense.proofpoint.com/v2/url?u=https-3A__launchpadlibrarian.net_203127592_buildlog-5Fubuntu-2Dprecise-2Di386.mesa-5F10.6.0-2Dgit201504131208.36ceda4-7Eubuntu12.04.1-5FBUILDING.txt.gzd=AwIDaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEsr=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzEm=APogfpCq-vsnsGAuf6IWkOzXLZ4dY83aVZTYvsJsdtIs=6SlGiWJZZsOV1qK8l0vLE5nJaRUhJn0DTwSw2hQdbXAe= Its compiled on Ubuntu 12.04 Precise box. Hello, this problem is still not fixed and compilation from git still failing... Please can you look at it and include missing string.h file? It is obvious problem in mesa and I also found which commit broke compilation... I pushed your fix. Sorry for the delay. It wasn't intentional. There's so much traffic in Mesa, it's easy for things to fall through cracks. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fbbd60c1da4467683d93540c64164ad337ce454 which removes #include string.h from glapi_priv.h file. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683d93540c64164ad337ce454d=AwIFaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEsr=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmydss=lvCbo4YTBIN15kh-3Wu1-rQAsyFcdKtCE-Ywc4u_muge= which removes #include string.h from glapi_priv.h file. What configure or autogen.sh options did you use? I haven't seen this on any of my systems. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration
On Monday 13 April 2015 22:32:10 Brian Paul wrote: On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@ #include glapi/glapi_priv.h #include u_execmem.h +#include string.h #ifdef USE_X86_ASM This problem is caused by commit: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.fre edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683d935 40c64164ad337ce454d=AwIFaQc=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- YihVMNtXt-uEsr=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8 m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmydss=lvCbo4YTBIN1 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_muge= which removes #include string.h from glapi_priv.h file. What configure or autogen.sh options did you use? I haven't seen this on any of my systems. -Brian If it helps here is full build log with error message: https://launchpadlibrarian.net/203127592/buildlog_ubuntu-precise-i386.mesa_10.6.0-git201504131208.36ceda4~ubuntu12.04.1_BUILDING.txt.gz Its compiled on Ubuntu 12.04 Precise box. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
