Re: [Mesa-dev] [PATCH] android: avoid using libdrm with host modules

[Chih-Wei Huang]

2016-11-02 23:42 GMT+08:00 Emil Velikov :
>
> Skimming through the outstanding patches for yours [1] I've tagged
> some [2] as superseded since the functionality has already landed. Let
> me know the status of the rest when you've got the chance.

Sorry I forgot to reply.

> [1] https://patchwork.freedesktop.org/project/mesa/patches/?submitter=15395
>
> [2]
> https://patchwork.freedesktop.org/patch/52321/
> https://patchwork.freedesktop.org/patch/52323/
> https://patchwork.freedesktop.org/patch/52337/

Yes, they are superseded and unnecessary.

> https://patchwork.freedesktop.org/patch/61946/

Not sure about this now.
I guess it's also unnecessary.


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: avoid using libdrm with host modules

[Emil Velikov]

On 28 October 2016 at 10:54, Chih-Wei Huang  wrote:
> Note LOCAL_CFLAGS and LOCAL_SHARED_LIBRARIES in Android.common.mk
> are used by both host and target modules. However, commit 112e988
> moved libdrm related flags to common. It causes the errors like:
>
> error: 
> 'out/host/linux-x86/obj32/SHARED_LIBRARIES/libdrm_intermediates/export_includes',
>  needed by 
> 'out/host/linux-x86/obj32/EXECUTABLES/mesa_gen_matypes_intermediates/import_includes',
>  missing and no known rule to make it
>
> No reason to use libdrm with host modules.
>
> Signed-off-by: Chih-Wei Huang 
Thanks! Pushed to master - it'll land in 13.0 in due time.

Skimming through the outstanding patches for yours [1] I've tagged
some [2] as superseded since the functionality has already landed. Let
me know the status of the rest when you've got the chance.

-Emil

[1] https://patchwork.freedesktop.org/project/mesa/patches/?submitter=15395

[2]
https://patchwork.freedesktop.org/patch/52321/
https://patchwork.freedesktop.org/patch/52323/
https://patchwork.freedesktop.org/patch/52337/
https://patchwork.freedesktop.org/patch/61946/
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] android: avoid using libdrm with host modules

[Chih-Wei Huang]

Note LOCAL_CFLAGS and LOCAL_SHARED_LIBRARIES in Android.common.mk
are used by both host and target modules. However, commit 112e988
moved libdrm related flags to common. It causes the errors like:

error: 
'out/host/linux-x86/obj32/SHARED_LIBRARIES/libdrm_intermediates/export_includes',
 needed by 
'out/host/linux-x86/obj32/EXECUTABLES/mesa_gen_matypes_intermediates/import_includes',
 missing and no known rule to make it

No reason to use libdrm with host modules.

Signed-off-by: Chih-Wei Huang 
---
 Android.common.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Android.common.mk b/Android.common.mk
index dee22da..9f64c22 100644
--- a/Android.common.mk
+++ b/Android.common.mk
@@ -82,11 +82,13 @@ LOCAL_CFLAGS += \
-D__STDC_LIMIT_MACROS
 endif
 
+ifneq ($(LOCAL_IS_HOST_MODULE),true)
 # add libdrm if there are hardware drivers
 ifneq ($(filter-out swrast,$(MESA_GPU_DRIVERS)),)
 LOCAL_CFLAGS += -DHAVE_LIBDRM
 LOCAL_SHARED_LIBRARIES += libdrm
 endif
+endif
 
 LOCAL_CPPFLAGS += \
$(if $(filter true,$(MESA_LOLLIPOP_BUILD)),-D_USING_LIBCXX) \
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev