Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-03 Thread Bas Nieuwenhuizen 
Reviewed-by: Bas Nieuwenhuizen 
On Fri, Nov 2, 2018 at 3:54 PM Eric Engestrom  wrote:
>
> On Friday, 2018-11-02 13:38:53 +0100, Mauro Rossi wrote:
> > Hi all,
> > could somebody provide Reviewed-by in order to apply in mesa-dev and
> > avoid trivial building error?
>
> Not an expert on Android.mk, but this looks reasonable, and adding that
> dep is definitely right, so:
> Reviewed-by: Eric Engestrom 
>
> > Thanks
> >
> > Mauro
> > On Tue, Oct 30, 2018 at 10:42 PM Mauro Rossi  wrote:
> > >
> > > libmesa_git_sha1 whole static dependency is added to get git_sha1.h header
> > > and avoid following building error:
> > >
> > > external/mesa/src/amd/vulkan/radv_device.c:46:10:
> > > fatal error: 'git_sha1.h' file not found
> > >  ^
> > > 1 error generated.
> > >
> > > Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_properties.")
> > > Signed-off-by: Mauro Rossi 
> > > ---
> > >  src/amd/vulkan/Android.mk | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
> > > index 51b03561fa..9574bf54e5 100644
> > > --- a/src/amd/vulkan/Android.mk
> > > +++ b/src/amd/vulkan/Android.mk
> > > @@ -74,7 +74,8 @@ LOCAL_C_INCLUDES := \
> > > $(call 
> > > generated-sources-dir-for,STATIC_LIBRARIES,libmesa_vulkan_util,,)/util
> > >
> > >  LOCAL_WHOLE_STATIC_LIBRARIES := \
> > > -   libmesa_vulkan_util
> > > +   libmesa_vulkan_util \
> > > +   libmesa_git_sha1
> > >
> > >  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.c
> > >  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.h
> > > --
> > > 2.19.1
> > >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-02 Thread Eric Engestrom 
On Friday, 2018-11-02 13:38:53 +0100, Mauro Rossi wrote:
> Hi all,
> could somebody provide Reviewed-by in order to apply in mesa-dev and
> avoid trivial building error?

Not an expert on Android.mk, but this looks reasonable, and adding that
dep is definitely right, so:
Reviewed-by: Eric Engestrom 

> Thanks
> 
> Mauro
> On Tue, Oct 30, 2018 at 10:42 PM Mauro Rossi  wrote:
> >
> > libmesa_git_sha1 whole static dependency is added to get git_sha1.h header
> > and avoid following building error:
> >
> > external/mesa/src/amd/vulkan/radv_device.c:46:10:
> > fatal error: 'git_sha1.h' file not found
> >  ^
> > 1 error generated.
> >
> > Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_properties.")
> > Signed-off-by: Mauro Rossi 
> > ---
> >  src/amd/vulkan/Android.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
> > index 51b03561fa..9574bf54e5 100644
> > --- a/src/amd/vulkan/Android.mk
> > +++ b/src/amd/vulkan/Android.mk
> > @@ -74,7 +74,8 @@ LOCAL_C_INCLUDES := \
> > $(call 
> > generated-sources-dir-for,STATIC_LIBRARIES,libmesa_vulkan_util,,)/util
> >
> >  LOCAL_WHOLE_STATIC_LIBRARIES := \
> > -   libmesa_vulkan_util
> > +   libmesa_vulkan_util \
> > +   libmesa_git_sha1
> >
> >  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.c
> >  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.h
> > --
> > 2.19.1
> >
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-11-02 Thread Mauro Rossi 
Hi all,
could somebody provide Reviewed-by in order to apply in mesa-dev and
avoid trivial building error?
Thanks

Mauro
On Tue, Oct 30, 2018 at 10:42 PM Mauro Rossi  wrote:
>
> libmesa_git_sha1 whole static dependency is added to get git_sha1.h header
> and avoid following building error:
>
> external/mesa/src/amd/vulkan/radv_device.c:46:10:
> fatal error: 'git_sha1.h' file not found
>  ^
> 1 error generated.
>
> Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_properties.")
> Signed-off-by: Mauro Rossi 
> ---
>  src/amd/vulkan/Android.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
> index 51b03561fa..9574bf54e5 100644
> --- a/src/amd/vulkan/Android.mk
> +++ b/src/amd/vulkan/Android.mk
> @@ -74,7 +74,8 @@ LOCAL_C_INCLUDES := \
> $(call 
> generated-sources-dir-for,STATIC_LIBRARIES,libmesa_vulkan_util,,)/util
>
>  LOCAL_WHOLE_STATIC_LIBRARIES := \
> -   libmesa_vulkan_util
> +   libmesa_vulkan_util \
> +   libmesa_git_sha1
>
>  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.c
>  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.h
> --
> 2.19.1
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-10-31 Thread Samuel Pitoiset 

Acked-by: Samuel Pitoiset 

On 10/30/18 10:41 PM, Mauro Rossi wrote:

libmesa_git_sha1 whole static dependency is added to get git_sha1.h header
and avoid following building error:

external/mesa/src/amd/vulkan/radv_device.c:46:10:
fatal error: 'git_sha1.h' file not found
  ^
1 error generated.

Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_properties.")
Signed-off-by: Mauro Rossi 
---
  src/amd/vulkan/Android.mk | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
index 51b03561fa..9574bf54e5 100644
--- a/src/amd/vulkan/Android.mk
+++ b/src/amd/vulkan/Android.mk
@@ -74,7 +74,8 @@ LOCAL_C_INCLUDES := \
$(call 
generated-sources-dir-for,STATIC_LIBRARIES,libmesa_vulkan_util,,)/util
  
  LOCAL_WHOLE_STATIC_LIBRARIES := \

-   libmesa_vulkan_util
+   libmesa_vulkan_util \
+   libmesa_git_sha1
  
  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.c

  LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.h


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

2018-10-30 Thread Mauro Rossi 
libmesa_git_sha1 whole static dependency is added to get git_sha1.h header
and avoid following building error:

external/mesa/src/amd/vulkan/radv_device.c:46:10:
fatal error: 'git_sha1.h' file not found
 ^
1 error generated.

Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_properties.")
Signed-off-by: Mauro Rossi 
---
 src/amd/vulkan/Android.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk
index 51b03561fa..9574bf54e5 100644
--- a/src/amd/vulkan/Android.mk
+++ b/src/amd/vulkan/Android.mk
@@ -74,7 +74,8 @@ LOCAL_C_INCLUDES := \
$(call 
generated-sources-dir-for,STATIC_LIBRARIES,libmesa_vulkan_util,,)/util
 
 LOCAL_WHOLE_STATIC_LIBRARIES := \
-   libmesa_vulkan_util
+   libmesa_vulkan_util \
+   libmesa_git_sha1
 
 LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.c
 LOCAL_GENERATED_SOURCES += $(intermediates)/radv_entrypoints.h
-- 
2.19.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev