Re: [Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

2017-06-22 Thread Chad Versace
On Thu 22 Jun 2017, Jason Ekstrand wrote:
> ACK

Pushed.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

2017-06-22 Thread Jason Ekstrand
ACK

On Thu, Jun 22, 2017 at 2:46 PM, Chad Versace 
wrote:

> anv_layout_to_aux_usage() lacked a case for
> VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Add an unreachable case, because we
> don't support the extension.
> ---
>  src/intel/vulkan/anv_image.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index 9405a8c0f93..c84fc8ddeab 100644
> --- a/src/intel/vulkan/anv_image.c
> +++ b/src/intel/vulkan/anv_image.c
> @@ -520,6 +520,9 @@ anv_layout_to_aux_usage(const struct gen_device_info *
> const devinfo,
> case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
>assert(!color_aspect);
>return ISL_AUX_USAGE_HIZ;
> +
> +   case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR:
> +  unreachable("VK_KHR_shared_presentable_image is unsupported");
> }
>
> /* If the layout isn't recognized in the exhaustive switch above, the
> --
> 2.13.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] anv: Fix -Wswitch in anv_layout_to_aux_usage()

2017-06-22 Thread Chad Versace
anv_layout_to_aux_usage() lacked a case for
VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR. Add an unreachable case, because we
don't support the extension.
---
 src/intel/vulkan/anv_image.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 9405a8c0f93..c84fc8ddeab 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -520,6 +520,9 @@ anv_layout_to_aux_usage(const struct gen_device_info * 
const devinfo,
case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
   assert(!color_aspect);
   return ISL_AUX_USAGE_HIZ;
+
+   case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR:
+  unreachable("VK_KHR_shared_presentable_image is unsupported");
}
 
/* If the layout isn't recognized in the exhaustive switch above, the
-- 
2.13.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev